This commit addresses an issue where the validation error for trying to save a Ticket without a Help Topic was not being shown as a result of the error message that was added to ensure that the Help Topic selected is Active.

This commit adds an Admin setting that requires a Ticket to have a Help Topic before it can be closed. It can be set by going to:

Admin Panel | Settings | Tickets | Require Help Topic to Close

If enabled, Tickets will have a warning banner across the bottom of the page, a warning banner when trying to change the Ticket status to Closed, and a warning flag beside the field when editing the Ticket.

By default, this setting is NOT enabled.

This addresses an issue where class Queue sets SavedSearches flags to
`FLAG_QUEUE` causing the SavedSearches to become Primary Queues.

This commit addresses an issue where email alerts were not being properly sent out if the name format is set as 'Last, First' or if it has special characters. We now encode names with quotation marks to ensure that emails are sent out properly (escape possible commas).

This commit adds a validation for Help Topics that are saved using Inline Edit. In the event that a Ticket has a disabled Help Topic assigned to it, we want to display the name of the Help Topic, but we want to make sure that value cannot be saved.

In addition, it makes sure that if the Help Topic is disabled, it is the only disabled Help Topic that shows up in the list.

This addresses an issue with PriorityField Template Variables introduced
with 4359 where the priority variable will appear as "Array" instead of the
actual value. This adds an `asVar()` function to `class PriorityField` to
get the appropriate data.

This commit fixes a mistake where a variable was incorrectly set. This in turn fixes the lint tests.

This addresses an issue where the client side thread entries are all grouped
within the same div. This pushes all grouped entries to one side of the page
making them illegible.

This commit addresses an issue where saved searches were not being ported to
SavedQueues on 1.10.x upgrade to 1.11.x

- Add space between column headers and sort arrow
- Fix sorting by 'Subject' column
- Fix redactor issues with 'Reset' button
	- Make sure text within redactor is cleared correctly
	- Make sure we don't keep attachments if Reset
- Make sure redactor is reinitialized where needed

This addresses issue 4370 where Users responding to tickets via Client
Portal triggers a “Failed to add recipient: @localhost” Mailer Error in the
osTicket Logs. This is due to the `notifyCollaborators()` function that
lacks a check for an empty mailing list.

This address issue 4366 where sending a User a password reset email throws a
fatal error of "object of type EmailAddress cannot be used as an array".
This adds a switch case for EmailAddress to get the User's email address as
a string not an object.

This addresses an issue introduced with 4332 where the deploy CLI breaks
upon deploying to an existing location. This checks to see if there is a
bootstrap file in the destination first and if so it uses that one if not
uses the source.

This addresses an issue on the forums where osTicket does not add the proper
values to any custom choices field template variable. This adds an `asVar()`
function to `class ChoiceField` so we can return the proper values for the
template variables.

This addresses an issue where client side column sorting does not work at
all. This is due to the if/else statement that checks for a REQUEST sort
order and if the REQUEST sort order matches an `$orderWays` array value. The
if statement returns TRUE for DESC and sets the sort order to DESC as it
equals '-' (a dash) but ASC equals '' (an empty string) so it returns FALSE
which fails-over to the else statement setting the sort order to DESC. In
addition, this adds sorting icons the the column headers to make it more
obvious they are sortable.

This addresses an issue introduced with a3d896c8 where TextThreadEntryBodies
are not keeping their new line characters causing the email format to appear
wonky. This balances the entry and then htmlchars it to ensure no XSS.

This address issue 4366 where sending a User a password reset email throws a
fatal error of "object of type EmailAddress cannot be used as an array".
This adds a switch case for EmailAddress to get the User's email address as
a string not an object.

This addresses an issue introduced with 4332 where the deploy CLI breaks
upon deploying to an existing location. This checks to see if there is a
bootstrap file in the destination first and if so it uses that one if not
uses the source.

This addresses an issue where client side column sorting does not work at
all. This is due to the if/else statement that checks for a REQUEST sort
order and if the REQUEST sort order matches an `$orderWays` array value. The
if statement returns TRUE for DESC and sets the sort order to DESC as it
equals '-' (a dash) but ASC equals '' (an empty string) so it returns FALSE
which fails-over to the else statement setting the sort order to DESC. In
addition, this adds sorting icons the the column headers to make it more
obvious they are sortable.

This addresses an issue on the forums where clicking to view the ticket as
an Agent in IE 11 throws a white screen of death. This is due to the
shorthand javascript arrow functions in `include/staff/ticket-view.inc.php`.

- Fix for ‘creating default object from empty value’ message
- Add collaborators in the Ticket::create function instead of Ticket::open so that we can getRecipients in postMessage function
- Add relevant thread_entry_recipients in postMessage function for front end tickets (scp or Web Portal)

Note: This in turn fixes Issue #4354

This commit puts the recipient icon (for one recipient or multiple) on Thread Entries created by Users. It also stores email recipients so you can view them in the Thread Entry Actions.

For Emails:
All recipients in the email are tracked

For front end entries:
All recipients who received an alert are tracked

This addresses an issue on the forums where osTicket does not add the proper
values to any custom choices field template variable. This adds an `asVar()`
function to `class ChoiceField` so we can return the proper values for the
template variables.

This addresses an issue introduced with a3d896c8 where TextThreadEntryBodies
are not keeping their new line characters causing the email format to appear
wonky. This balances the entry and then htmlchars it to ensure no XSS.

This addresses issue 4347 where opening a ticket without an initial message
for the User and replying to it as an agent, fatally errors. This is because
osTicket does not check if there is a last message before getting the ID
from it. So it tries to lookup the ID of a non-object therefore fatally
erroring out.

This commit makes it so that Users are able to see all Thread Events that pertain to a Collaborator being added to the Ticket.

This commit fixes the counts in the Web Portal based on which Tickets the User has access to.

This feature gives Agents the capability deciding whether or not Users should be able to see Tickets to which they are Collaborators for in their Ticket queues.

By default, Users are able to see all Tickets they take part in whether they are the User for the Ticket or a Collaborator.

If the Agent would like to disable Users seeing their Collaborator Tickets, they can configure the setting here:
Admin Panel | Tickets | Settings | Collaborator Tickets Visibility

- Clean up/correct notifyCollaborators function
- Make sure function calls are passing in all needed variables
- getContact function added to EmailRecipient class to properly set up email notifications
- Corrections on encoding recipients for thread entries

This commit fixes an issue where the font for the word 'Collaborators' was being overwritten by the font associated with the icon-caret-right class.

An index was added to the v1.11 branch to support the ORM query. Because the
index cannot be applied to v1.10, the query was rewritten for the 1.10.x
branch to provide better performance without changes to the database. When
1.10.x was merged into 1.11.x the rewritten SQL accidentally showed up. This
reverts that merge to use the original ORM query.

This addresses an issue that was introduced by a previous attempt to
address the orphaned file query. The previous attempt addressed the
original issue but slowed database performance so this addresses the
performance issue.

This addresses an issue where osTicket did not ensure associated items exist
before saving to the database. This also addresses an issue where the Parent
Topic error was not displayed on page.

It may be possible to steal or manipulate customer session and cookies,
which might be used to impersonate a legitimate user, allowing the hacker to
view or alter user records, and to perform transactions as that user.
Sanitation of hazardous characters was not performed correctly on user
input.

osTicket did not properly sanitize array values in `Format::htmlchars()`.
Some values in the Admin Interface were not properly sanitized and returned
to the response.

This addresses an issue on the Forums where the Auto-Assignment Thread
Event (configurable via Help Topic) uses the Email of the User rather than
the User’s Name. This adds the correct function to retrieve the User’s
Name if the User has an Account.

This addresses an issue where disabling Ticket Locks but setting a time
for the Lock Timeout will always throw a "lock required" error. This adds
a check to see if locks are enabled AND there is a time set. If locks are
disabled it will not throw the error.

This addresses issue 4329 where you can import a User with no email
address via CSV file. Once the User is added and you try to update them
with an email address it fails due to no default email. This updates the
check for email address from `!isset()` to `empty()` which will correctly
check for empty string.

This addresses issue 4322 where deploying via CLI is missing
`bootstrap.php`. This is due to the `get_include_dir()` function that
tries to include a file from the destination which doesn’t exist yet,
causing a fatal error. This updates the function to use `$this->source`
instead of `$this->destination` to correctly find and include
`bootstrap.php`.

This addresses issue 4325 where the Language Pack Locales are mismatched.
The Locale for the first language is displayed on the second language,
etc. This updates the `$manifest` variable to be set before we display
data so the correct `MANIFEST` file is included and all language data is
displayed correctly.