Help Topic Required Error Message:

issue: Saved Searches Flags

This commit addresses an issue where the validation error for trying to save a Ticket without a Help Topic was not being shown as a result of the error message that was added to ensure that the Help Topic selected is Active.

Setting - Require Help Topic to Close:

This commit adds an Admin setting that requires a Ticket to have a Help Topic before it can be closed. It can be set by going to:

Admin Panel | Settings | Tickets | Require Help Topic to Close

If enabled, Tickets will have a warning banner across the bottom of the page, a warning banner when trying to change the Ticket status to Closed, and a warning flag beside the field when editing the Ticket.

By default, this setting is NOT enabled.

This addresses an issue where class Queue sets SavedSearches flags to
`FLAG_QUEUE` causing the SavedSearches to become Primary Queues.

Email Name Format:

This commit addresses an issue where email alerts were not being properly sent out if the name format is set as 'Last, First' or if it has special characters. We now encode names with quotation marks to ensure that emails are sent out properly (escape possible commas).

issue: Priority Field Template Variable

Help Topic Inline Save Fix:

This commit adds a validation for Help Topics that are saved using Inline Edit. In the event that a Ticket has a disabled Help Topic assigned to it, we want to display the name of the Help Topic, but we want to make sure that value cannot be saved.

In addition, it makes sure that if the Help Topic is disabled, it is the only disabled Help Topic that shows up in the list.

This addresses an issue with PriorityField Template Variables introduced
with 4359 where the priority variable will appear as "Array" instead of the
actual value. This adds an `asVar()` function to `class PriorityField` to
get the appropriate data.

issue: Redactor Select2 Cursor Position

This address an issue introduced with 4311 where selecting a canned response
does not insert it at last cursor position, rather at the top of the text
box.

Reset Button Fix:

Mailer Typo:

This commit fixes a mistake where a variable was incorrectly set. This in turn fixes the lint tests.

This commit makes sure that when the Reset button is hit, we only reset File Upload Field attachments for the specific form we're on.

Ex: Viewing a Ticket as an Agent and switching between 'Post Reply' and 'Post Internal Note'. If you had an image in the Post Reply file upload but switched to Post Internal Note and hit Reset, only the text/attachments on the Post Internal Note tab would be cleared.

(Improves upon #4369)

issue: Client Side Thread Entries

Conflicts:
	js/redactor-osticket.js

This addresses an issue where the client side thread entries are all grouped
within the same div. This pushes all grouped entries to one side of the page
making them illegible.

This commit addresses an issue where saved searches were not being ported to
SavedQueues on 1.10.x upgrade to 1.11.x

issue: jQuery Sortable Redactor

Web Portal Fixes:

collab: @localhost Mailer Error

- Add space between column headers and sort arrow
- Fix sorting by 'Subject' column
- Fix redactor issues with 'Reset' button
	- Make sure text within redactor is cleared correctly
	- Make sure we don't keep attachments if Reset
- Make sure redactor is reinitialized where needed

This addresses issue 4372 where any Redactor text box within jQuery sortable
is not clickable. This is due to Redactor not being an actual input field,
rather a div, so sortable doesn’t see it as an input.

This addresses issue 4370 where Users responding to tickets via Client
Portal triggers a “Failed to add recipient: @localhost” Mailer Error in the
osTicket Logs. This is due to the `notifyCollaborators()` function that
lacks a check for an empty mailing list.

This address issue 4366 where sending a User a password reset email throws a
fatal error of "object of type EmailAddress cannot be used as an array".
This adds a switch case for EmailAddress to get the User's email address as
a string not an object.