This addresses an issue reported on the Forum where creating a new FAQ and
not filling out required information returns the correct error but returns
the incorrect template (FAQ View Template). This is due to the check for an
FAQ when determining the template to return. This adds a check for the FAQ
ID to determine if it’s an actual FAQ or just a model instance.

This addresses an issue reported on the forum where searching for a keyword
in FAQ search brings back more results than it should. This is due to the
format of the query selecting the results, essentially, the `WHERE NOT`
statement is not properly formatted so the `OR` statements take precedence
over the `WHERE NOT` causing non-public results to be shown to the client.
The `WHERE NOT` statement contains the bit to select from only public faqs
and since the `OR` takes precedence it will return the non-public results
too.

This addresses issue 4756 where the `%{recipient.ticket_link}` variable is
not being replaced when the canned response is loaded in the reply box; all
other link variables work. This is due to the recipient object not being
passed to the variableReplacer which means the ticket_link is not available.
This adds the recipient object to the variableReplacer so the ticket_link
variable is properly replaced like the others on load.

This addresses issue 4716 where updating a Ticket Status throws a fatal
error of "Too few arguments" when using PHP 7.2. This is due to `$errors`
not being passed to the `update()` function causing PHP 7.2 to freak out.
This creates an `$errors` array and passes it to `update()` so PHP 7.2 is
happy and we are all happy. :)

This addresses issue 4738 where the Upgrade and Migration Guide link is
incorrect. This updates the link to the new Documentation site.

This pull request is wayyyy overdue. This updates jQuery and all related
files to the latest jQuery release (3.3.1). This also adds a new script
called jQuery-Migrate that maintains older functions needed for a few things
(eg. `filedrop.field.js`).

This addresses an issue where the Loading overlay on Tasks will not
disappear after the request was submitted. This adds two lines to first hide
the "Loading" modal and then toggle the overlay.

This commit addresses issues we had with viewing Task(s) within a Ticket:

1. When viewing the table of all Tasks on a Ticket, the Options dropdown should only allow the Agent to Reopen or Close the Tasks based on the status of the Tasks.
Ex: If there is only 1 Open Task, you should only see the 'Close' Option
    If there are 2 Closed Tasks, you should only see the 'Reopen' Option
    If there are multiple Tasks in which some are Open and some are Closed, you should see both the 'Reopen' and 'Close' options

2. When viewing an individual Task within a Ticket, the status options were the opposite of what they should have been. Now, if the Task is Open, the Agent will see the option to 'Close' the Task. If the Task is Closded, the Agent will see the option to 'Reopen' the Task.

This addresses an issue where exporting statistics via the dashboard within
a certain timeframe (eg. 07/01/2018 -> One Quarter) will always export the
statistics from the selected date up to today. This is due to the Period
option always being set to "Up to today" when the Export button is clicked
which in return exports the stats from the selected start date to today.
This adds JS to set the period the Agent selects so the Export will return
the stats from the selected date to the selected period.

This addresses an issue where Users updating their profile will throw an SQL
error in the system logs. This is due to a line of code trying to set a
value for the `dst` column which no longer exists as of `1.10.0`.

This addresses an issue introduced with 4426 that references an undefined
class.

This improves accessibility by adding screen readable labels to ticket
actions that don’t already have them.

This addresses issue 4470 where Users creating tickets via Client Portal and
failing to fill out a required field makes disabled fields by Help Topic
appear on the page. When the disabled fields appear they allow Users to
populate and save data that they were not meant to submit.

This addresses an issue where people who do not have a phone field on the
contact information form go to search for a User in the User Directory and
the system crashes. This is due to the search query that always contains the
phone field variable. This only adds the phone variable to the search query
if the field actually exists.

Allow ticket assignee to see tasks associated with the ticket.

This addresses an issue where `SetAutoFont()` was making the Thai PDFs
break. This adds the `AUTOFONT_RTL` flag to only autodetect RTL languages
and nothing else.

This addresses an issue where creating an advanced search with selection
field "does not have a value" throws a fatal error. This was due to an
improperly named search method "notset".

This adds functionality to clean expired password reset tokens on cron runs.

This adds a Signal to clean Agent and User sessions upon setting/resetting
their password. If an Agent/User resets their own password and has multiple
sessions open it will log them out of every session except the one they’re
on.

This commit addresses the root cause of an issue commit 96892beb (now
        reverted) attempted to solve - by providing consistency between
getFiles and getAttachments

This addresses issue 4449 where using an Arabic language pack and trying to
print a ticket returns a PDF with either squares for text or no text at all.

This addresses an issue where searching for a Task by title returns all
Tasks in the search. This is due to the visibility filtering methods used to
filter tickets by staff's visibility.

This commit removes the logic that was used for time within 2 days which would give a result of either today or tomorrow when something could actually be in 2 days instead.

It also rounds relative time that is within 29 days so that the result will be more accurate.
Ex: 1.99 will round to 2 instead of showing 1

This alphabetizes all Role and Staff Permissions.

This addresses an issue reported on the forums where the ticket filter Rule
option of “Does Not Match Regex” isn’t working properly; instead it works in
reverse.

This addresses an issue where it appeared as though tasks could not be assigned to teams if an agent in the team was not a part of the task's department. The assigment was actually taking place, however, it was not showing up in the Assignee column. Now the form will correctly display the column

This addresses an issue where uploading a file you’ve uploaded before but
renamed is not saving the new name in the Attachment table.

This addresses an issue where FileUploadFields are displaying the old names
of existing files with new names.

This addresses an issue where the client portal shows Featured FAQs on the
sidebar even thought the Knowledgebase is Disabled.

This addresses an issue introduced with `9ab2317e` where the icon for the
event still shows even though we continued and didn’t return the event
description.

This reverts commit 14bcd42d.

This addresses issue 4155 where editing a ticket using a different session
causes custom file uploads to drop from the ticket.

This addresses an issue where deleting a field and all it's data will
delete the form field record in the database causing all events containing
the field to crash the ticket page.

This addresses an issue with PriorityField Template Variables introduced
with 4359 where the priority variable will appear as "Array" instead of the
actual value. This adds an `asVar()` function to `class PriorityField` to
get the appropriate data.

This addresses an issue where the client side thread entries are all grouped
within the same div. This pushes all grouped entries to one side of the page
making them illegible.

- Add space between column headers and sort arrow
- Fix sorting by 'Subject' column
- Fix redactor issues with 'Reset' button
	- Make sure text within redactor is cleared correctly
	- Make sure we don't keep attachments if Reset
- Make sure redactor is reinitialized where needed

This addresses an issue introduced with 4332 where the deploy CLI breaks
upon deploying to an existing location. This checks to see if there is a
bootstrap file in the destination first and if so it uses that one if not
uses the source.

This addresses an issue where client side column sorting does not work at
all. This is due to the if/else statement that checks for a REQUEST sort
order and if the REQUEST sort order matches an `$orderWays` array value. The
if statement returns TRUE for DESC and sets the sort order to DESC as it
equals '-' (a dash) but ASC equals '' (an empty string) so it returns FALSE
which fails-over to the else statement setting the sort order to DESC. In
addition, this adds sorting icons the the column headers to make it more
obvious they are sortable.

This addresses an issue on the forums where osTicket does not add the proper
values to any custom choices field template variable. This adds an `asVar()`
function to `class ChoiceField` so we can return the proper values for the
template variables.