Skip to content
Snippets Groups Projects
  1. Aug 17, 2018
    • JediKev's avatar
      queues: Row Conditions · c6cd84f0
      JediKev authored
      This addresses an issue where row conditions are working in the preview but
      not in the actual ticket queue. This updates the `getQueue()` function to
      lookup the CustomQueue by `queue_id` if there is no CustomQueue object found
      in the QueueColumn.
      c6cd84f0
  2. Aug 08, 2018
    • aydreeihn's avatar
      Search All Tickets Setting · f50ef72f
      aydreeihn authored
      If an Agent has the Miscellaneous setting checked to see all Tickets in search results, they should be able to see the list of Tickets regardless of their access or if the search is saved or not. They should NOT, however, be able to view those Tickets.
      f50ef72f
    • aydreeihn's avatar
      Advanced Search: TicketStatus / Status Name · cf528fb6
      aydreeihn authored
      This commit adds 'TicketStatus / Status Name' to the main search criteria list for advanced searching.
      cf528fb6
  3. Aug 07, 2018
  4. Aug 06, 2018
    • JediKev's avatar
      issue: Featured FAQs On Disable · b59b2641
      JediKev authored
      This addresses an issue where the client portal shows Featured FAQs on the
      sidebar even thought the Knowledgebase is Disabled.
      b59b2641
    • aydreeihn's avatar
      Team Referral Check · 92844554
      aydreeihn authored
      This commit adds an additional check for Team referrals in the isReferred method so that it is handled in the same way Staff and Departments are handled.
      92844554
    • aydreeihn's avatar
      Referral Assignment Issue: · f9c955d7
      aydreeihn authored
      This commit fixes an issue where referrals were being considered successfully saved even if that referral already existed, resulting in multiple thread events for the same referral.
      
      Instead, if we find that the thread is already referred to the referee, refer should return false so that an error message is displayed stating that we were unable to refer the ticket.
      f9c955d7
    • JediKev's avatar
      issue: Deleted Field Thread Events (template) · 45a46460
      JediKev authored
      This addresses an issue introduced with `9ab2317e` where the icon for the
      event still shows even though we continued and didn’t return the event
      description.
      45a46460
    • JediKev's avatar
      status: Allow Reopen · 310017b1
      JediKev authored
      This addresses an issue introduced with `510046c5` where tickets with no
      Help Topic can not be reopened. This is due to a check on `isReopenable()`
      where it returns `null` instead of `true` if there is no help topic;
      therefore returning false and not allowing the ticket to be reopened.
      310017b1
  5. Aug 05, 2018
  6. Aug 04, 2018
    • Jared Hancock's avatar
      queue: Improve queries necessary for rendering · 59d645a7
      Jared Hancock authored
      This removes a significant number of queries used to render the drop-down
      menu for the queues.
      
      Each queue displayed on the page previously required a database query to
      determine its children. This patch changes the strategy to fetch all the
      queues and organize them as a tree. The tree can then be walked as the menu
      is rendered and does not require any further queries.
      
      On my test system, it reduces the number of queries for the ticket listing
      page from 56 to 46.
      59d645a7
    • Jared Hancock's avatar
      queue: Fix several issues · c12fb23c
      Jared Hancock authored
      This might happen if the close date was added to a queue and filtered
      through a date/time filter.
      
      Also fix warning emit when editing queue configuration
      
      Also fix a few crashes if there is a naming mismatch on the field named in
      search criteria and the current name of the field. And fix a regression
      where the queue criteria would not be properly updated when saved.
      
      If a queue inherits columns from a parent, the conditions would also be
      inherited. This fix changes the association by linking the inherited
      column to the child queue at run-time. This allows the queue column to
      fetch the queue conditions from the child queue which inherited the
      columns.
      
      Check 'inherit columns' checkbox when cloning a queue
      
      Fix doubled saved search listing
      c12fb23c
  7. Aug 03, 2018
    • JediKev's avatar
      issue: Custom File Upload Dropping · 14bcd42d
      JediKev authored
      This addresses issue 4155 where editing a ticket using a different session
      causes custom file uploads to drop from the ticket.
      14bcd42d
  8. Aug 02, 2018
    • aydreeihn's avatar
      Help Topic Required Error Message: · 9ef8f789
      aydreeihn authored
      This commit addresses an issue where the validation error for trying to save a Ticket without a Help Topic was not being shown as a result of the error message that was added to ensure that the Help Topic selected is Active.
      9ef8f789
    • aydreeihn's avatar
      Setting - Require Help Topic to Close: · cd3088c3
      aydreeihn authored
      This commit adds an Admin setting that requires a Ticket to have a Help Topic before it can be closed. It can be set by going to:
      
      Admin Panel | Settings | Tickets | Require Help Topic to Close
      
      If enabled, Tickets will have a warning banner across the bottom of the page, a warning banner when trying to change the Ticket status to Closed, and a warning flag beside the field when editing the Ticket.
      
      By default, this setting is NOT enabled.
      cd3088c3
    • JediKev's avatar
      issue: Saved Searches Flags · 97203c32
      JediKev authored
      This addresses an issue where class Queue sets SavedSearches flags to
      `FLAG_QUEUE` causing the SavedSearches to become Primary Queues.
      97203c32
    • aydreeihn's avatar
      Email Name Format: · e9a83423
      aydreeihn authored
      This commit addresses an issue where email alerts were not being properly sent out if the name format is set as 'Last, First' or if it has special characters. We now encode names with quotation marks to ensure that emails are sent out properly (escape possible commas).
      e9a83423
  9. Aug 01, 2018
    • JediKev's avatar
      issue: Deleted FieVld Thread Events · 9ab2317e
      JediKev authored
      This addresses an issue where deleting a field and all it's data will
      delete the form field record in the database causing all events containing
      the field to crash the ticket page.
      9ab2317e
    • aydreeihn's avatar
      Help Topic Inline Save Fix: · 00a3be21
      aydreeihn authored
      This commit adds a validation for Help Topics that are saved using Inline Edit. In the event that a Ticket has a disabled Help Topic assigned to it, we want to display the name of the Help Topic, but we want to make sure that value cannot be saved.
      
      In addition, it makes sure that if the Help Topic is disabled, it is the only disabled Help Topic that shows up in the list.
      00a3be21
    • JediKev's avatar
      issue: Priority Field Template Variable · 2433b8f9
      JediKev authored
      This addresses an issue with PriorityField Template Variables introduced
      with 4359 where the priority variable will appear as "Array" instead of the
      actual value. This adds an `asVar()` function to `class PriorityField` to
      get the appropriate data.
      2433b8f9
  10. Jul 31, 2018
    • aydreeihn's avatar
      Mailer Typo: · 7253baf2
      aydreeihn authored
      This commit fixes a mistake where a variable was incorrectly set. This in turn fixes the lint tests.
      7253baf2
    • JediKev's avatar
      issue: Client Side Thread Entries · e012bea1
      JediKev authored
      This addresses an issue where the client side thread entries are all grouped
      within the same div. This pushes all grouped entries to one side of the page
      making them illegible.
      e012bea1
    • Peter Rotich's avatar
      SavedSearch Fixup · eadccc2a
      Peter Rotich authored
      This commit addresses an issue where saved searches were not being ported to
      SavedQueues on 1.10.x upgrade to 1.11.x
      eadccc2a
  11. Jul 30, 2018
    • aydreeihn's avatar
      Web Portal Fixes: · 4decaeca
      aydreeihn authored
      - Add space between column headers and sort arrow
      - Fix sorting by 'Subject' column
      - Fix redactor issues with 'Reset' button
      	- Make sure text within redactor is cleared correctly
      	- Make sure we don't keep attachments if Reset
      - Make sure redactor is reinitialized where needed
      4decaeca
    • JediKev's avatar
      collab: @localhost Mailer Error · 1bd37820
      JediKev authored
      This addresses issue 4370 where Users responding to tickets via Client
      Portal triggers a “Failed to add recipient: @localhost” Mailer Error in the
      osTicket Logs. This is due to the `notifyCollaborators()` function that
      lacks a check for an empty mailing list.
      1bd37820
    • JediKev's avatar
      mailer: EmailAddress Object as Array · effa8aeb
      JediKev authored
      This address issue 4366 where sending a User a password reset email throws a
      fatal error of "object of type EmailAddress cannot be used as an array".
      This adds a switch case for EmailAddress to get the User's email address as
      a string not an object.
      effa8aeb
    • JediKev's avatar
      issue: CLI Deploy Missing Bootstrap Fix · 2dc08a9e
      JediKev authored
      This addresses an issue introduced with 4332 where the deploy CLI breaks
      upon deploying to an existing location. This checks to see if there is a
      bootstrap file in the destination first and if so it uses that one if not
      uses the source.
      2dc08a9e
    • JediKev's avatar
      issue: ChoiceField Template Variable · 759b004c
      JediKev authored
      This addresses an issue on the forums where osTicket does not add the proper
      values to any custom choices field template variable. This adds an `asVar()`
      function to `class ChoiceField` so we can return the proper values for the
      template variables.
      759b004c
    • JediKev's avatar
      issue: Client Side Column Sorting · 9c7a8386
      JediKev authored
      This addresses an issue where client side column sorting does not work at
      all. This is due to the if/else statement that checks for a REQUEST sort
      order and if the REQUEST sort order matches an `$orderWays` array value. The
      if statement returns TRUE for DESC and sets the sort order to DESC as it
      equals '-' (a dash) but ASC equals '' (an empty string) so it returns FALSE
      which fails-over to the else statement setting the sort order to DESC. In
      addition, this adds sorting icons the the column headers to make it more
      obvious they are sortable.
      9c7a8386
    • JediKev's avatar
      issue: TextThreadEntryBody Sanitize · cec8be8e
      JediKev authored
      This addresses an issue introduced with a3d896c8 where TextThreadEntryBodies
      are not keeping their new line characters causing the email format to appear
      wonky. This balances the entry and then htmlchars it to ensure no XSS.
      cec8be8e
  12. Jul 26, 2018
    • JediKev's avatar
      mailer: EmailAddress Object as Array · debf76de
      JediKev authored
      This address issue 4366 where sending a User a password reset email throws a
      fatal error of "object of type EmailAddress cannot be used as an array".
      This adds a switch case for EmailAddress to get the User's email address as
      a string not an object.
      debf76de
  13. Jul 25, 2018
  14. Jul 24, 2018
    • JediKev's avatar
      issue: CLI Deploy Missing Bootstrap Fix · 2dacfde0
      JediKev authored
      This addresses an issue introduced with 4332 where the deploy CLI breaks
      upon deploying to an existing location. This checks to see if there is a
      bootstrap file in the destination first and if so it uses that one if not
      uses the source.
      2dacfde0
    • JediKev's avatar
      issue: Client Side Column Sorting · 1a92dcb1
      JediKev authored
      This addresses an issue where client side column sorting does not work at
      all. This is due to the if/else statement that checks for a REQUEST sort
      order and if the REQUEST sort order matches an `$orderWays` array value. The
      if statement returns TRUE for DESC and sets the sort order to DESC as it
      equals '-' (a dash) but ASC equals '' (an empty string) so it returns FALSE
      which fails-over to the else statement setting the sort order to DESC. In
      addition, this adds sorting icons the the column headers to make it more
      obvious they are sortable.
      1a92dcb1
    • JediKev's avatar
      issue: IE White Screen Of Death · ab7844ae
      JediKev authored
      This addresses an issue on the forums where clicking to view the ticket as
      an Agent in IE 11 throws a white screen of death. This is due to the
      shorthand javascript arrow functions in `include/staff/ticket-view.inc.php`.
      ab7844ae
  15. Jul 23, 2018
    • aydreeihn's avatar
      Collaborator Fixes: · a4de3514
      aydreeihn authored
      - Fix for ‘creating default object from empty value’ message
      - Add collaborators in the Ticket::create function instead of Ticket::open so that we can getRecipients in postMessage function
      - Add relevant thread_entry_recipients in postMessage function for front end tickets (scp or Web Portal)
      
      Note: This in turn fixes Issue #4354
      a4de3514
    • aydreeihn's avatar
      Recipients Icon + View Email Recipients for Users · 8c707b5d
      aydreeihn authored
      This commit puts the recipient icon (for one recipient or multiple) on Thread Entries created by Users. It also stores email recipients so you can view them in the Thread Entry Actions.
      
      For Emails:
      All recipients in the email are tracked
      
      For front end entries:
      All recipients who received an alert are tracked
      8c707b5d
    • JediKev's avatar
      issue: ChoiceField Template Variable · 59ec7afc
      JediKev authored
      This addresses an issue on the forums where osTicket does not add the proper
      values to any custom choices field template variable. This adds an `asVar()`
      function to `class ChoiceField` so we can return the proper values for the
      template variables.
      59ec7afc
  16. Jul 20, 2018
    • JediKev's avatar
      issue: TextThreadEntryBody Sanitize · d8abe105
      JediKev authored
      This addresses an issue introduced with a3d896c8 where TextThreadEntryBodies
      are not keeping their new line characters causing the email format to appear
      wonky. This balances the entry and then htmlchars it to ensure no XSS.
      d8abe105
Loading