Skip to content
Snippets Groups Projects
  1. Aug 02, 2018
    • aydreeihn's avatar
      Help Topic Required Error Message: · 9ef8f789
      aydreeihn authored
      This commit addresses an issue where the validation error for trying to save a Ticket without a Help Topic was not being shown as a result of the error message that was added to ensure that the Help Topic selected is Active.
      9ef8f789
    • aydreeihn's avatar
      Setting - Require Help Topic to Close: · cd3088c3
      aydreeihn authored
      This commit adds an Admin setting that requires a Ticket to have a Help Topic before it can be closed. It can be set by going to:
      
      Admin Panel | Settings | Tickets | Require Help Topic to Close
      
      If enabled, Tickets will have a warning banner across the bottom of the page, a warning banner when trying to change the Ticket status to Closed, and a warning flag beside the field when editing the Ticket.
      
      By default, this setting is NOT enabled.
      cd3088c3
  2. Jul 24, 2018
    • JediKev's avatar
      issue: IE White Screen Of Death · ab7844ae
      JediKev authored
      This addresses an issue on the forums where clicking to view the ticket as
      an Agent in IE 11 throws a white screen of death. This is due to the
      shorthand javascript arrow functions in `include/staff/ticket-view.inc.php`.
      ab7844ae
  3. Jul 18, 2018
    • aydreeihn's avatar
      Collaborator Tickets Visibility: · e9db21a5
      aydreeihn authored
      This feature gives Agents the capability deciding whether or not Users should be able to see Tickets to which they are Collaborators for in their Ticket queues.
      
      By default, Users are able to see all Tickets they take part in whether they are the User for the Ticket or a Collaborator.
      
      If the Agent would like to disable Users seeing their Collaborator Tickets, they can configure the setting here:
      Admin Panel | Tickets | Settings | Collaborator Tickets Visibility
      e9db21a5
    • aydreeihn's avatar
      Email Recipients Revisited Corrections · 731c9fe9
      aydreeihn authored
      - Clean up/correct notifyCollaborators function
      - Make sure function calls are passing in all needed variables
      - getContact function added to EmailRecipient class to properly set up email notifications
      - Corrections on encoding recipients for thread entries
      731c9fe9
    • aydreeihn's avatar
      Ticket-View Collaborator Collapsible Fix: · 7be98ee7
      aydreeihn authored
      This commit fixes an issue where the font for the word 'Collaborators' was being overwritten by the font associated with the icon-caret-right class.
      7be98ee7
  4. Jul 17, 2018
    • JediKev's avatar
      department: Error Feedback · 9f3b6b27
      JediKev authored
      This addresses an issue where osTicket did not ensure associated items exist
      before saving to the database. This also addresses an issue where the Parent
      Topic error was not displayed on page.
      9f3b6b27
    • JediKev's avatar
      security: Fix Multiple XSS Vulnerabilies · 4b8ee133
      JediKev authored
      It may be possible to steal or manipulate customer session and cookies,
      which might be used to impersonate a legitimate user, allowing the hacker to
      view or alter user records, and to perform transactions as that user.
      Sanitation of hazardous characters was not performed correctly on user
      input.
      
      osTicket did not properly sanitize array values in `Format::htmlchars()`.
      Some values in the Admin Interface were not properly sanitized and returned
      to the response.
      4b8ee133
    • JediKev's avatar
      issue: Language Pack Locale Mismatch · 132d838f
      JediKev authored
      This addresses issue 4325 where the Language Pack Locales are mismatched.
      The Locale for the first language is displayed on the second language,
      etc. This updates the `$manifest` variable to be set before we display
      data so the correct `MANIFEST` file is included and all language data is
      displayed correctly.
      132d838f
  5. Jul 16, 2018
  6. Jul 13, 2018
    • aydreeihn's avatar
      Revisiting Collaborator: · 4c46f9f5
      aydreeihn authored
      - Ticket View UI changes
      - Mailer logic improvements
      - Ticket Open consolidated for mailer changes
      4c46f9f5
    • Peter Rotich's avatar
      Misc. Fixes · dbb6fe3c
      Peter Rotich authored
      dbb6fe3c
    • Peter Rotich's avatar
      Collaborators Revisited · c8872285
      Peter Rotich authored
      UI changes to make it more user friendly
      c8872285
    • JediKev's avatar
      department: Error Feedback · d9beb14e
      JediKev authored
      This addresses an issue where osTicket did not ensure associated items exist
      before saving to the database. This also addresses an issue where the Parent
      Topic error was not displayed on page.
      d9beb14e
    • JediKev's avatar
      security: Fix Multiple XSS Vulnerabilies · a3d896c8
      JediKev authored
      It may be possible to steal or manipulate customer session and cookies,
      which might be used to impersonate a legitimate user, allowing the hacker to
      view or alter user records, and to perform transactions as that user.
      Sanitation of hazardous characters was not performed correctly on user
      input.
      
      osTicket did not properly sanitize array values in `Format::htmlchars()`.
      Some values in the Admin Interface were not properly sanitized and returned
      to the response.
      a3d896c8
  7. Jul 11, 2018
    • aydreeihn's avatar
      69b17888
    • aydreeihn's avatar
      Minor Fix: · a24cafea
      aydreeihn authored
      For new tickets, hide the Ticket Notice dropdown if the 'New Ticket by Agent' autoresponse is disabled since no response will be sent
      a24cafea
    • JediKev's avatar
      feature: Release Role Permission · d354e095
      JediKev authored
      This feature adds a new Role permission called Release. This permission
      (if Enabled) allows an Agent to release ticket assignment. This permission
      is configurable for each and every Role in the helpdesk. This also keeps
      current functionality where Department Managers do not need the Role
      Permission in order to release tickets. In addition to the permission,
      this feature adds a new Release modal giving the option to choose who to
      release assignment from (Agent/Team/Both). This also adds a comment box to
      the release modal to optionally enter a reason for releasing assignment.
      Lastly, this adds a Release Thread Event so an event is logged showing who
      released who’s assignment.
      d354e095
  8. Jul 09, 2018
    • JediKev's avatar
      Feature :: Manage Referrals Role Permission · 204c8db6
      JediKev authored
      This feature adds a new Role permission called Manage Referrals. This
      permission allows Agents to Manage Ticket Referrals. This permission
      is configurable for each and every Role in the helpdesk.
      204c8db6
  9. Jul 05, 2018
    • aydreeihn's avatar
    • JediKev's avatar
      issue: Queue Export Sorting · eeccbf30
      JediKev authored
      This addresses an issue where the Queue Export does not remember your
      column sorting. This was due to the `getExportableFields()` function
      called in the Export Template that gets a predefined list of fields plus
      some `cdata` fields with a predefined sort order (not your saved sort
      order). This updates the export template to merge the `$fields` array that
      contains the exportable fields in the saved sorting order and the
      `getExportableFields()` result (array) that contains the same fields plus
      `cdata` fields. This will return the fields in the saved sorting order
      whilst still displaying possible `cdata` fields.
      eeccbf30
  10. Jul 03, 2018
    • JediKev's avatar
      issue: Language Pack Locale Mismatch · a87f19d3
      JediKev authored
      This addresses issue 4325 where the Language Pack Locales are mismatched.
      The Locale for the first language is displayed on the second language,
      etc. This updates the `$manifest` variable to be set before we display
      data so the correct `MANIFEST` file is included and all language data is
      displayed correctly.
      a87f19d3
  11. Jun 28, 2018
  12. Jun 05, 2018
    • aydreeihn's avatar
      This commit completely removes the BCC functionality. · d93089b3
      aydreeihn authored
      This means Agents can no longer choose to add a BCC User while creating or responding to a Ticket.
      
      This also means that if a User emails in a Ticket where someone is BCC'd, the Ticket will be created without the BCC'd User(s).
      
      If an email is sent where the Department email is BCC'd, a Ticket is created for that Department and other Users in the email are added as Collaborators.
      
      This also changes the response options for Agents. They now have the options to:
      - Reply All (User + Collaborators)
      - Reply to User (only the User)
      - Do not Email Reply
      
      (Previously the options were Reply All, Reply to User, Reply to CC + User, Reply to BCC, Do not Email Reply)
      d93089b3
  13. May 25, 2018
    • aydreeihn's avatar
      New Ticket UI Changes + Some Post Reply UI Changes · cccc6217
      aydreeihn authored
      New Ticket UI:
      - Clean up recipient section (adding user and collaborators)
      - Give agents the option of who to send the new ticket alert to:
      	- Alert to All
      	- Alert to User
      	- Alert to CC + User
      	- Alert to BCC
      	- Do not send an Alert
      - Added option of adding new Users for cc/bcc section using the 'Add New' button
      
      Post Reply UI:
      - Instead of having to type to get the option of adding a new user in the cc/bcc boxes, put an Add New button
      - Clean up Add New routine
      	- Now when adding a new collaborator using the Add New button, the User's name will appear in the cc or bcc box as specified and the Agent can go ahead and write their reply rather than pulling up the manage collaborators popup and forcing the agent to have to save the collaborator changes before being able to type a reply
      - Change the option "Reply to Collaborators" to "Reply to CC + User" to avoid confusion
      cccc6217
  14. May 22, 2018
    • aydreeihn's avatar
      This commit modifies the UI for Post Reply when an Agent views a Ticket. · 7a29022d
      aydreeihn authored
      - Change To dropdown to have different reply types
      	- Reply to All
      	- Reply to User
      	- Reply to Collaborators
      	- Reply to BCC
      - Add a help tip for the new reply types
      - Set the reply type selected based on the last user respondent
      	- Reply to Collaborator by default or if the last message is from the ticket user or a CC collaborator
      	- Reply to BCC if the last message is from a BCC user
      - Put User, CC, and Bcc fields below and indented as appropriate (User field is readonly)
      - Add a new flag to Agent responses to show which reply type they selected. Put the flag on Agent thread entries
      7a29022d
  15. May 17, 2018
    • aydreeihn's avatar
      Create Task/Ticket From Thread Entry Fixes: · 1b5cf050
      aydreeihn authored
      - unset the sessions form data only in necessary places
      - refer to a tasks number instead of id in internal notes
      - use indexOf instead of includes in js for IE compatibility
      1b5cf050
  16. May 16, 2018
    • aydreeihn's avatar
      Creating Tasks/Tickets From Thread Entry Fixes: · b7db24aa
      aydreeihn authored
      - say created from thread entry instead of created from thread
      - make sure that links to thread entry do not open in new window
      - make sure if default help topic is selected, message data carries over
        - make sure if issue details are not included for a help topic form, we
          make sure there is a message before trying to get attachments for one
      - do not pass in an object to session array. use id and do lookup after instead
      b7db24aa
  17. May 15, 2018
    • aydreeihn's avatar
      Creating Tasks/Tickets from Thread: · 01323881
      aydreeihn authored
      When a Task or Ticket is created from a Thread, this code
      adds the functionality to create an Internal Note in the
      new Ticket or Task as well as the original Ticker or
      Task to show the activity that happened.
      01323881
    • Mat Whitney's avatar
      Check permissions before displaying Close Task · f62e9669
      Mat Whitney authored
      Don't display the Close Task option if the current user can't close it...
      f62e9669
    • JediKev's avatar
      issue: Prevent Click Jacking · 8c3f7a5f
      JediKev authored
      This addresses a vulnerability where there was no `X-Frame-Options` header
      which could potentially allow click jacking. This adds the
      `X-Frame-Options: SAMEORIGIN` header so it will remove any chance of click
      jacking. According to Mozilla Developer Docs:
      ```
      SAMEORIGIN
      The page can only be displayed in a frame on the same origin as the page
      itself.
      ```
      8c3f7a5f
    • JediKev's avatar
      issue: Information Page Performance · 5b5e8c98
      JediKev authored
      This addresses an issue on the forums where the query to determine the
      size of the `file_chunk` table is making the page load really slow for
      people with large tables. This updates the query to improve the
      performance of the page load time.
      5b5e8c98
    • JediKev's avatar
      issue: Org. User Account Status · d3beb9e8
      JediKev authored
      This addresses an issue where the User’s account status is always 'Active'
      in the Organization list no matter what their actual status is. This adds the
      account status to the user query which adds the correct status to the Users’
      account.
      d3beb9e8
  18. May 09, 2018
    • JediKev's avatar
      issue: Information Page Performance · dfa0f3f0
      JediKev authored
      This addresses an issue on the forums where the query to determine the
      size of the `file_chunk` table is making the page load really slow for
      people with large tables. This updates the query to improve the
      performance of the page load time.
      dfa0f3f0
  19. May 07, 2018
    • aydreeihn's avatar
      Issues Creating Task/Ticket from Thread · 91ef1bfd
      aydreeihn authored
      - In class.forms.php, $this->field->getClean() was null so $new was not populated and attachments were not being carried over, so we must get the fileIds directly from the form-data array
      - We need to unset the form-data for attachment fields (on tasks and tickets) so that the array is empty each time we try to create a task or ticket from a thread
      - We need to add files attached to threads where we are creating a task or ticket to the list of allowed files otherwise they will not carry over to new tasks/tickets (only files uploaded by this user in this session were allowed previously)
      91ef1bfd
  20. May 03, 2018
    • JediKev's avatar
      issue: Prevent Click Jacking · bb5564d4
      JediKev authored
      This addresses a vulnerability where there was no `X-Frame-Options` header
      which could potentially allow click jacking. This adds the
      `X-Frame-Options: SAMEORIGIN` header so it will remove any chance of click
      jacking. According to Mozilla Developer Docs:
      ```
      SAMEORIGIN
      The page can only be displayed in a frame on the same origin as the page
      itself.
      ```
      bb5564d4
    • aydreeihn's avatar
      Quick Fixes: · cf8f7578
      aydreeihn authored
      - On ticket edit, only display inactive help topic warning if the ticket has a help topic
      - Inline edit file save fix
      - Remove future search/filter criteria for datetime fields that can't be in the future
      - Fix calculations for 'next 7 days' and 'next 30 days'. They were selecting dates between now and n days AGO instead of between now and n days in the future
      cf8f7578
  21. May 02, 2018
    • aydreeihn's avatar
      Quick Fix: · a72ff49f
      aydreeihn authored
      - On ticket edit, only display inactive help topic warning if the ticket has a help topic
      a72ff49f
  22. May 01, 2018
Loading