Skip to content
Snippets Groups Projects
  1. Mar 11, 2019
    • JediKev's avatar
      iframe: Allow Multiple iFrame Domains · 4f7c4dcb
      JediKev authored
      Previously, we added a security header to prevent click-jacking called
      "X-Frame-Options". This introduced an issue with people using osTicket in
      iFrames on their websites. To mitigate the issue, this updates the security
      header to allow the site to be framed from specified domains, if none
      provided we default to 'self'. This adds a new field to General System
      Settings called "Allow iFrames" where you may enter a comma separated list
      of domains that the site can be framed on. This also adds a validator for
      the field to validate the domains and ensure they fit the <host-source>
      syntax from [Mozilla Developer
      Docs](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-ancestors#Sources).
      4f7c4dcb
  2. Mar 04, 2019
    • JediKev's avatar
      issue: FAQ Return Errors · f591cafe
      JediKev authored
      This addresses an issue reported on the Forum where creating a new FAQ and
      not filling out required information returns the correct error but returns
      the incorrect template (FAQ View Template). This is due to the check for an
      FAQ when determining the template to return. This adds a check for the FAQ
      ID to determine if it’s an actual FAQ or just a model instance.
      f591cafe
    • JediKev's avatar
      issue: FAQ Search Results · cd4ba226
      JediKev authored
      This addresses an issue reported on the forum where searching for a keyword
      in FAQ search brings back more results than it should. This is due to the
      format of the query selecting the results, essentially, the `WHERE NOT`
      statement is not properly formatted so the `OR` statements take precedence
      over the `WHERE NOT` causing non-public results to be shown to the client.
      The `WHERE NOT` statement contains the bit to select from only public faqs
      and since the `OR` takes precedence it will return the non-public results
      too.
      cd4ba226
  3. Feb 26, 2019
    • JediKev's avatar
      issue: Canned Response Variables · 1c8e97c8
      JediKev authored
      This addresses issue 4756 where the `%{recipient.ticket_link}` variable is
      not being replaced when the canned response is loaded in the reply box; all
      other link variables work. This is due to the recipient object not being
      passed to the variableReplacer which means the ticket_link is not available.
      This adds the recipient object to the variableReplacer so the ticket_link
      variable is properly replaced like the others on load.
      1c8e97c8
    • JediKev's avatar
      issue: PHP 7.2 Ticket Status · cb710243
      JediKev authored
      This addresses issue 4716 where updating a Ticket Status throws a fatal
      error of "Too few arguments" when using PHP 7.2. This is due to `$errors`
      not being passed to the `update()` function causing PHP 7.2 to freak out.
      This creates an `$errors` array and passes it to `update()` so PHP 7.2 is
      happy and we are all happy. :)
      cb710243
  4. Feb 14, 2019
    • JediKev's avatar
      issue: Upgrader Wrong Guide Link · 61e240c3
      JediKev authored
      This addresses issue 4738 where the Upgrade and Migration Guide link is
      incorrect. This updates the link to the new Documentation site.
      61e240c3
  5. Jan 31, 2019
    • JediKev's avatar
      jq: Update To jQuery-3.3.1 · 4febc785
      JediKev authored
      This pull request is wayyyy overdue. This updates jQuery and all related
      files to the latest jQuery release (3.3.1). This also adds a new script
      called jQuery-Migrate that maintains older functions needed for a few things
      (eg. `filedrop.field.js`).
      4febc785
  6. Jan 17, 2019
    • JediKev's avatar
      issue: Hide Task Loading Overlay · 786653ef
      JediKev authored
      This addresses an issue where the Loading overlay on Tasks will not
      disappear after the request was submitted. This adds two lines to first hide
      the "Loading" modal and then toggle the overlay.
      786653ef
  7. Jan 03, 2019
    • aydreeihn's avatar
      Issue: Tasks Within Tickets · 85f42422
      aydreeihn authored
      This commit addresses issues we had with viewing Task(s) within a Ticket:
      
      1. When viewing the table of all Tasks on a Ticket, the Options dropdown should only allow the Agent to Reopen or Close the Tasks based on the status of the Tasks.
      Ex: If there is only 1 Open Task, you should only see the 'Close' Option
          If there are 2 Closed Tasks, you should only see the 'Reopen' Option
          If there are multiple Tasks in which some are Open and some are Closed, you should see both the 'Reopen' and 'Close' options
      
      2. When viewing an individual Task within a Ticket, the status options were the opposite of what they should have been. Now, if the Task is Open, the Agent will see the option to 'Close' the Task. If the Task is Closded, the Agent will see the option to 'Reopen' the Task.
      85f42422
  8. Jan 02, 2019
    • JediKev's avatar
      issue: Dashboard Export Period · b951032c
      JediKev authored
      This addresses an issue where exporting statistics via the dashboard within
      a certain timeframe (eg. 07/01/2018 -> One Quarter) will always export the
      statistics from the selected date up to today. This is due to the Period
      option always being set to "Up to today" when the Export button is clicked
      which in return exports the stats from the selected start date to today.
      This adds JS to set the period the Agent selects so the Export will return
      the stats from the selected date to the selected period.
      b951032c
  9. Nov 06, 2018
    • JediKev's avatar
      oops: Remove DST From User Update · 10e7c422
      JediKev authored
      This addresses an issue where Users updating their profile will throw an SQL
      error in the system logs. This is due to a line of code trying to set a
      value for the `dst` column which no longer exists as of `1.10.0`.
      10e7c422
  10. Sep 14, 2018
  11. Sep 05, 2018
  12. Aug 29, 2018
  13. Aug 23, 2018
    • JediKev's avatar
      forms: Disabled By Help Topic Users · 0780eb7d
      JediKev authored
      This addresses issue 4470 where Users creating tickets via Client Portal and
      failing to fill out a required field makes disabled fields by Help Topic
      appear on the page. When the disabled fields appear they allow Users to
      populate and save data that they were not meant to submit.
      0780eb7d
  14. Aug 22, 2018
    • JediKev's avatar
      issue: CDATA Phone Contains · e9214c2e
      JediKev authored
      This addresses an issue where people who do not have a phone field on the
      contact information form go to search for a User in the User Directory and
      the system crashes. This is due to the search query that always contains the
      phone field variable. This only adds the phone variable to the search query
      if the field actually exists.
      e9214c2e
    • Peter Rotich's avatar
      Tasks: Task visibility · 44a7f8f6
      Peter Rotich authored
      Allow ticket assignee to see tasks associated with the ticket.
      44a7f8f6
  15. Aug 21, 2018
    • JediKev's avatar
      issue: mPDF SetAutoFont RTL · 3fb04227
      JediKev authored
      This addresses an issue where `SetAutoFont()` was making the Thai PDFs
      break. This adds the `AUTOFONT_RTL` flag to only autodetect RTL languages
      and nothing else.
      3fb04227
    • JediKev's avatar
      issue: SelectionField nset · 2d277075
      JediKev authored
      This addresses an issue where creating an advanced search with selection
      field "does not have a value" throws a fatal error. This was due to an
      improperly named search method "notset".
      2d277075
  16. Aug 20, 2018
    • JediKev's avatar
      cron: Clean Expired Passwd Resets · 70b37d47
      JediKev authored
      This adds functionality to clean expired password reset tokens on cron runs.
      70b37d47
    • JediKev's avatar
      sessions: Clear On Password Set/Reset · 1aaab76f
      JediKev authored
      This adds a Signal to clean Agent and User sessions upon setting/resetting
      their password. If an Agent/User resets their own password and has multiple
      sessions open it will log them out of every session except the one they’re
      on.
      1aaab76f
  17. Aug 19, 2018
    • Peter Rotich's avatar
      Make getFiles() return files · 75b515ad
      Peter Rotich authored
      This commit addresses the root cause of an issue commit 96892beb (now
              reverted) attempted to solve - by providing consistency between
      getFiles and getAttachments
      75b515ad
  18. Aug 16, 2018
    • JediKev's avatar
      issue: mPDF Arabic Fonts · 01c4dda2
      JediKev authored
      This addresses issue 4449 where using an Arabic language pack and trying to
      print a ticket returns a PDF with either squares for text or no text at all.
      01c4dda2
    • JediKev's avatar
      issue: Task Term Search · 90cc65ae
      JediKev authored
      This addresses an issue where searching for a Task by title returns all
      Tasks in the search. This is due to the visibility filtering methods used to
      filter tickets by staff's visibility.
      90cc65ae
    • aydreeihn's avatar
      Relative Time Fixes: · c4ec9a09
      aydreeihn authored
      This commit removes the logic that was used for time within 2 days which would give a result of either today or tomorrow when something could actually be in 2 days instead.
      
      It also rounds relative time that is within 29 days so that the result will be more accurate.
      Ex: 1.99 will round to 2 instead of showing 1
      c4ec9a09
  19. Aug 14, 2018
  20. Aug 13, 2018
    • aydreeihn's avatar
      Task Assigned Team Issue: · 9c457af3
      aydreeihn authored
      This addresses an issue where it appeared as though tasks could not be assigned to teams if an agent in the team was not a part of the task's department. The assigment was actually taking place, however, it was not showing up in the Assignee column. Now the form will correctly display the column
      9c457af3
    • JediKev's avatar
      issue: Old Attachment Names · f179cf15
      JediKev authored
      This addresses an issue where uploading a file you’ve uploaded before but
      renamed is not saving the new name in the Attachment table.
      f179cf15
  21. Aug 08, 2018
    • JediKev's avatar
      issue: Wrong Attachment Names · b0b76170
      JediKev authored
      This addresses an issue where FileUploadFields are displaying the old names
      of existing files with new names.
      b0b76170
  22. Aug 06, 2018
  23. Aug 05, 2018
  24. Aug 03, 2018
    • JediKev's avatar
      issue: Custom File Upload Dropping · 14bcd42d
      JediKev authored
      This addresses issue 4155 where editing a ticket using a different session
      causes custom file uploads to drop from the ticket.
      14bcd42d
  25. Aug 01, 2018
    • JediKev's avatar
      issue: Deleted FieVld Thread Events · 9ab2317e
      JediKev authored
      This addresses an issue where deleting a field and all it's data will
      delete the form field record in the database causing all events containing
      the field to crash the ticket page.
      9ab2317e
    • JediKev's avatar
      issue: Priority Field Template Variable · 2433b8f9
      JediKev authored
      This addresses an issue with PriorityField Template Variables introduced
      with 4359 where the priority variable will appear as "Array" instead of the
      actual value. This adds an `asVar()` function to `class PriorityField` to
      get the appropriate data.
      2433b8f9
  26. Jul 31, 2018
    • JediKev's avatar
      issue: Client Side Thread Entries · e012bea1
      JediKev authored
      This addresses an issue where the client side thread entries are all grouped
      within the same div. This pushes all grouped entries to one side of the page
      making them illegible.
      e012bea1
  27. Jul 30, 2018
    • aydreeihn's avatar
      Web Portal Fixes: · 4decaeca
      aydreeihn authored
      - Add space between column headers and sort arrow
      - Fix sorting by 'Subject' column
      - Fix redactor issues with 'Reset' button
      	- Make sure text within redactor is cleared correctly
      	- Make sure we don't keep attachments if Reset
      - Make sure redactor is reinitialized where needed
      4decaeca
  28. Jul 24, 2018
    • JediKev's avatar
      issue: CLI Deploy Missing Bootstrap Fix · 2dacfde0
      JediKev authored
      This addresses an issue introduced with 4332 where the deploy CLI breaks
      upon deploying to an existing location. This checks to see if there is a
      bootstrap file in the destination first and if so it uses that one if not
      uses the source.
      2dacfde0
    • JediKev's avatar
      issue: Client Side Column Sorting · 1a92dcb1
      JediKev authored
      This addresses an issue where client side column sorting does not work at
      all. This is due to the if/else statement that checks for a REQUEST sort
      order and if the REQUEST sort order matches an `$orderWays` array value. The
      if statement returns TRUE for DESC and sets the sort order to DESC as it
      equals '-' (a dash) but ASC equals '' (an empty string) so it returns FALSE
      which fails-over to the else statement setting the sort order to DESC. In
      addition, this adds sorting icons the the column headers to make it more
      obvious they are sortable.
      1a92dcb1
Loading