Skip to content
Snippets Groups Projects
  1. Apr 16, 2014
  2. Apr 14, 2014
    • Jared Hancock's avatar
      Inline images in email without a 'cid:' indicator · 3c3ffbfa
      Jared Hancock authored
      It is the defacto standard to reference an inline image in an email by
      referencing the Content-ID header of the referenced attachment in the @src
      attribute of the image. For instance, `<imc src="cid:image001.png">` where
      the `cid:` scheme of the attribute indicates that the referenced image URL
      is a separate content of the email. The image attached to the email would
      have an accompanying header like: `Content-Id: <image001.png>`. However,
      some mail systems, including a certain fax to email service, do not
      correctly indicate the location of the image with the content-id URL.
      Instead, the referenced image tag would be `<img src="image001.png">`
      
      This patch addresses the issue by searching the message body for all
      references to attached content-id's in all @src attributes with or without
      the content-id URL scheme indicator. Previously, such images would not be
      displayed inline in the ticket thread.
      
      References:
      https://tools.ietf.org/html/rfc2392
      3c3ffbfa
  3. Apr 11, 2014
  4. Apr 10, 2014
    • Jared Hancock's avatar
      Relax detection of images for strip detection · b707b871
      Jared Hancock authored
      It is perfectectly fine to have an image cited in an HTML body similar to:
      
      <img width=909 height=302 src=cid:image002.jpg@01CF5426.BF5A72A0 alt=image>
      
      Which may or may not have quoted @src attribute, and may very well have an
      at sign (@) somewhere in the attribute text. The previous regular expression
      would not match such a @src attribute.
      b707b871
  5. Apr 09, 2014
  6. Apr 07, 2014
  7. Apr 04, 2014
  8. Apr 03, 2014
  9. Apr 02, 2014
  10. Mar 31, 2014
  11. Mar 13, 2014
  12. Mar 11, 2014
  13. Mar 03, 2014
  14. Feb 28, 2014
  15. Feb 25, 2014
  16. Feb 20, 2014
    • Jared Hancock's avatar
      Place the message-id in the body of the email · f954d69f
      Jared Hancock authored
      This approach will help detect responses to the ticket thread from mail
      clients which do not include the References and In-Reply-To MIME headers.
      This also allows the Subject line to continue to omit the ticket number.
      f954d69f
  17. Jan 31, 2014
  18. Jan 30, 2014
  19. Jan 28, 2014
  20. Jan 27, 2014
  21. Jan 23, 2014
  22. Jan 20, 2014
  23. Jan 18, 2014
    • Jared Hancock's avatar
      Fixup storage of email attachments · 8259ea0f
      Jared Hancock authored
      Fixes the rewriting of the `key` field in the ticket thread body. The
      storage de-duplication system may replace the `key` value with an existing
      one. The ticket thread system will use the `key` value assigned when the
      file is committed to the database or the existing key of the duplicate file.
      
      Also fixup installation issues with the attachment storage plugin
      architecture
      8259ea0f
    • Jared Hancock's avatar
      Migrate file metadata table · d5305279
      Jared Hancock authored
        * Include a `bk` column to store the storage backend
        * Include a `signature` column which represents a repeatable hash of the
          file contents
        * Rename `hash` to `key` since it isn't a real hash
      d5305279
  24. Jan 17, 2014
  25. Jan 16, 2014
Loading