Skip to content
Snippets Groups Projects
  1. Feb 17, 2015
  2. Feb 13, 2015
  3. Feb 11, 2015
    • Jared Hancock's avatar
      oops: Fix truncated random data · ca970b2a
      Jared Hancock authored
      ca970b2a
    • Jared Hancock's avatar
      login: Require CSRF token to login · 504831fe
      Jared Hancock authored
      This patch fixes a vulnerable scenario, where sequential login attempts can
      be made without an existing session, and without a valid CSRF token. This
      scenario lends itself well for brute force password attempts, because
      attackers can avoid using a session and still send requests to determine if
      a set of credentials are valid. This vector also avoids the authentication
      lockout mechanism, because it requires an ongoing session to shutdown the
      requests.
      
      This patch addresses the issue by requiring a session and a valid CSRF token
      generated by the server and placed in the session to be submitted with the
      credentials. Therefore, an existing session and a Cookie header are required
      to process a login attempt. Secondly, the CSRF token will be changed on the
      server after each login processed. Therefore, for each session, a subsequent
      GET request would be necessary before submitting another login attempt.
      504831fe
  4. Feb 06, 2015
  5. Feb 03, 2015
  6. Feb 02, 2015
  7. Jan 30, 2015
  8. Jan 24, 2015
  9. Jan 23, 2015
  10. Jan 14, 2015
    • Jared Hancock's avatar
      Session never expires · ee072130
      Jared Hancock authored
      This patch sends updated session cookies to the browser when the session is
      refreshed on the server. This allows the session cookie to expire on the
      browser at the same time the session timeout occurs at the server. In the
      event the session timeout is configured in osTicket not to expire, the
      cookie will expire after seven days on the client browser, and will expire
      in PHP when it is garbage collected sometime after 86400 seconds after the
      time last refresh time.
      
      Using this method, the session will never expire if the session timeout in
      osTicket is configured to 0, and the session is refreshed at least daily.
      ee072130
  11. Jan 13, 2015
    • Chefkeks's avatar
    • Jared Hancock's avatar
      Fix very predictable random data on some platforms · 2a358417
      Jared Hancock authored
      Misc::randCode does not generate significantly random data for Windows
      platforms with a local database. This stems from the random seed using the
      milliseconds from the current time of day and the database connection time,
      in microseconds. Because Windows has especially poor sub-second time
      resolution via the microtime() function, the seed does not have many
      variations.
      
      This patch addresses the issue by using the included Crypto::random()
      function as a source of random data rather than the mt_rand() function, as
      it uses native cryptographic random data generators if possible to generate
      the data, and uses microtime() as a fallback if no other source of random
      data is available on the platform.
      2a358417
  12. Jan 12, 2015
  13. Jan 09, 2015
  14. Jan 07, 2015
  15. Jan 06, 2015
  16. Jan 05, 2015
  17. Jan 02, 2015
  18. Dec 31, 2014
  19. Dec 30, 2014
    • Peter Rotich's avatar
      http: Use http build query · f0b18dad
      Peter Rotich authored
      Use http::build_query instead of inline urlencode
      f0b18dad
    • Jared Hancock's avatar
      filters: Fix several small, major issues · ada4d9a0
      Jared Hancock authored
        * Fix incorrect mapping to user email address
        * Fix early rejecting of tickets — even if a filter earlier in the
          matching filter list had "stop on match" set
        * Fix ::stopOnMatch referring to incorrect db field
      
      The new logic abandons the early rejection logic in ticket create. Instead,
      the normal validation is completed as usual. Thereafter, the filter is
      initialized and applied to the ticket. Upon rejection, a RejectedException
      is thrown by the ::apply() method of the TicketFilter. The Ticket::create()
      method will handle the exception and reject the ticket.
      ada4d9a0
  20. Dec 28, 2014
  21. Dec 26, 2014
    • Jared Hancock's avatar
      Properly escape text bodies for canned responses · cfa84eab
      Jared Hancock authored
      This patch changes the default formatting for text bodies used in emails,
      ticket thread, and canned response quoting so that white-space in text
      bodies is properly preserved. Previously, the text was treated as raw HTML
      and was not properly escaped, nor was the original whitespace preserved.
      cfa84eab
Loading