Skip to content
Snippets Groups Projects
  1. Oct 30, 2019
    • JediKev's avatar
      issue: Delete Org Session Failure · bbd0c255
      JediKev authored
      This addresses an issue on the Forum where deleting an Organization causes
      the session to fail. This is due to the Organization QuerySet being stored
      in the session and not being cleared out when deleted from the system. This
      causes the system to try to refetch the object from the database which it's
      not there as it's been deleted and therefore causes the session to crash.
      bbd0c255
  2. Aug 15, 2019
    • Peter Rotich's avatar
      Organization Update · 15883448
      Peter Rotich authored
      This commit addresses an issue where updating (editing) organization from
      User's page resulted in ALL settings getting cleared. The change makes sure
      the update is routed to the proper routine.
      15883448
  3. Feb 22, 2019
    • JediKev's avatar
      issue: Custom Column Org Link · aad4c93b
      JediKev authored
      This addresses issue 4579 where setting a Custom Column to User Organization
      and choosing the User Org Link filter the system shows the wrong link to the
      Org. This is due to "scp/" not being added to the URL therefore showing an
      invalid link.
      aad4c93b
  4. Oct 30, 2017
  5. Oct 25, 2017
    • JediKev's avatar
      orgs: Remove Primary Contacts · 3dab629d
      JediKev authored
      This addresses issue 3903 where you cannot remove Primary Contacts from an
      Organization through the UI. This adds functionality to remove
      collaborators from the select box.
      3dab629d
  6. Jan 02, 2017
  7. Mar 18, 2016
    • Jared Hancock's avatar
      orm: Migrate create functionality to the constructor · 1ba40e35
      Jared Hancock authored
      Previously, the create method was used to create a new instance of an orm
      model (which would later result in an INSERT when persisted); however, some
      classes require or utilize varying parameters to their create() method,
      which PHP7 considers an error. Methods in subclasses must be defined with a
      calling signature compatible with the parent class.
      
      This patch shifts the concept of model creation to the constructor. Now, the
      constructor of ORM models is required to be compatible with that of
      ModelBase class. Now that most models do not define a constructor, this is
      much easier to control, and much more logical.
      
      Also, remove an issue where assignments on a relationship field to an
      instance of a super class of the foreign model would raise an error. This
      was previously addressed by re-classing the instance in the
      ModelInstanceManager::getOrBuild(); however that design would create
      multiple instances of the same object in memory, which defeats one of the
      primary design concepts of the ORM. This patch addresses the issue by
      allowing super-classes of the declared foreign model in relationship
      assignments.
      1ba40e35
  8. Mar 17, 2016
  9. Feb 05, 2016
  10. Sep 28, 2015
  11. Sep 26, 2015
    • Jared Hancock's avatar
      orgs: Add ticket sharing feature · f6ccc3f6
      Jared Hancock authored
      This feature allows (by option) an organization to allow its members to see
      tickets from other members. It can be used beside or instead of the
      automated collaboration feature. Now, collaborators retain access to tickets
      on which they participate; however, sharing can be used to enable access to
      other tickets owned by their organization.
      f6ccc3f6
  12. Jul 24, 2015
    • Jared Hancock's avatar
      org: Fix matching of empty domain name · 57c2cb19
      Jared Hancock authored
      If a user is created with an empty domain name (e.g. <user@>), then the user
      would be associated with the first organization without a main domain
      specified.
      
      This patch ensures that the domain is not empty when making a match with an
      organization.
      57c2cb19
  13. Jul 08, 2015
    • Jared Hancock's avatar
      variable: Rework the variable replacement system · 9cc12bdb
      Jared Hancock authored
      getVar() is now called first, then object properties and array properties
      are considered, and then getTag() is considered if none of the other options
      work. This allows for more predictable results using the variable
      replacement system, and allows ::getVar() to override every other means to
      use variables in email templates.
      9cc12bdb
  14. May 22, 2015
  15. May 04, 2015
  16. Apr 30, 2015
  17. Apr 15, 2015
    • Jared Hancock's avatar
      custom-data: Address major confusion · 4efef017
      Jared Hancock authored
      This feature addresses a major issue with the initial implementation of the
      custom data system. The original system confused the usage of
      database-backed field (dynamic-fields) and their corresponding
      implementation. This created the need to crate awkward caching pieces to
      ensure that validation errors and data was maintained. Furthermore, the
      system confused the linking between form instances (dynamic-entry) and the
      form used to represent that entry.
      
      This patch addresses the confusion in two ways:
      
      Dynamic form entries do not link directly to the dynamic form. Instead, the
      ::getForm() method returns something from the forms API directly.
      Furthermore, the ::getFields() method does not return dynamic field
      instances (database backed / designed fields). Instead, the actual
      implementation of the fields from the forms API is retrieved. This allows
      the fields to *always* be cached, which helps preserve data and validation
      state.
      
      Secondly, the dynamic form uses the same system, so that requests to turn a
      dynamic form into a form (via ::getForm) will also result in the same
      behavior, again, where the fields are represented as forms API fields rather
      than the dynamic fields.
      
      So going forward, the dynamic fields are *only* used to create corresponding
      forms API field implementations. The are associated with the dynamic
      counterparts as sparingly as possible.
      4efef017
  18. Apr 10, 2015
  19. Apr 08, 2015
  20. Mar 05, 2015
  21. Feb 18, 2015
  22. Feb 10, 2015
  23. Dec 31, 2014
    • Peter Rotich's avatar
      fixes: Review · 89c0d798
      Peter Rotich authored
      Key permissions definition array
      Move canned and faq permissions to their respective classes.
      89c0d798
  24. Dec 16, 2014
  25. Dec 10, 2014
    • Jared Hancock's avatar
      oops: Bug fixes · 2b422844
      Jared Hancock authored
      Conflicts:
      
      	include/i18n/en_US/form.yaml
      	include/staff/templates/dynamic-field-config.tmpl.php
      	include/staff/ticket-view.inc.php
      	include/staff/tickets.inc.php
      	scp/js/scp.js
      2b422844
  26. Dec 08, 2014
  27. Oct 06, 2014
  28. Aug 29, 2014
  29. Aug 13, 2014
  30. Aug 07, 2014
  31. Jul 30, 2014
Loading