Skip to content
Snippets Groups Projects
  1. Oct 28, 2019
    • JediKev's avatar
      issue: Umlauts In Subject · cccdb152
      JediKev authored
      This addresses an issue where Piping email to osTicket and having Umlauts in
      the Subject line causes the Subject to be malformed. This is due to the
      `mimedecode()` method for class Format which is used by the API to transcode
      the Subject line in emails. This adds a check to see if the
      `mb_detect_encoding()` method exists so we can detect the value's encoding.
      If it exists and we can detect the value's encoding the system will
      transcode the text from the detected encoding to UTF-8. If we cannot detect
      the encoding the text will continue through the other encoding checks.
      cccdb152
  2. Oct 07, 2019
  3. Oct 01, 2019
    • Peter Rotich's avatar
      Datetime Formats · 47098242
      Peter Rotich authored
      This commit addresses two issues related to date / time format.
      
      * 24 hrs format, when selected, is now used system-wide even on thread items
      * PHP-to-JS date / time format translation is now down in the backend
      47098242
  4. Jul 23, 2019
  5. Jul 21, 2019
  6. Jul 10, 2019
    • JediKev's avatar
      issue: Rogue Closing div Breaks HTML Thread Tree · 3bb4c0a1
      JediKev authored
      This addresses an issue reported by Vincent Monier (Xenos) where posting a
      single `</div>` tag as a message or response via the UI will break the HTML
      Thread Tree view. This is due to the `html_balance()` method not cleaning
      empty div tags. This adds `'div'=>1` to the empty tag array so that any
      rogue div tag + any empty div tags are properly removed.
      3bb4c0a1
  7. Mar 29, 2019
    • JediKev's avatar
      oops: Emojis Strip Korean · 6387d820
      JediKev authored
      This addresses an issue where Korean text is stripped from the body. This is
      due to the strip_emoticons function, as Korean text is in the same unicode
      range as some of the emojis.
      6387d820
  8. Mar 26, 2019
    • JediKev's avatar
      issue: Strip Emoticons · f584a26a
      JediKev authored
      This addresses an issue where emoticons/emojis cut off the remainder of the
      email when being added to a ticket thread.
      f584a26a
  9. Feb 05, 2019
    • aydreeihn's avatar
      Final Fixes: · f825c3cc
      aydreeihn authored
      This commit includes several final fixes in general that needed to be made.
      f825c3cc
  10. Oct 31, 2018
    • JediKev's avatar
      issue: create_date Variable · 962b4c66
      JediKev authored
      This addresses an issue where the create_date variable is showing as Unix
      timestamp instead of formatted date. This was due to a typo introduced in
      commit `8623ed60` where the `$format` argument was forgotten for
      `Format::datetime()` in the `FormattedLocalDate::getVar()` method.
      962b4c66
  11. Oct 30, 2018
    • JediKev's avatar
      queue: Top-Level Ticket Counts · dea47d4e
      JediKev authored
      This adds a setting in the Ticket Settings to give the option of showing the
      ticket counts on Top-Level queues. If enabled, this will populate the ticket
      counts next to the Top-Level queue names like they used to be. The only
      caveat is the counts are triggered by mousing-over any of the queue names as
      we only load the counts when we need to display the sub-queues (for better
      performance).
      
      This also adds a new format function called `number` (Phase 1). As of now it
      will format any integer to a comma separated number (eg. `1337 -> 1,337`).
      dea47d4e
  12. Sep 10, 2018
    • Peter Rotich's avatar
      DatetimeField: Format · 8623ed60
      Peter Rotich authored
      This commit adds the ability for DatetimeField to specify format string -
      this is useful when the field display requires specific format different
      from the system defined formats. For example during export.
      8623ed60
  13. Aug 23, 2018
    • JediKev's avatar
      issue: Image CID Attributes · 9fab35a5
      JediKev authored
      This addresses an issue where images in email signatures containing a
      `data-cid` attribute will either crash the ticket page or not show the image
      in the signature.
      9fab35a5
  14. Aug 16, 2018
    • aydreeihn's avatar
      Relative Time Fixes: · c4ec9a09
      aydreeihn authored
      This commit removes the logic that was used for time within 2 days which would give a result of either today or tomorrow when something could actually be in 2 days instead.
      
      It also rounds relative time that is within 29 days so that the result will be more accurate.
      Ex: 1.99 will round to 2 instead of showing 1
      c4ec9a09
  15. Jul 17, 2018
    • JediKev's avatar
      security: Fix Multiple XSS Vulnerabilies · 4b8ee133
      JediKev authored
      It may be possible to steal or manipulate customer session and cookies,
      which might be used to impersonate a legitimate user, allowing the hacker to
      view or alter user records, and to perform transactions as that user.
      Sanitation of hazardous characters was not performed correctly on user
      input.
      
      osTicket did not properly sanitize array values in `Format::htmlchars()`.
      Some values in the Admin Interface were not properly sanitized and returned
      to the response.
      4b8ee133
  16. Jul 13, 2018
    • JediKev's avatar
      security: Fix Multiple XSS Vulnerabilies · a3d896c8
      JediKev authored
      It may be possible to steal or manipulate customer session and cookies,
      which might be used to impersonate a legitimate user, allowing the hacker to
      view or alter user records, and to perform transactions as that user.
      Sanitation of hazardous characters was not performed correctly on user
      input.
      
      osTicket did not properly sanitize array values in `Format::htmlchars()`.
      Some values in the Admin Interface were not properly sanitized and returned
      to the response.
      a3d896c8
  17. May 15, 2018
    • Peter Rotich's avatar
      Lint: Lint fixes · 914b6e64
      Peter Rotich authored
      914b6e64
    • JediKev's avatar
      format: Fix Vimeo iFrames · ae9a9cc9
      JediKev authored
      This addresses an issue where some Vimeo videos are not being sent in
      Agent’s responses. This adds `player.vimeo` to the sanitize method’s
      iframe section so that the iframe tag is not stripped.
      ae9a9cc9
    • JediKev's avatar
      issue: Outlook _MailEndCompose · faea6346
      JediKev authored
      This addresses an issue where Outlook adds weird (and seemingly random)
      _MailEndCompose tags to the email body which turns unwanted content into
      links. This adds the _MailEndCompose tag to Format::sanitize() so it
      will be removed from the email body.
      faea6346
  18. Apr 23, 2018
    • JediKev's avatar
      issue: Drop Gmail "ltr" Attributes · 6ddfd8b7
      JediKev authored
      This addresses an issue where the New Activity Notice Template was not
      keeping the CSS styling for the %{message} variable. This was due to Gmail
      adding `<div dir="ltr">` tags around some text in the body causing the CSS
      styling to break. This adds RegEx to the formatter so we can remove the
      `<div dir="ltr">` tags from the email body before the New Activity Notice
      Template is sent preserving the CSS styling.
      6ddfd8b7
  19. Mar 26, 2018
    • JediKev's avatar
      issue: Outlook _MailEndCompose · fad881ed
      JediKev authored
      This addresses an issue where Outlook adds weird (and seemingly random)
      _MailEndCompose tags to the email body which turns unwanted content into
      links. This adds the _MailEndCompose tag to Format::sanitize() so it
      will be removed from the email body.
      fad881ed
  20. Mar 22, 2018
    • Peter Rotich's avatar
      Make FAQ & Pages Attachments Viewable · cefe6848
      Peter Rotich authored
      Commit c4579277 introduced an extra administrative security feature to
      restrict files access to signed in users only, even  if a user has a valid
      & signed download URL. The feature, however, did not take into account
      public images & files associated with FAQs and pages such as
      landing/thank-you pages.
      
      This commit addresses the shortcoming by adding a reference ID (attachment ID)
      to the download/access URL, that can be used to deduce the model/object type
      that the file request is associated with. The technique will allow us in the
      future to enforce ACL at the file level depending on privacy settings and
      the security clearance of the user (agent).
      cefe6848
  21. Feb 28, 2018
    • JediKev's avatar
      format: Fix Vimeo iFrames · cc06c052
      JediKev authored
      This addresses an issue where some Vimeo videos are not being sent in
      Agent’s responses. This adds `player.vimeo` to the sanitize method’s
      iframe section so that the iframe tag is not stripped.
      cc06c052
  22. Feb 26, 2018
  23. Sep 13, 2017
    • JediKev's avatar
      format: Add Fullscreen to Embedded Videos · 5ef19a5c
      JediKev authored
      This addresses an issue where there is no fullscreen option for embedded
      videos. This adds the allowfullscreen parameter to the formatter for
      iframe tags.
      5ef19a5c
  24. Aug 22, 2017
    • JediKev's avatar
      format: Mailto TLD Length · 1a261690
      JediKev authored
      This addresses an issue where the text formatter only allows 2-4
      characters in email domain TLDs. This causes an issue if you have a TLD
      with more than 4 characters, where the full email address will not be
      converted into the link. This increases the allowed characters to 2-63
      characters allowing all modern TLDs to be converted correctly. Why 63
      chars? Have a look at the 2.3.4 Size Limts section here:
      http://www.ietf.org/rfc/rfc1035.txt
      
      Example (using user@domain.testing):
      Before
      <a href="mailto:user@domain.test">user@domain.test</a>ing
      After
      <a href="mailto:user@domain.testing">user@domain.testing</a>
      1a261690
  25. Jun 28, 2017
    • JediKev's avatar
      pages: Translate Special Characters · 2928f162
      JediKev authored
      This addresses issue #3842 where special characters in a Page name causes a
      403 or 404 error. This adds a method to convert the special characters to
      html entities and then removes the entity suffixes leaving only
      un-accented characters behind. (e.g. 'ã' => '&atilde;' => 'a')
      2928f162
  26. Apr 24, 2017
    • Peter Rotich's avatar
      DateTime · 69b85f0d
      Peter Rotich authored
      Address edge cases where timezone mixups happens on DateTimeField
      
      Allow datetime field to be timezone agnostic (not timezone aware) to display
      the timezone used to set the field. The timezone of the last user or agent
      that edited the field is used.
      69b85f0d
  27. Jun 20, 2016
    • Jared Hancock's avatar
      html: Fix processing of some <html> tags in email · 18414cd7
      Jared Hancock authored
      thanks @robintoy, @talilon
      
      This patch removes any contents of an html element when scrubbing html
      markup. Some markup includes complex namespaces and other information which
      does not concern the html processing of osTicket. It also messes up the
      htmLawed processing of the htmLawed.
      
      Maybe fixes #2465
      Maybe fixes #2272
      18414cd7
  28. Mar 17, 2016
  29. Feb 26, 2016
  30. Jan 13, 2016
  31. Jan 07, 2016
  32. Aug 04, 2015
    • Jared Hancock's avatar
      thread: Add flags for COLLABORATOR and BALANCED · d2bdc312
      Jared Hancock authored
      And two flags, one which signals that stored HTML is correctly balanced and
      does not need to be balanced when rendered in the ticket view. The second is
      used to signal messages received from collaborators.
      
      Additionally, this patch fixes showing external inline images (via the [Show
      Images] button) when clicked.
      d2bdc312
  33. Jul 21, 2015
  34. Jul 08, 2015
  35. Jun 24, 2015
    • Jared Hancock's avatar
      oops: Fix several small issues · a0e84ddf
      Jared Hancock authored
      * Fix warning for negative unix timestamps in Misc::db2gmtime
      * Fix crash because of parser context passed to getXxx functions
      * Fix inability to update email address
      a0e84ddf
Loading