Skip to content
Snippets Groups Projects
  1. May 22, 2019
    • JediKev's avatar
      issue: Retained Deleted ListItem Errors · a3297a25
      JediKev authored
      This addresses an issue where New Tickets will fail for Users with a deleted
      ListItem retained in their Contact Information form. This is due to the
      system deleting the `list_id` for the ListItem so when we run
      `getFilterData()` for the User we can't find the list which causes a fatal
      error later down the line. This adds an OR statement to the
      `SelectionField::getFilterData()` method to skip said ListItems if no
      `list_id` is present.
      a3297a25
  2. May 10, 2019
  3. May 09, 2019
  4. Apr 29, 2019
    • JediKev's avatar
      oops: .eml/.msg Missing Not Operator · ce8aadf8
      JediKev authored
      This addresses a typo where we are missing a not operator in class
      MailFetcher when checking for no `$body` in the fetched attachments. This
      adds the not operator so that the `if()` statement is properly executed and
      we correctly set a fake body when there is none.
      ce8aadf8
  5. Apr 25, 2019
    • JediKev's avatar
      cli: Package No File Permissions · 25e6c6e9
      JediKev authored
      This addresses an issue where the `package` cli module is leaving out the
      permissions on files. This causes the final ZIP archive to contain files
      without permissions meaning the files are un-usable until you restore
      permissions. This can make life difficult on people trying to install
      osTicket with minimal knowledge as they wouldn’t know what is wrong.
      
      This is due to the `setExternalAttributesName` method not shifting 16 bits
      on the file "mode" which will not translate to binary. The file "mode" is
      the inode protection mode for a file returned by the `stat()` method. It is
      essentially a decimal representation of a file's permissions. Since "mode"
      is in decimal format we need to shift by 16 bits to translate it to binary
      so the archiver understands. Once the mode is translated to binary the
      permissions are preserved.
      25e6c6e9
    • aydreeihn's avatar
      Lint Fixes · 8c878db6
      aydreeihn authored
      This commit gets rid of PHP warnings. Additionally, it updates the lint tests to be more accurate.
      8c878db6
  6. Apr 24, 2019
  7. Apr 23, 2019
  8. Apr 17, 2019
    • JediKev's avatar
      issue: .eml/.msg Attachments · 4098a2bf
      JediKev authored
      This addresses an issue where `.eml` and `.msg` files on incoming mails are
      being dropped. This is due the the mail fetcher that tries to process
      `.eml`/`.msg` files and adds them as thread entries rather than adding them
      as attachments. This adds a new section that utilizes a new method to fetch
      the body of `.eml`/`.msg` files, fetches the subjects of the `.eml`/`.msg`
      files as the attachment names, and creates attachments. This preserves the
      `.eml` and `.msg` files and adds them to the pertinent thread entries as
      attachments.
      4098a2bf
  9. Apr 16, 2019
  10. Apr 15, 2019
  11. Apr 11, 2019
    • JediKev's avatar
      issue: iFrame Single Quotes · ae5ced39
      JediKev authored
      It's all about the single quotes baby! Apparently I can't read; the single
      quotes are only meant for word options such as `'self'` and `'none'`. When
      adding single quotes to the `<host-source>` options it takes them
      literally…too literally. For example, if your options are `'localhost:80
      localhost:8080 localhost:8000'` then `'localhost:80` and `localhost:8000'`
      will be seen as "invalid" due to the single quotes. This removes the single
      quotes from every line that sets the CSP so all options are valid. This also
      adds single quotes around the `self` option so it stays valid as well.
      ae5ced39
  12. Apr 10, 2019
  13. Apr 05, 2019
    • aydreeihn's avatar
      FAQ Issues · ce3d69ae
      aydreeihn authored
      This commit fixes several issues with how we manage FAQs and related objects.
      
      1. When trying to add a Help Topic to an FAQ, we should add the record to the faq_topic table after saving the faq so that we can accurately retrieve the faq_id
      
      2. When deleting a Help Topic, we need to make sure we're using the topic->delete function rather than deleting based on a QuerySet so that the related FAQ Topics will also be deleted.
      
      3. When deleting a FAQ Category, we need to ensure that we delete all related FAQs and FAQ Topics. To do this, we should use the delete function from the FAQ class first to delete all related FAQs and FAQ Topics and then we should use the Category delete function to delete the remaining Category (remove faqs->expunge from the category->delete function since it we now pass through faq->delete as well)
      ce3d69ae
  14. Apr 04, 2019
    • JediKev's avatar
      issue: sendAccessLink On NULL · 6f9f2e17
      JediKev authored
      This addresses an issue where entering a collaborator's email to send ticket
      email access link throws a fatal error. This is due to the method that
      checks for tickets with the User's email equal to the email provided. This
      only checks for User's emails not Collaborator emails. This adds a check for
      Collaborator emails as well so this will not crash out.
      6f9f2e17
  15. Apr 01, 2019
  16. Mar 29, 2019
    • JediKev's avatar
      issue: iFrame On Install · e7a7e3b0
      JediKev authored
      This addresses the "Call to getAllowIframes() on NULL" error on installation
      pages. This is due to 4781 that introduced the concept of allowing multiple
      iFrames, where we are not checking for `$cfg` before calling the method.
      This adds a check for `$cfg` so the errors do not occur.
      e7a7e3b0
    • Peter Rotich's avatar
      Merge pull request #4823 from JediKev/oops/emoji-strips-korean · 4a0e1bc3
      Peter Rotich authored
      oops: Emojis Strip Korean
    • JediKev's avatar
      oops: Emojis Strip Korean · 6387d820
      JediKev authored
      This addresses an issue where Korean text is stripped from the body. This is
      due to the strip_emoticons function, as Korean text is in the same unicode
      range as some of the emojis.
      6387d820
  17. Mar 27, 2019
  18. Mar 26, 2019
  19. Mar 21, 2019
  20. Mar 18, 2019
    • JediKev's avatar
      issue: Organizations Users Sort · 1214c753
      JediKev authored
      This addresses issue 4803 where sorting by Users on Organizations does not
      sort properly. It sorts by name instead of the User count. This corrects the
      value in the `$sortOptions` array from `users` to `user_count`.
      1214c753
    • Hans Chen's avatar
      fix bug · 17c7e1d1
      Hans Chen authored
      not sending new ticket alert to account manager.
  21. Mar 12, 2019
  22. Mar 11, 2019
    • JediKev's avatar
      issue: Duplicate Form Titles · 5bae5159
      JediKev authored
      This addresses an issue mentioned in the forum where having more than one
      custom field on a ticket shows the same title for all forms on the
      client-side ticket view (after creation). This adds an array of the form
      names indexed by sort order and displays them in the correct order with the
      correct names.
      5bae5159
    • JediKev's avatar
      iframe: Allow Multiple iFrame Domains · 4f7c4dcb
      JediKev authored
      Previously, we added a security header to prevent click-jacking called
      "X-Frame-Options". This introduced an issue with people using osTicket in
      iFrames on their websites. To mitigate the issue, this updates the security
      header to allow the site to be framed from specified domains, if none
      provided we default to 'self'. This adds a new field to General System
      Settings called "Allow iFrames" where you may enter a comma separated list
      of domains that the site can be framed on. This also adds a validator for
      the field to validate the domains and ensure they fit the <host-source>
      syntax from [Mozilla Developer
      Docs](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-ancestors#Sources).
      4f7c4dcb
  23. Mar 06, 2019
Loading