Skip to content
Snippets Groups Projects
  1. Oct 09, 2013
    • Jared Hancock's avatar
      Dynamic data for osTicket · 9e75169e
      Jared Hancock authored
      *This is a major redesign / rework of the osTicket base*
      
      This patch drops the concept of static ticket metadata and allows for an
      admin-configurable arbitrary data that is attachable to tickets
      
      The system is architected such that the base osTicket install now comes with
      a "default" form that has fields for subject, name, email, and phone number.
      This form is editable to allow for the addition of arbitrary other fields;
      however, the basic fields must remain in order to be associated with a
      help-topic and attached to a ticket.
      
      This concept can be expanded to allow for arbitrary data associated with
      registered clients or ticket thread items.
      
      Forms are comprised of sections. Sections have a title and instructions
      properties and a list of fields. Fields have various implementations to
      represent different data such as text, long answer, phone number, datetime,
      yes/no, and selections, and are configurable to define the look and feel and
      interpretation of the respective form field.
      
      Dropdown lists are represented as "Dynamic Lists", which are
      admin-configurable lists of items. Dropdowns can be optionally represented
      as Bootstrap typeahead fields.
      
      This also adds the start of a simple ORM which will hopefully be expanded in
      the future to support multiple database platforms. Currently, only MySQL is
      implemented.
      9e75169e
    • Jared Hancock's avatar
      Don't handle text email messages like HTML · 431a1612
      Jared Hancock authored
      This patch changes the behavior of the mailer to support a 'text' option to
      hint if the message is a text-only message. If so, no HTML processing will
      be performed on the message and a text-only email (with no inline
      attachments) will be emitted and sent.
      431a1612
    • Jared Hancock's avatar
      Enable attachments by default · 484d2ef1
      Jared Hancock authored
      484d2ef1
    • Jared Hancock's avatar
      Fix upgrade from 1.8 develop branch · 956b8c80
      Jared Hancock authored
      956b8c80
    • Jared Hancock's avatar
      efe859a1
    • Jared Hancock's avatar
      Fix attachment data on new install · 2832eb9f
      Jared Hancock authored
      2832eb9f
    • Jared Hancock's avatar
      16426dd2
    • Jared Hancock's avatar
      Revise initial email templates · 92072970
      Jared Hancock authored
      Ticket notice and ticket auto-reply should not be formatted inside a table
      since the %{message} or %{response} should be allowed to flow freely in the
      email rather than be crammed inside the table.
      92072970
    • Jared Hancock's avatar
      Fix non-local images on client interface · e1f6a4ce
      Jared Hancock authored
      e1f6a4ce
    • Jared Hancock's avatar
      Changes made after feature review · 9478ccb8
      Jared Hancock authored
      9478ccb8
    • Jared Hancock's avatar
      HTML ticket thread, inline images and draft support · 864d3539
      Jared Hancock authored
      Process inline attachments in thread entry and support inline images in
      piped emails
      
      Support inline images across the system, with draft support
      
      Migrate to a single attachment table
          That way we don't need a new table for everything we need to attach an
          inline image to (like a signature, for instance)
      
      Add richtext support for internal notes
      
      Implement images on site pages
      
      * Image paste in Redactor
      * Make non-local images optional
      * Placeholder for non-local images
      * Fix local image download hover
      * Don't re-attach inline images
      864d3539
  2. Oct 07, 2013
  3. Oct 06, 2013
    • Jared Hancock's avatar
      Crazy performance penalty scanning blob tables · 60fcf00c
      Jared Hancock authored
      When scanning the file_chunk table for orphaned file chunks that can be
      deleted, apparently, MySQL will read (at least part of) the blob data from
      the disk. For databases with lots of large attachments, this can take
      considerable time. Considering that it is triggered from the autocron and
      will run everytime the cron is run, the database will spend considerable
      time scanning for rows to be cleaned.
      
      This patch changes the orphan cleanup into two phases. The first will search
      just for the pk's of file chunks to be deleted. If any are found, then the
      chunks are deleted by the file_id and chunk_id, which is the primary key of
      the table.
      
      The SELECT query seems to run at least 20 times faster than the delete
      statement, and DELETEing against the primary key of the blob table should
      be the fastest possible operation. Somehow, both queries required a full
      table scan; however, because the SELECT statement is explictly only
      interested in two fields, it is more clear to the query optimizer that the
      blob data should not be scanned.
      
      References:
      http://stackoverflow.com/q/9511476
      60fcf00c
  4. Oct 04, 2013
  5. Sep 30, 2013
  6. Sep 29, 2013
  7. Sep 27, 2013
  8. Sep 26, 2013
    • Jared Hancock's avatar
      Disable Kerberos and NTLM auth for mail fetch · 8b0085dd
      Jared Hancock authored
      On some configurations of PHP and remote mail servers, Kerberos and NTLM
      challenge response authentication could be possibly attempted. This is
      essentially futile and potentially fatal for osTicket mail fetching, as the
      system is currently designed for username and password authentication only.
      
      This patch disables challenge and response authentication for PHP versions
      5.3.2 and newer, which support the fix.
      
      This patch also consistently encodes mailbox names according to the rfc 2060
      for IMAP.
      8b0085dd
  9. Sep 24, 2013
  10. Sep 23, 2013
    • Jared Hancock's avatar
      Detect attachments with Content-Type: ...; name= · be02c8d4
      Jared Hancock authored
      RFC2045, section 5.1 seems to indicate that arbitrary parameters can be
      appended to a Content-Type header specification. Some email clients seem to
      use the Content-Type header to specify an attachment without giving a
      separate Content-Disposition header normally used to signify attachments.
      
      This patch corrects attachment detection for piped emails to detect such
      emails. The patch also correctly decodes filenames specified either in the
      Content-Disposition or Content-Type headers using RFC5987, where the
      filename can be encoded using an arbitrary character set (ie, not us-ascii).
      be02c8d4
    • Jared Hancock's avatar
      Fix 1.6-* upgrade to 1.7.1 · c3349266
      Jared Hancock authored
      8e72e521 (v1.7.1.2+) introduced a bug where
      osTicket version 1.6 would not send a cookie (by calling PHP
      session_start()) for the login page. Therefore, after unpacking the 1.7.1
      source code, an upgrade would not be possible, because a login would never
      be processed correctly.
      c3349266
  11. Sep 20, 2013
  12. Sep 18, 2013
  13. Sep 13, 2013
    • Jared Hancock's avatar
      Avoid double-encoding thread titles · bd680889
      Jared Hancock authored
      This is safe now, because the title is appropriately encoded in
      class.thread.php/ThreadEntry::create()
      
      Fixes #567, #718
      bd680889
    • Jared Hancock's avatar
      Fixes cookie domain specification · eecd0b1a
      Jared Hancock authored
      if the domain given in HTTP_HOST variable happens to have a port
      specification. Technically, the port specification should not be included in
      the domain spec given in the cookie.
      
      (And for the record, that makes no sense to me, seeing as a cookie would
      otherwise be valid for all servers on any ports at a particular domain).
      eecd0b1a
  14. Sep 12, 2013
    • Jared Hancock's avatar
      Fix up ROOT_PATH, yet again · c8197915
      Jared Hancock authored
      The previous implementation did not work correctly for symlinked folders.
      The new approach uses debug_backtrace() and ROOT_DIR to determine the
      difference between ROOT_DIR and the osTicket installation path.
      
      This thing is like a turd that won't flush
      c8197915
  15. Sep 11, 2013
Loading