Skip to content
Snippets Groups Projects
  1. Apr 29, 2015
  2. Apr 21, 2015
  3. Apr 15, 2015
    • Peter Rotich's avatar
      Merge pull request #1941 from greezybacon/feature/dynamic-forms-1.1 · 3278541f
      Peter Rotich authored
      
      Feature :: Dynamic Forms 1.1 — address major confusion and magic issues
      
      Reviewed-By: default avatarPeter Rotich <peter@osticket.com>
      3278541f
    • Jared Hancock's avatar
      ca614b96
    • Jared Hancock's avatar
      custom-data: Address major confusion · 4efef017
      Jared Hancock authored
      This feature addresses a major issue with the initial implementation of the
      custom data system. The original system confused the usage of
      database-backed field (dynamic-fields) and their corresponding
      implementation. This created the need to crate awkward caching pieces to
      ensure that validation errors and data was maintained. Furthermore, the
      system confused the linking between form instances (dynamic-entry) and the
      form used to represent that entry.
      
      This patch addresses the confusion in two ways:
      
      Dynamic form entries do not link directly to the dynamic form. Instead, the
      ::getForm() method returns something from the forms API directly.
      Furthermore, the ::getFields() method does not return dynamic field
      instances (database backed / designed fields). Instead, the actual
      implementation of the fields from the forms API is retrieved. This allows
      the fields to *always* be cached, which helps preserve data and validation
      state.
      
      Secondly, the dynamic form uses the same system, so that requests to turn a
      dynamic form into a form (via ::getForm) will also result in the same
      behavior, again, where the fields are represented as forms API fields rather
      than the dynamic fields.
      
      So going forward, the dynamic fields are *only* used to create corresponding
      forms API field implementations. The are associated with the dynamic
      counterparts as sparingly as possible.
      4efef017
  4. Apr 13, 2015
  5. Apr 11, 2015
  6. Apr 10, 2015
  7. Apr 09, 2015
  8. Apr 08, 2015
  9. Apr 07, 2015
  10. Apr 06, 2015
    • Jared Hancock's avatar
      oops: Fix bad HTML entity · 06d3a0f3
      Jared Hancock authored
      06d3a0f3
    • Jared Hancock's avatar
      forms: Don't update CDATA when updating old fields · d739b980
      Jared Hancock authored
      If an update to an object such as a ticket results in a corresponding update
      to the CDATA table, and one or more of the fields have been deleted from the
      ticket details form, then, avoid updating the CDATA table for those fields.
      
      This fixes an issue where the CDATA table is dropped and recreated when
      fields are added and removed from the form. The table will only contain
      fields which are currently on the form when the table is created. Therefore,
      deleted fields will never be on the CDATA table and will result in an SQL
      error.
      d739b980
  11. Apr 02, 2015
  12. Apr 01, 2015
Loading