Skip to content
Snippets Groups Projects
  1. Apr 15, 2015
    • Jared Hancock's avatar
      custom-data: Address major confusion · 4efef017
      Jared Hancock authored
      This feature addresses a major issue with the initial implementation of the
      custom data system. The original system confused the usage of
      database-backed field (dynamic-fields) and their corresponding
      implementation. This created the need to crate awkward caching pieces to
      ensure that validation errors and data was maintained. Furthermore, the
      system confused the linking between form instances (dynamic-entry) and the
      form used to represent that entry.
      
      This patch addresses the confusion in two ways:
      
      Dynamic form entries do not link directly to the dynamic form. Instead, the
      ::getForm() method returns something from the forms API directly.
      Furthermore, the ::getFields() method does not return dynamic field
      instances (database backed / designed fields). Instead, the actual
      implementation of the fields from the forms API is retrieved. This allows
      the fields to *always* be cached, which helps preserve data and validation
      state.
      
      Secondly, the dynamic form uses the same system, so that requests to turn a
      dynamic form into a form (via ::getForm) will also result in the same
      behavior, again, where the fields are represented as forms API fields rather
      than the dynamic fields.
      
      So going forward, the dynamic fields are *only* used to create corresponding
      forms API field implementations. The are associated with the dynamic
      counterparts as sparingly as possible.
      4efef017
  2. Mar 05, 2015
  3. Feb 18, 2015
  4. Feb 10, 2015
  5. Dec 31, 2014
    • Peter Rotich's avatar
      fixes: Review · 89c0d798
      Peter Rotich authored
      Key permissions definition array
      Move canned and faq permissions to their respective classes.
      89c0d798
  6. Dec 16, 2014
  7. Dec 10, 2014
    • Jared Hancock's avatar
      oops: Bug fixes · 2b422844
      Jared Hancock authored
      Conflicts:
      
      	include/i18n/en_US/form.yaml
      	include/staff/templates/dynamic-field-config.tmpl.php
      	include/staff/ticket-view.inc.php
      	include/staff/tickets.inc.php
      	scp/js/scp.js
      2b422844
  8. Dec 08, 2014
  9. Oct 06, 2014
  10. Aug 29, 2014
  11. Aug 13, 2014
  12. Aug 07, 2014
  13. Jul 30, 2014
  14. Jul 02, 2014
  15. Jun 27, 2014
  16. Jun 16, 2014
  17. Jun 11, 2014
  18. May 28, 2014
  19. May 08, 2014
  20. Apr 25, 2014
  21. Apr 14, 2014
  22. Apr 11, 2014
  23. Apr 02, 2014
  24. Apr 01, 2014
  25. Mar 31, 2014
Loading