- Mar 18, 2016
-
-
Jared Hancock authored
Previously, the create method was used to create a new instance of an orm model (which would later result in an INSERT when persisted); however, some classes require or utilize varying parameters to their create() method, which PHP7 considers an error. Methods in subclasses must be defined with a calling signature compatible with the parent class. This patch shifts the concept of model creation to the constructor. Now, the constructor of ORM models is required to be compatible with that of ModelBase class. Now that most models do not define a constructor, this is much easier to control, and much more logical. Also, remove an issue where assignments on a relationship field to an instance of a super class of the foreign model would raise an error. This was previously addressed by re-classing the instance in the ModelInstanceManager::getOrBuild(); however that design would create multiple instances of the same object in memory, which defeats one of the primary design concepts of the ORM. This patch addresses the issue by allowing super-classes of the declared foreign model in relationship assignments.
-
Jared Hancock authored
This commit attempts to remove all coding standard warnings emitted by PHP 7.0.
-
- Feb 06, 2016
-
-
jdelhome3578 authored
-
jdelhome3578 authored
-
- Feb 05, 2016
-
-
Jared Hancock authored
-
Jared Hancock authored
This changes the storage model for datetime fields and stores them in the same format as the MySQL `datetime` column type. This allows for the searching code to be consistent when searching the database for datetime custom form entry data.
-
Peter Rotich authored
-
Peter Rotich authored
-
Peter Rotich authored
-
Peter Rotich authored
Change orgs listing to ORM Add cdata tables support for users and organizations
-
- Jan 26, 2016
-
-
Peter Rotich authored
osTicket supports filtering allowable files on the client-side via JS as well as server-side on upload. Ajax based upload skipped server-side validation with the assumption that the client already validated the file upload. For most cases this is a valid assumption (ajax only works if JS is enabled) but fails to account for cases where HTTP requests is intercepted and changed on transit or the request is posted directly to the ajax interface. This commit forces server-side file upload validation.
-
- Jan 21, 2016
-
-
Peter Rotich authored
-
- Jan 20, 2016
-
-
Peter Rotich authored
-
- Jan 13, 2016
-
-
Peter Rotich authored
Catch InconsistentModelException on config load to allow for fallback to old config table when upgrade is pending.
-
Peter Rotich authored
-
- Jan 12, 2016
-
-
- Jan 07, 2016
-
-
Peter Rotich authored
This is commit reverts prior commit to prevent email loops by dead-banning alerts and auto-responses based on recent communication with the end user.
-
Peter Rotich authored
-
Peter Rotich authored
-
Peter Rotich authored
-
Peter Rotich authored
-
Peter Rotich authored
-
Peter Rotich authored
Cast email adddress to string
-
Peter Rotich authored
Require subject and message go send mail filter action
-
Peter Rotich authored
-
Peter Rotich authored
-
- Jan 05, 2016
-
-
Peter Rotich authored
-
Peter Rotich authored
-
Peter Rotich authored
Dept::getMembersForAlerts can return an empty array instead of query-set
-
- Jan 04, 2016
-
-
Jared Hancock authored
And, add to the collabs preview popup too
-
Jared Hancock authored
-
- Dec 31, 2015
-
-
Peter Rotich authored
-
Jared Hancock authored
-
Peter Rotich authored
-
Peter Rotich authored
Auto-assign to closing staff or the last respondent if the agent is available and has access. Otherwise, put the ticket back to unassigned pool.
-
Peter Rotich authored
Column based sorting got removed in favor of drop down based sorting in commit number fa327c. It's being returned due to negative feedback we received from users.
-
Peter Rotich authored
Make tasks actions icon based buttons Fix task assignment issue
-
Jared Hancock authored
This changes the typeahead to redirect directly from the typeahead click rather than redirecting after performing the search a second time on the ticket queue page.
-
Peter Rotich authored
Use CsvImporter util to importing items Fix items search
-
Peter Rotich authored
-