Skip to content
Snippets Groups Projects
  1. Mar 18, 2016
    • Jared Hancock's avatar
      orm: Migrate create functionality to the constructor · 1ba40e35
      Jared Hancock authored
      Previously, the create method was used to create a new instance of an orm
      model (which would later result in an INSERT when persisted); however, some
      classes require or utilize varying parameters to their create() method,
      which PHP7 considers an error. Methods in subclasses must be defined with a
      calling signature compatible with the parent class.
      
      This patch shifts the concept of model creation to the constructor. Now, the
      constructor of ORM models is required to be compatible with that of
      ModelBase class. Now that most models do not define a constructor, this is
      much easier to control, and much more logical.
      
      Also, remove an issue where assignments on a relationship field to an
      instance of a super class of the foreign model would raise an error. This
      was previously addressed by re-classing the instance in the
      ModelInstanceManager::getOrBuild(); however that design would create
      multiple instances of the same object in memory, which defeats one of the
      primary design concepts of the ORM. This patch addresses the issue by
      allowing super-classes of the declared foreign model in relationship
      assignments.
      1ba40e35
    • Jared Hancock's avatar
      php: Support PHP 7, require at least 5.4 · 9616a61d
      Jared Hancock authored
      This commit attempts to remove all coding standard warnings emitted by PHP
      7.0.
      9616a61d
  2. Feb 06, 2016
  3. Feb 05, 2016
  4. Jan 26, 2016
    • Peter Rotich's avatar
      Always force server-side attachments validation · fdad9239
      Peter Rotich authored
      osTicket supports filtering allowable files on the client-side via JS as
      well as server-side on upload.
      
      Ajax based upload skipped server-side validation with the assumption that
      the client already validated the file upload. For most cases this is a valid
      assumption (ajax only works if JS is enabled) but fails to account for cases
      where HTTP requests is intercepted and changed on transit or the request is
      posted directly to the ajax interface.
      
      This commit forces server-side file upload validation.
      fdad9239
  5. Jan 21, 2016
  6. Jan 20, 2016
  7. Jan 13, 2016
  8. Jan 12, 2016
  9. Jan 07, 2016
  10. Jan 05, 2016
  11. Jan 04, 2016
  12. Dec 31, 2015
Loading