Skip to content
Snippets Groups Projects
  1. Apr 24, 2016
  2. Mar 24, 2016
  3. Sep 26, 2015
  4. Aug 18, 2015
  5. May 13, 2015
  6. Apr 15, 2015
    • Jared Hancock's avatar
      custom-data: Address major confusion · 4efef017
      Jared Hancock authored
      This feature addresses a major issue with the initial implementation of the
      custom data system. The original system confused the usage of
      database-backed field (dynamic-fields) and their corresponding
      implementation. This created the need to crate awkward caching pieces to
      ensure that validation errors and data was maintained. Furthermore, the
      system confused the linking between form instances (dynamic-entry) and the
      form used to represent that entry.
      
      This patch addresses the confusion in two ways:
      
      Dynamic form entries do not link directly to the dynamic form. Instead, the
      ::getForm() method returns something from the forms API directly.
      Furthermore, the ::getFields() method does not return dynamic field
      instances (database backed / designed fields). Instead, the actual
      implementation of the fields from the forms API is retrieved. This allows
      the fields to *always* be cached, which helps preserve data and validation
      state.
      
      Secondly, the dynamic form uses the same system, so that requests to turn a
      dynamic form into a form (via ::getForm) will also result in the same
      behavior, again, where the fields are represented as forms API fields rather
      than the dynamic fields.
      
      So going forward, the dynamic fields are *only* used to create corresponding
      forms API field implementations. The are associated with the dynamic
      counterparts as sparingly as possible.
      4efef017
  7. Mar 03, 2015
  8. Jan 12, 2015
  9. Jan 02, 2015
  10. Dec 08, 2014
  11. Oct 02, 2014
  12. Sep 29, 2014
    • Jared Hancock's avatar
      forms: Revisit several small issues for "info" field · e9dfba9c
      Jared Hancock authored
        * Use the title of "Information" with internal tag of "info"
        * Add "Visibility" column to UI and retire "Required" and "Internal"
          columns
        * Add visibility selection to new fields and show visibility to the user
          information fields when displayed on the ticket details form
        * Make the visibility settings translatable
        * Use constants internally for visibility configuration detection
        * Use a larger input when managing the information HTML content
        * Fix validation errors for new fields
          * Enforce new field name uniqueness
          * Enforce new field name character validation
      e9dfba9c
  13. Sep 26, 2014
  14. Aug 29, 2014
  15. Aug 26, 2014
  16. Aug 05, 2014
  17. Jul 15, 2014
  18. Jul 14, 2014
  19. Jul 08, 2014
  20. Jun 30, 2014
  21. Jun 04, 2014
  22. May 20, 2014
  23. May 16, 2014
  24. Apr 22, 2014
  25. Apr 01, 2014
  26. Jan 08, 2014
    • Jared Hancock's avatar
      Fix possible serious errors in dynamic form fields · 7e7c4cf0
      Jared Hancock authored
      Fix dropping of materialized view when variable name is changed
      
      Ensure view exists before merging updates
      
      Prevent possible sql injection error in field name used in the materialized
      view.
      
      Prevent possible xss error in the display of the field label and variable
      name in the admin panel.
      7e7c4cf0
  27. Dec 11, 2013
  28. Nov 27, 2013
  29. Nov 25, 2013
  30. Nov 22, 2013
  31. Nov 16, 2013
  32. Nov 12, 2013
Loading