Skip to content
Snippets Groups Projects
  1. Apr 19, 2016
  2. Apr 14, 2016
  3. Apr 13, 2016
    • Jared Hancock's avatar
      orm: Don't null out value on assignment · 93a34c43
      Jared Hancock authored
      This fixes an issue where the PK of ThreadEntry will be NULLed in the
      following code
      
      ```php
      $entry = ThreadEntry::create(array(...));
      $entry->save();
      $entry->email_info = new ThreadEntryEmailInfo(array(
          'mid' => 'xyzAbc',
      ));
      ```
      
      In the above code, the $entry->__set('email_info', <ThreadEntryEmailInfo>)
      would be invoked. The ThreadEntryEmailInfo object is new, and so will cause
      the local part of the relationship (`id` in this case) to
      become null further down in the `__set` method.
      
      This issue is fixed in this commit by removing the NULL assignment to the
      new object. This was added in 11322766,
      however, it is unclear why the null assignment is performed.
      93a34c43
    • Jared Hancock's avatar
      files: Attempt to standardize thread entry attaching · 00a1371d
      Jared Hancock authored
      This commit attempts to remove some of the confusing and redundant code to
      attach files to thread entries and replace it with a single code base. It
      also attempts to remove and error where a single attachment might be
      attached to a new thread entry multiple times.
      
      Lastly, it removes the insert followed by an update for emails with inline
      images. This should improve performance processing emails as only one trip
      to the database is now necessary for thread entries with inline images.
      00a1371d
  4. Mar 30, 2016
  5. Mar 29, 2016
  6. Mar 28, 2016
  7. Mar 26, 2016
  8. Mar 25, 2016
  9. Mar 24, 2016
  10. Mar 20, 2016
    • Jared Hancock's avatar
      login: Make the backdrop customizable · 463de2e9
      Jared Hancock authored
      This duplicates the custom logo code to allow for custom login backdrops. A
      new page is added to the "Company" settings page which allows for management
      of the uploaded custom backdrops.
      463de2e9
  11. Mar 19, 2016
  12. Mar 18, 2016
    • Jared Hancock's avatar
      orm: Add TTL to APCu cache stores · 57b109dc
      Jared Hancock authored
      57b109dc
    • Jared Hancock's avatar
      orm: Use faster newInstance method, cache ModelMeta · 5c0ac68e
      Jared Hancock authored
      Use APCu, if available, to cache the compiled model meta data.
      5c0ac68e
    • Jared Hancock's avatar
      orm: Migrate create functionality to the constructor · 1ba40e35
      Jared Hancock authored
      Previously, the create method was used to create a new instance of an orm
      model (which would later result in an INSERT when persisted); however, some
      classes require or utilize varying parameters to their create() method,
      which PHP7 considers an error. Methods in subclasses must be defined with a
      calling signature compatible with the parent class.
      
      This patch shifts the concept of model creation to the constructor. Now, the
      constructor of ORM models is required to be compatible with that of
      ModelBase class. Now that most models do not define a constructor, this is
      much easier to control, and much more logical.
      
      Also, remove an issue where assignments on a relationship field to an
      instance of a super class of the foreign model would raise an error. This
      was previously addressed by re-classing the instance in the
      ModelInstanceManager::getOrBuild(); however that design would create
      multiple instances of the same object in memory, which defeats one of the
      primary design concepts of the ORM. This patch addresses the issue by
      allowing super-classes of the declared foreign model in relationship
      assignments.
      1ba40e35
    • Jared Hancock's avatar
      php: Support PHP 7, require at least 5.4 · 9616a61d
      Jared Hancock authored
      This commit attempts to remove all coding standard warnings emitted by PHP
      7.0.
      9616a61d
  13. Mar 17, 2016
  14. Mar 16, 2016
    • Jared Hancock's avatar
      alerts: Do not include the manager with the members · 28c8ada8
      Jared Hancock authored
      This fixes an issue, where the department manager cannot be excluded from
      the new ticket alert if the members of the department are checked.
      Considering there is a separate selection for the manager, this patch
      adjusts the system so the manager of the department only receives the new
      ticket alert if the manager checkbox is set. Otherwise, only the members of
      the department other than the manager receive the alert.
      28c8ada8
  15. Mar 07, 2016
  16. Mar 04, 2016
    • Peter Rotich's avatar
      datepicker: Use consistent date format · fbcd756c
      Peter Rotich authored
      To avoid date format ambiguity the datepicker replaces entered date with a
      standard 'ISO 8601' date format on form submission. The system however fails
      to use datepicker's format on post-back, resulting in invalid date on
      subsequent submit.
      
      This pull request addresses the issue by making sure reflected date uses the
      format datepicker expects.
      fbcd756c
    • Peter Rotich's avatar
      reports: Convert user time to database time · ae422bb7
      Peter Rotich authored
      'strtotime' uses local timezone without taking into consideration the user's
      timezone. This pull requests simply makes sure user's entered timeframe
      range is converted to db time before it's used in a query.
      ae422bb7
Loading