Skip to content
Snippets Groups Projects
  1. Jul 17, 2018
    • JediKev's avatar
      department: Error Feedback · 9f3b6b27
      JediKev authored
      This addresses an issue where osTicket did not ensure associated items exist
      before saving to the database. This also addresses an issue where the Parent
      Topic error was not displayed on page.
      9f3b6b27
    • JediKev's avatar
      security: Fix Multiple XSS Vulnerabilies · 4b8ee133
      JediKev authored
      It may be possible to steal or manipulate customer session and cookies,
      which might be used to impersonate a legitimate user, allowing the hacker to
      view or alter user records, and to perform transactions as that user.
      Sanitation of hazardous characters was not performed correctly on user
      input.
      
      osTicket did not properly sanitize array values in `Format::htmlchars()`.
      Some values in the Admin Interface were not properly sanitized and returned
      to the response.
      4b8ee133
    • JediKev's avatar
      issue: Auto-Assignment Log · d4262cef
      JediKev authored
      This addresses an issue on the Forums where the Auto-Assignment Thread
      Event (configurable via Help Topic) uses the Email of the User rather than
      the User’s Name. This adds the correct function to retrieve the User’s
      Name if the User has an Account.
      d4262cef
    • JediKev's avatar
      issue: Ticket Lock On Disable · 606f45ba
      JediKev authored
      This addresses an issue where disabling Ticket Locks but setting a time
      for the Lock Timeout will always throw a "lock required" error. This adds
      a check to see if locks are enabled AND there is a time set. If locks are
      disabled it will not throw the error.
      606f45ba
    • JediKev's avatar
      issue: User Import No Email · b65185ba
      JediKev authored
      This addresses issue 4329 where you can import a User with no email
      address via CSV file. Once the User is added and you try to update them
      with an email address it fails due to no default email. This updates the
      check for email address from `!isset()` to `empty()` which will correctly
      check for empty string.
      b65185ba
    • JediKev's avatar
      issue: CLI Deploy Missing Bootstrap · ee208fca
      JediKev authored
      This addresses issue 4322 where deploying via CLI is missing
      `bootstrap.php`. This is due to the `get_include_dir()` function that
      tries to include a file from the destination which doesn’t exist yet,
      causing a fatal error. This updates the function to use `$this->source`
      instead of `$this->destination` to correctly find and include
      `bootstrap.php`.
      ee208fca
    • JediKev's avatar
      issue: Language Pack Locale Mismatch · 132d838f
      JediKev authored
      This addresses issue 4325 where the Language Pack Locales are mismatched.
      The Locale for the first language is displayed on the second language,
      etc. This updates the `$manifest` variable to be set before we display
      data so the correct `MANIFEST` file is included and all language data is
      displayed correctly.
      132d838f
  2. Jun 11, 2018
  3. May 15, 2018
  4. May 09, 2018
    • JediKev's avatar
      issue: Information Page Performance · dfa0f3f0
      JediKev authored
      This addresses an issue on the forums where the query to determine the
      size of the `file_chunk` table is making the page load really slow for
      people with large tables. This updates the query to improve the
      performance of the page load time.
      dfa0f3f0
  5. May 03, 2018
    • JediKev's avatar
      issue: Prevent Click Jacking · bb5564d4
      JediKev authored
      This addresses a vulnerability where there was no `X-Frame-Options` header
      which could potentially allow click jacking. This adds the
      `X-Frame-Options: SAMEORIGIN` header so it will remove any chance of click
      jacking. According to Mozilla Developer Docs:
      ```
      SAMEORIGIN
      The page can only be displayed in a frame on the same origin as the page
      itself.
      ```
      bb5564d4
  6. Apr 25, 2018
    • Peter Rotich's avatar
      Merge pull request #4253 from JediKev/issue/files-deleteOrphans · 24dbd3b3
      Peter Rotich authored
      issue: Files - deleteOrphans()
      24dbd3b3
    • JediKev's avatar
      issue: Files - deleteOrphans() · a3e04e82
      JediKev authored
      This addresses the issue where files were being deleted before being sent
      out in Agent responses. This was due to a bug in the query that gets the
      orphaned files. This query was getting files created within the last 24
      hours not after the last 24 hours. The query also had another bug that
      would use the time from PHP instead of MySQL which could cause issues.
      This updates the query as per @greezybacon's suggestions to delete
      orphaned files that were created more than 24 hours ago.
      a3e04e82
  7. Apr 19, 2018
    • Jared Hancock's avatar
      queryset: Fix circular reference error · 0f9cab06
      Jared Hancock authored
      This fixes an error where the ModelInstanceManager maintained a reference to
      the QuerySet instance, and the QuerySet instance managed a reference to the
      ModelInstanceManager instance (if it's the iterator for the query). Because
      of the circular reference, if the iterator is not exhausted, then the
      resource is not closed and the query remains open. This wastes memory and
      prevents some other queries from running after such a situation happens.
      
      This addresses the issue by removing the circular reference between the
      QuerySet and the ModelInstanceManager.
      0f9cab06
  8. Apr 10, 2018
Loading