Skip to content
Snippets Groups Projects
  1. Jun 25, 2016
  2. Jun 12, 2016
  3. Jun 08, 2016
  4. Jun 06, 2016
  5. May 27, 2016
  6. May 12, 2016
  7. Apr 28, 2016
  8. Apr 26, 2016
  9. Apr 25, 2016
  10. Apr 24, 2016
  11. Apr 19, 2016
    • Jared Hancock's avatar
    • Jared Hancock's avatar
      orm: Propagate LEFT joins in join paths · 6be61133
      Jared Hancock authored
      If something like members__staff is considered leaving the Team model,
      and the `members` relationship is nullable, and the `staff` relationship is
      not, in the context of the compiled SQL statement, the second join should
      also be considered nullable (LEFT join), because otherwise inconsistent
      results would be returned from the query.
      
      In other words, if a count is considered as an annotation to the Team model
      instances, Teams with zero members should still be considered as valid teams
      and should be selected with such an annotation. Before this patch, however,
      the join between TeamMember and Staff would have been an inner join instead
      of a LEFT join, which could skew the database results.
      6be61133
    • Jared Hancock's avatar
      oops: Fix max of a single attachment · d1a9161f
      Jared Hancock authored
      d1a9161f
    • Jared Hancock's avatar
      forms: Fix lag updating the CDATA table · 33455cae
      Jared Hancock authored
      This fixes an issue where the CDATA table is updated with the OLD version of
      an answer after it is updated. That is, after an answer is updated, the
      CDATA table is also updated to reflect the change; however, the old content
      of the answer value is used when updating the CDATA value.
      33455cae
  12. Apr 14, 2016
  13. Apr 13, 2016
    • Jared Hancock's avatar
      orm: Don't null out value on assignment · 93a34c43
      Jared Hancock authored
      This fixes an issue where the PK of ThreadEntry will be NULLed in the
      following code
      
      ```php
      $entry = ThreadEntry::create(array(...));
      $entry->save();
      $entry->email_info = new ThreadEntryEmailInfo(array(
          'mid' => 'xyzAbc',
      ));
      ```
      
      In the above code, the $entry->__set('email_info', <ThreadEntryEmailInfo>)
      would be invoked. The ThreadEntryEmailInfo object is new, and so will cause
      the local part of the relationship (`id` in this case) to
      become null further down in the `__set` method.
      
      This issue is fixed in this commit by removing the NULL assignment to the
      new object. This was added in 11322766,
      however, it is unclear why the null assignment is performed.
      93a34c43
    • Jared Hancock's avatar
      files: Attempt to standardize thread entry attaching · 00a1371d
      Jared Hancock authored
      This commit attempts to remove some of the confusing and redundant code to
      attach files to thread entries and replace it with a single code base. It
      also attempts to remove and error where a single attachment might be
      attached to a new thread entry multiple times.
      
      Lastly, it removes the insert followed by an update for emails with inline
      images. This should improve performance processing emails as only one trip
      to the database is now necessary for thread entries with inline images.
      00a1371d
  14. Apr 08, 2016
  15. Apr 07, 2016
    • Peter Rotich's avatar
      closed-by: Credit the agent opening a ticket · 8598e999
      Peter Rotich authored
      This PR addresses a bug where an agent-opened ticket doesn't set closed by
      or mistakenly set it to auto-assigned agent when a status of closed state is
      selected.
      
      * Always credit the agent opening the ticket with close credit on closure
      * Only do ticket auto-assignment IF the resulting status is in open state
      8598e999
  16. Apr 01, 2016
  17. Mar 30, 2016
  18. Mar 29, 2016
    • Jared Hancock's avatar
      8d94c736
    • Jared Hancock's avatar
      orm: Partially revert 8ab4432f · eb0ba316
      Jared Hancock authored
      This partially reverts a change in the ORM changing the QuerySet::all()
      method to return an Iterator rather than an array. I spent a while proposing
      a patch to replace usage of all() with iterations; however, I cannot propose
      a valid reason to abandon the previous methodology.
      
      This reintroduces the previous behavior: calling all() will yield an array
      of results from the QuerySet's iteration system.
      eb0ba316
Loading