Skip to content
Snippets Groups Projects
  1. Aug 16, 2018
    • aydreeihn's avatar
      Relative Time Fixes: · c4ec9a09
      aydreeihn authored
      This commit removes the logic that was used for time within 2 days which would give a result of either today or tomorrow when something could actually be in 2 days instead.
      
      It also rounds relative time that is within 29 days so that the result will be more accurate.
      Ex: 1.99 will round to 2 instead of showing 1
      c4ec9a09
  2. Jul 17, 2018
    • JediKev's avatar
      security: Fix Multiple XSS Vulnerabilies · 4b8ee133
      JediKev authored
      It may be possible to steal or manipulate customer session and cookies,
      which might be used to impersonate a legitimate user, allowing the hacker to
      view or alter user records, and to perform transactions as that user.
      Sanitation of hazardous characters was not performed correctly on user
      input.
      
      osTicket did not properly sanitize array values in `Format::htmlchars()`.
      Some values in the Admin Interface were not properly sanitized and returned
      to the response.
      4b8ee133
  3. Jul 13, 2018
    • JediKev's avatar
      security: Fix Multiple XSS Vulnerabilies · a3d896c8
      JediKev authored
      It may be possible to steal or manipulate customer session and cookies,
      which might be used to impersonate a legitimate user, allowing the hacker to
      view or alter user records, and to perform transactions as that user.
      Sanitation of hazardous characters was not performed correctly on user
      input.
      
      osTicket did not properly sanitize array values in `Format::htmlchars()`.
      Some values in the Admin Interface were not properly sanitized and returned
      to the response.
      a3d896c8
  4. May 15, 2018
    • Peter Rotich's avatar
      Lint: Lint fixes · 914b6e64
      Peter Rotich authored
      914b6e64
    • JediKev's avatar
      format: Fix Vimeo iFrames · ae9a9cc9
      JediKev authored
      This addresses an issue where some Vimeo videos are not being sent in
      Agent’s responses. This adds `player.vimeo` to the sanitize method’s
      iframe section so that the iframe tag is not stripped.
      ae9a9cc9
    • JediKev's avatar
      issue: Outlook _MailEndCompose · faea6346
      JediKev authored
      This addresses an issue where Outlook adds weird (and seemingly random)
      _MailEndCompose tags to the email body which turns unwanted content into
      links. This adds the _MailEndCompose tag to Format::sanitize() so it
      will be removed from the email body.
      faea6346
  5. Mar 26, 2018
    • JediKev's avatar
      issue: Outlook _MailEndCompose · fad881ed
      JediKev authored
      This addresses an issue where Outlook adds weird (and seemingly random)
      _MailEndCompose tags to the email body which turns unwanted content into
      links. This adds the _MailEndCompose tag to Format::sanitize() so it
      will be removed from the email body.
      fad881ed
  6. Feb 28, 2018
    • JediKev's avatar
      format: Fix Vimeo iFrames · cc06c052
      JediKev authored
      This addresses an issue where some Vimeo videos are not being sent in
      Agent’s responses. This adds `player.vimeo` to the sanitize method’s
      iframe section so that the iframe tag is not stripped.
      cc06c052
  7. Apr 24, 2017
    • Peter Rotich's avatar
      DateTime · 69b85f0d
      Peter Rotich authored
      Address edge cases where timezone mixups happens on DateTimeField
      
      Allow datetime field to be timezone agnostic (not timezone aware) to display
      the timezone used to set the field. The timezone of the last user or agent
      that edited the field is used.
      69b85f0d
  8. Jun 20, 2016
    • Jared Hancock's avatar
      html: Fix processing of some <html> tags in email · 18414cd7
      Jared Hancock authored
      thanks @robintoy, @talilon
      
      This patch removes any contents of an html element when scrubbing html
      markup. Some markup includes complex namespaces and other information which
      does not concern the html processing of osTicket. It also messes up the
      htmLawed processing of the htmLawed.
      
      Maybe fixes #2465
      Maybe fixes #2272
      18414cd7
  9. Mar 17, 2016
  10. Feb 26, 2016
  11. Jan 13, 2016
  12. Jan 07, 2016
  13. Aug 04, 2015
    • Jared Hancock's avatar
      thread: Add flags for COLLABORATOR and BALANCED · d2bdc312
      Jared Hancock authored
      And two flags, one which signals that stored HTML is correctly balanced and
      does not need to be balanced when rendered in the ticket view. The second is
      used to signal messages received from collaborators.
      
      Additionally, this patch fixes showing external inline images (via the [Show
      Images] button) when clicked.
      d2bdc312
  14. Jul 21, 2015
  15. Jul 08, 2015
  16. Jun 24, 2015
  17. Jun 08, 2015
    • Jared Hancock's avatar
      html: Balancing is important · 6c359046
      Jared Hancock authored
      9ae01bf2 turned off HTML balancing, however,
      quoted response removal will create unbalanced HTML. That HTML will be
      stored unbalanced and will require extra processing when displayed on the
      ticket thread.
      
      This patch adds balancing support using libxml if enabled, which will
      balance HTML without corrupting the HTML like htmLawed will with balancing
      enabled.
      6c359046
  18. Jun 03, 2015
    • Jared Hancock's avatar
      Make several optimizations to ticket-view page · 091fe701
      Jared Hancock authored
      * Log events for AJAX collaborator list edits
      * Avoid extra selects for inline image handling
      * Avoid using htmLawed to add target="_blank" and class="no-pjax" to links
        in the ticket thread
      * Cache instances of IntlDateFormatter; seems expensive to set up
      * Cache filetypes Yaml in APC if available
      * Cache I18n::getDefaltLanguage() in the request
      * Avoid extraneous usage of Model::_inspect and Model::$meta
      * Add aggregated query support to the ORM
      * Lazily compile SQL query for InstrumentedLists
      * Apply `select_related` setting when setting up InstrumentedList instances
      * Slight optimization in SqlCompiler::getField
      * Avoid double compiling Sql annotations in the ORDER BY clause
      * Cache Thread::getEntries
      * Break out event types for ThreadEvent for more legible code
      * Eliminate one query from Ticket::loadDynamicData
      * Fix ticket number bolding if already answered
      * Use dependent subqueries for ticket statistics in the queue page, which is
        significantly faster for large data sets (like hundreds of attachments or
        thread entries)
      * Fixup sidebar layout on client knowledge base pages
      091fe701
  19. May 21, 2015
  20. May 15, 2015
  21. May 14, 2015
  22. May 13, 2015
  23. May 04, 2015
  24. Apr 30, 2015
  25. Apr 15, 2015
    • Jared Hancock's avatar
      mailer: Embed the Message-Id token in @class · 06a9b903
      Jared Hancock authored
      Several mail clients do not return the Message-ID header in a In-Reply-To or
      References header as they should. The assumption by such mail clients is
      that the email be threaded based on the Subject header. However, osTicket
      does not require the ticket number to be placed in the Subject header and so
      has trouble threading email from such systems. osTicket embeds a copy of the
      Message-ID header (or compatible version) in the body of the message in
      hopes part of the message will be returned.
      
      Many mail clients (such as osTicket) strip and clean the HTML when
      processing HTML email. Previously, the message-id token was embedded in a
      @data-mid attribute, which was likely stripped before the HTML email would
      be returned back to osTicket.
      
      This patch suggests that the token be placed in a @class attribute, which
      has a much better chance of returning to osTicket.
      06a9b903
  26. Apr 14, 2015
    • Jared Hancock's avatar
      Fix image CID rewrite for some pasted images · cd538a8f
      Jared Hancock authored
      Copy+Pasting images from a ticket thread or from a FAQ article to the HTML
      editor and submitting will result in the URL *not* being properly rewritten
      for storage in the database. When images are uploaded, a relative URL is
      returned from the server and embedded in the HTML editor. However, when
      images from the system are copy and pasted into the editor, an absolute URL
      with the http:// scheme is included. This URL was not properly handled by
      the URL rewriter in Format::localizeInlineImages().
      
      This patch addresses the issue by properly handling both relative URLs from
      image uploads and absolute URLs from copy and pasting.
      cd538a8f
  27. Mar 23, 2015
  28. Mar 10, 2015
  29. Feb 10, 2015
  30. Jan 30, 2015
Loading