Skip to content
Snippets Groups Projects
  1. Mar 18, 2016
    • Jared Hancock's avatar
      orm: Migrate create functionality to the constructor · 1ba40e35
      Jared Hancock authored
      Previously, the create method was used to create a new instance of an orm
      model (which would later result in an INSERT when persisted); however, some
      classes require or utilize varying parameters to their create() method,
      which PHP7 considers an error. Methods in subclasses must be defined with a
      calling signature compatible with the parent class.
      
      This patch shifts the concept of model creation to the constructor. Now, the
      constructor of ORM models is required to be compatible with that of
      ModelBase class. Now that most models do not define a constructor, this is
      much easier to control, and much more logical.
      
      Also, remove an issue where assignments on a relationship field to an
      instance of a super class of the foreign model would raise an error. This
      was previously addressed by re-classing the instance in the
      ModelInstanceManager::getOrBuild(); however that design would create
      multiple instances of the same object in memory, which defeats one of the
      primary design concepts of the ORM. This patch addresses the issue by
      allowing super-classes of the declared foreign model in relationship
      assignments.
      1ba40e35
  2. Jul 21, 2015
  3. May 27, 2015
    • Jared Hancock's avatar
      Fix numerous issues with attachments · bdc4d127
      Jared Hancock authored
      * Fix attachments not sticking on new dynamic form entry
      * Fix attachments not sticking on thread post validation error
      * Fix missing inline images in FAQ article viewing
      * Fix missing inline images in FAQ article printing
      * Fix crash rendering sidebar in staff faq view with attachments
      * Rewrite GenericAttachments to be an ORM object
      * Port CannedResponse to ORM
      * Fix attachments not being displayed when editing a FAQ article
      * Fix squirly empty blue box on faq articles with no attachments
      bdc4d127
  4. May 13, 2015
  5. Apr 15, 2015
  6. Feb 27, 2015
    • Jared Hancock's avatar
      draft: Find the draft corresponding to your user id · 12922b3c
      Jared Hancock authored
      Previously, any draft would be identified — even if it isn't owned by the
      current user. Then, when the draft would attempt to be updated, the update
      would be refused and the annoying draft saved popup would appear.
      12922b3c
  7. Feb 10, 2015
  8. Jan 30, 2015
  9. Dec 31, 2014
    • Jared Hancock's avatar
      files: Provide unified download script · d9cf38bc
      Jared Hancock authored
      This script adds a single download script, 'file.php', which provides access
      to files of all types to all users. It uses a HMAC signature system with an
      expires time, which allows signed URLs to be sent to external users.
      
      This also fixes an issue with the Http::cacheable() method, where the
      last-modified and Etag headers were not properly compared, which resulted in
      permanent cache misses by the client.
      d9cf38bc
  10. Dec 08, 2014
  11. Oct 06, 2014
  12. May 22, 2014
  13. Nov 08, 2013
  14. Oct 09, 2013
    • Jared Hancock's avatar
      Changes made after feature review · 9478ccb8
      Jared Hancock authored
      9478ccb8
    • Jared Hancock's avatar
      HTML ticket thread, inline images and draft support · 864d3539
      Jared Hancock authored
      Process inline attachments in thread entry and support inline images in
      piped emails
      
      Support inline images across the system, with draft support
      
      Migrate to a single attachment table
          That way we don't need a new table for everything we need to attach an
          inline image to (like a signature, for instance)
      
      Add richtext support for internal notes
      
      Implement images on site pages
      
      * Image paste in Redactor
      * Make non-local images optional
      * Placeholder for non-local images
      * Fix local image download hover
      * Don't re-attach inline images
      864d3539
Loading