The solution is simple: upload the image, create the draft automatically,
attach the image to the draft, return the draft_id to the client. That's it.
There's no more need to create the draft in advance now.

Instead, only show the box if the draft has been modified since initially
created / updated.

Drafts now are placed directly into the HTML response. The response contains
the draft information as well as the original content saved in the database
for the content being modified. The draft itself is placed into the redactor
box rather than the current content.

This patch also reduces some of the [Draft Saved] notices where there is no
content or the content has not yet been modified.

i18n: Add a few forgotten strings

Reviewed-By: Peter Rotich <peter@osticket.com>

bug: Check to make sure $ost is initialized

Reviewed-By: Jared Hancock <jared@osticket.com>

After testing 1.9.4 I noticed that these strings are not yet included in the translation. So this is the (hopefully correct) pull request to add them ;)

Fix subject display when a ChoiceField is used

Reviewed-By: Peter Rotich <peter@osticket.com>

There was a slight issue when transitioning from a short answer field to a
drop-down field, and when the CDATA table is dropped and rebuilt.

forms: Fix interpretation of custom list data

Reviewed-By: Peter Rotich <peter@osticket.com>

Rollback to auto commit, except for sequence  iteration

Reviewed-By: Peter Rotich <peter@osticket.com>

Prior to osTicket v1.9.4, drop down lists only allowed for a single entry.
After upgrading to 1.9.4 the database data for drop downs changed to allow
for multiple entries. However, the old data format was not properly handled
by the SelectionField::to_php() method which handled interpreting and
upgrading the database data.

Keeping the transaction active for the entire request increases the
likelihood of a deadlock on Galera clusters.

search: Escape non-word chars for search queries

Reviewed-By: Peter Rotich <peter@osticket.com>

oops: Always strip embedded images unless

Reviewed-By: Peter Rotich <peter@osticket.com>

Default max file size

Reviewed-By: Jared Hancock <jared@osticket.com>

InnoDB tables for search indexing where possible

Reviewed-By: Peter Rotich <peter@osticket.com>

Especially on Galera clusters, search indexing with MyISAM tables will cause
unstable clusters and loss of data. For standalone clusters using MySQL 5.6
or MariaDB 10.0, the database default table storage engine can be used,
since either support fulltext indexing.

Determine and set a reasonable max file size on install
Remove file extension restrictions - transition to mime types

files: Cleanup orphaned files on autocron

Reviewed-By: Peter Rotich <peter@osticket.com>