It seems that most systems handle the newline character alone without a
problem; however, some systems cannot handle the standard CRLF line ending
at all.

Fixed typo

Because CSV has no way of indicating a content character set, writing the
file with a Unicode byte-order mark is useful to declare the content in
UTF-8 encoding.

When sending alerts to agents, consider the setting of the new message alert
configuration.

This will help when saving rules with trailing spaces for instance, which
may make things not match when visually the administrator would otherwise
expect the filter to match.

Fixes #1834

For a yet unknown reason, the association between the field implementations
and the DynamicFormEntry object is not maintained from calls to
DynamicFormEntry::getFields().

This patch addresses the issue by always associating the "form" when
returning from ::getFields()

Preserve the fields indexed keys
Only sort the fields once, after adding missing fields

Reset field content when building a new form

See: http://osticket.com/forum/discussion/85083/osticket-sends-no-html-mails#latest

Looked at crowdin and the term "Add Organization" is already used in the following context:
#: include/staff/templates/org-lookup.tmpl.php:82

So my suggestion is to use it also for this context here, which would not require a new translation ;)

Michael

Fixes #1809

Get all dynamic fields in DynamicFormEntry, not just fields with answers

This partially reverts commit bff191b6.
The hasSpecialSearch() method can be retired in `develop-next` — NOT in the
`develop` branch

If the system receives an email by a collaborator which has not yet been
added to the ticket (a friend of a friend — that is, a collaborator forwards
an email to a third-party), a header is added to the thread body something
like:

Received From: afriendofafriend@mycompany.tld

However, if the thread body is text and the HTML ticket thread is enabled,
then the text formatting hint will be lost and the body will be assumed as
HTML deeper inside the thread entry creation process. Therefore, the
whitespace inside the resulting thread entry will be collapsed.

This patch addresses the issue by maintaining the original format hint with
the thread body.

Allow the staff banner to be set to empty (which is the default).

Also display the update errors back on the dialog for failed updated.

Fixes #1736 - tickets now have their overdue status cleared when it is closed. It uses the inbuilt clearOverdue method to ensure it is done properly, rather than setting isoverdue=0