Skip to content
Snippets Groups Projects

refactor: separate service into smaller services OP#242

Description

[Provide a description of the changes in this merge request. What was the problem you were trying to solve? How did you solve it?]

Related issues

https://plan.vereign.com/work_packages/242

#99

Testing

This MR refactors core services in smaller parts. It's just rearranging all functional into separate files. So, all functional should work as expected

Checklist

  • I have updated the documentation (if necessary)
  • I have added unit tests for new functionality (if applicable)
  • My code follows the style guidelines of this project
  • I have tested this code on my local machine before submitting this MR

Reviewers

@zdravko.iliev @boyan.tsolov

Edited by Alexey Lunin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Please check your setup, seems like a few files need prettier to be run on them:

    connection.service credential.service dids.service jsonld.service oob.service proofs.service askar.module agent.utils.ts

    Also I think it will be a good idea to group all services into a services dir.

  • Alexey Lunin added 2 commits

    added 2 commits

    • 433865e9 - op#242 apply prettier
    • 7737dcb7 - OP#242 Group all askar services under one folder

    Compare with previous version

  • @zdravko.iliev Thanks for review. I've fixed issues. And also updated prettier configs at my IDE, it was disabled. Can you check again?

  • Alexey Lunin mentioned in merge request !82 (merged)

    mentioned in merge request !82 (merged)

  • Zdravko Iliev approved this merge request

    approved this merge request

  • Zdravko Iliev resolved all threads

    resolved all threads

  • removed Need review label

  • added Reviewed label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading