Skip to content

fix: make dto properties consistent OP#246

Alexey Lunin requested to merge 246-dto-swagger-fix into main

Description

https://plan.vereign.com/projects/vbd/work_packages/246 Current: DTO state is kinda ok, but Matthias had some comments, that when he create a swagger file from our swagger json it does have inconsistencies, like not returning mandatory fields.

Desired: We should check what are the exact problems and fix them.

Related issues

https://plan.vereign.com/projects/vbd/work_packages/246

Testing

The issue was only with field:

in the result type of issue_credential (and fetch_credentials) the attribute credentialRecordType is mandatory but always UNSET

I removed this property

As soon as I touched almost all DTOs, just to check that App works in general

Checklist

  • I have updated the documentation (if necessary)
  • I have added unit tests for new functionality (if applicable)
  • My code follows the style guidelines of this project
  • I have tested this code on my local machine before submitting this MR

Reviewers

@zdravko.iliev @boyan.tsolov

Edited by Alexey Lunin

Merge request reports