Skip to content
Snippets Groups Projects
  1. May 14, 2015
  2. May 13, 2015
  3. May 05, 2015
  4. Apr 30, 2015
  5. Apr 15, 2015
    • Jared Hancock's avatar
      custom-data: Address major confusion · 4efef017
      Jared Hancock authored
      This feature addresses a major issue with the initial implementation of the
      custom data system. The original system confused the usage of
      database-backed field (dynamic-fields) and their corresponding
      implementation. This created the need to crate awkward caching pieces to
      ensure that validation errors and data was maintained. Furthermore, the
      system confused the linking between form instances (dynamic-entry) and the
      form used to represent that entry.
      
      This patch addresses the confusion in two ways:
      
      Dynamic form entries do not link directly to the dynamic form. Instead, the
      ::getForm() method returns something from the forms API directly.
      Furthermore, the ::getFields() method does not return dynamic field
      instances (database backed / designed fields). Instead, the actual
      implementation of the fields from the forms API is retrieved. This allows
      the fields to *always* be cached, which helps preserve data and validation
      state.
      
      Secondly, the dynamic form uses the same system, so that requests to turn a
      dynamic form into a form (via ::getForm) will also result in the same
      behavior, again, where the fields are represented as forms API fields rather
      than the dynamic fields.
      
      So going forward, the dynamic fields are *only* used to create corresponding
      forms API field implementations. The are associated with the dynamic
      counterparts as sparingly as possible.
      4efef017
  6. Apr 09, 2015
  7. Mar 23, 2015
  8. Mar 18, 2015
  9. Mar 05, 2015
  10. Mar 03, 2015
  11. Feb 27, 2015
  12. Feb 26, 2015
  13. Feb 17, 2015
  14. Feb 10, 2015
  15. Jan 23, 2015
  16. Jan 13, 2015
    • Jared Hancock's avatar
      filter: Implement several small things after discussion · 685b6480
      Jared Hancock authored
        * Add trashcan icon for newly-added actions
        * Categorize filter actions
        * Use imperative phrases for action descriptions
        * Drop check boxes from simple actions (like reject ticket)
        * Hide empty forms on new ticket pages
        * Do not store config for nondata fields for actions
        * Implement a multi-use feature for actions, which will allow using a
          action more than once (for instance, multiple email sends)
        * Filter actions are sortable
        * Send email has from address configurable
        * %{user} token is valid as a recipient
      685b6480
Loading