Skip to content
Snippets Groups Projects
  1. Apr 30, 2015
  2. Apr 29, 2015
  3. Apr 23, 2015
  4. Apr 21, 2015
  5. Apr 20, 2015
  6. Apr 16, 2015
  7. Apr 15, 2015
    • Peter Rotich's avatar
      Merge pull request #1941 from greezybacon/feature/dynamic-forms-1.1 · 3278541f
      Peter Rotich authored
      
      Feature :: Dynamic Forms 1.1 — address major confusion and magic issues
      
      Reviewed-By: default avatarPeter Rotich <peter@osticket.com>
      3278541f
    • Jared Hancock's avatar
      ca614b96
    • Jared Hancock's avatar
      custom-data: Address major confusion · 4efef017
      Jared Hancock authored
      This feature addresses a major issue with the initial implementation of the
      custom data system. The original system confused the usage of
      database-backed field (dynamic-fields) and their corresponding
      implementation. This created the need to crate awkward caching pieces to
      ensure that validation errors and data was maintained. Furthermore, the
      system confused the linking between form instances (dynamic-entry) and the
      form used to represent that entry.
      
      This patch addresses the confusion in two ways:
      
      Dynamic form entries do not link directly to the dynamic form. Instead, the
      ::getForm() method returns something from the forms API directly.
      Furthermore, the ::getFields() method does not return dynamic field
      instances (database backed / designed fields). Instead, the actual
      implementation of the fields from the forms API is retrieved. This allows
      the fields to *always* be cached, which helps preserve data and validation
      state.
      
      Secondly, the dynamic form uses the same system, so that requests to turn a
      dynamic form into a form (via ::getForm) will also result in the same
      behavior, again, where the fields are represented as forms API fields rather
      than the dynamic fields.
      
      So going forward, the dynamic fields are *only* used to create corresponding
      forms API field implementations. The are associated with the dynamic
      counterparts as sparingly as possible.
      4efef017
    • Jared Hancock's avatar
      mailer: Embed the Message-Id token in @class · 06a9b903
      Jared Hancock authored
      Several mail clients do not return the Message-ID header in a In-Reply-To or
      References header as they should. The assumption by such mail clients is
      that the email be threaded based on the Subject header. However, osTicket
      does not require the ticket number to be placed in the Subject header and so
      has trouble threading email from such systems. osTicket embeds a copy of the
      Message-ID header (or compatible version) in the body of the message in
      hopes part of the message will be returned.
      
      Many mail clients (such as osTicket) strip and clean the HTML when
      processing HTML email. Previously, the message-id token was embedded in a
      @data-mid attribute, which was likely stripped before the HTML email would
      be returned back to osTicket.
      
      This patch suggests that the token be placed in a @class attribute, which
      has a much better chance of returning to osTicket.
      06a9b903
    • Michael's avatar
  8. Apr 14, 2015
    • Jared Hancock's avatar
      Fix image CID rewrite for some pasted images · cd538a8f
      Jared Hancock authored
      Copy+Pasting images from a ticket thread or from a FAQ article to the HTML
      editor and submitting will result in the URL *not* being properly rewritten
      for storage in the database. When images are uploaded, a relative URL is
      returned from the server and embedded in the HTML editor. However, when
      images from the system are copy and pasted into the editor, an absolute URL
      with the http:// scheme is included. This URL was not properly handled by
      the URL rewriter in Format::localizeInlineImages().
      
      This patch addresses the issue by properly handling both relative URLs from
      image uploads and absolute URLs from copy and pasting.
      cd538a8f
    • Jared Hancock's avatar
      i18n: Fix missing echos · c71e477b
      Jared Hancock authored
      Fixes #1926
      c71e477b
    • Jared Hancock's avatar
      i18n: rtl: Flip sub-nav icon position · 55e01a2a
      Jared Hancock authored
      55e01a2a
    • Jared Hancock's avatar
      i18n: Don't wrap sub-navigation · 8cfab8d6
      Jared Hancock authored
      8cfab8d6
Loading