reduce memory usage when decoding files

Reviewed-By: Peter Rotich <peter@osticket.com>

Blank page from 'register' link in notification email to guest user.

Reviewed-By: Jared Hancock <jared@osticket.com>

reduce memory usage when storing file in DB

Reviewed-By: Jared Hancock <jared@osticket.com>

include @greezybacon suggestion on fix

Fixes #2350 in `develop`

Fix blank page from 'register' link in email

We have existing clients who do not have an account (yet) on osTicket.  We create a ticket for them from the admin interface (creating a new guest user account) and this results in an email being sent to them with details of a job carried out.  This user can then click on the link in the notification email and view the ticket as guest - and hopefully opt to register an account.

The problem seems to be this - the user clicks on the ticket number in their notification email which lets them view the ticket as a guest - there is then a link to 'register for an account' linked to http://www.example.com/account.php?do=create - but clicking this link results in a blank page.  The PHP error is:

PHP Fatal error:  Call to a member function getField() on a non-object in /home/osticket/public_html/account.php on line 35, referer: http://www.example.com/tickets.php?id=105

This seems to be related to a bug in account.php around line 34.

    // Guest registering for an account                                                                                                      
    if ($thisclient->isGuest()) {
        foreach ($thisclient->getForms() as $f)
            if ($f->get('type') == 'U')
                $user_form = $f;
        $user_form->getField('email')->configure('disabled', true);
    }

If    $f->get('type')   is not equal to 'U' then $user_form does not get set - and therefore:
    $user_form->getField('email')->configure('disabled', true);

results in the 'call member function on a non-object error'.

I think the block should be:

    // Guest registering for an account                                                                                                      
    if ($thisclient->isGuest()) {
        foreach ($thisclient->getForms() as $f)
            if ($f->get('type') == 'U') {
                $user_form = $f;
                $user_form->getField('email')->configure('disabled', true);
            }
    }

Further - to be implicit the foreach statement should have curly braces.

    // Guest registering for an account                                                                                                      
    if ($thisclient->isGuest()) {
        foreach ($thisclient->getForms() as $f) {
            if ($f->get('type') == 'U') {
                $user_form = $f;
                $user_form->getField('email')->configure('disabled', true);
            }
        }
    }

This change handles write and read error in case of decoding to temp file, and falls back to in-memory decoding in case of failure

When decoding attached files, passing the whole content of the file to imap_base64 or base64_decode leads to allocating the memory for the whole base 64 decoded file while the binary content of the file is still in memory. This leads easily to Out of memory error on limited resources servers. Using .stream_filter_append to decode the file while writing it in a temporary file uses much less memory. The content of the decoded file is then simply read from the file

When saving an attached file in the database, Passing the whole content of the file to bin2hex leads to allocating the memory for the whole hex encoded file while the binary content of the file is still in memory. This leads easily to Out of memory error on limited resources servers. Calling bin2hex on each chunk of the file greatly limits the memory usage.

orgs: Show user search box adding user to org

Peter Rotich <peter@osticket.com>

Fixes #2410

This patch drops the content after the last boundary in a multi-part message
which prevents it from being considered in some case where the available
content sections are not favorable.

Backport me to v1.9

search: Fix malformed results on remote user search

Reviewed-By: Peter Rotich <peter@osticket.com>

Revert "db: Fix ticket queue counts for large datasets"

Reviewed-By: Peter Rotich <peter@osticket.com>

org: Fix matching of empty domain name

Reviewed-By: Peter Rotich <peter@osticket.com>

search: Fix ticket number search on client portal

Reviewed-By: Peter Rotich <peter@osticket.com>

This reverts commit c4ace2d5.

If a user is created with an empty domain name (e.g. <user@>), then the user
would be associated with the first organization without a main domain
specified.

This patch ensures that the domain is not empty when making a match with an
organization.

xss: Properly escape choices when rendered

Reviewed-By: Peter Rotich <peter@osticket.com>

This fixes an issue where, when the mailfetch subsystem fetches more than
one email and one of them has a TNEF attachment; each message body after the
TNEF message will use the TNEF message body.

This patch fixes the issue by clearing the TNEF body in each cycle through
the message fetching and parsing loop.

search: Auto reindex when _search is created

Reviewed-By: Peter Rotich <peter@osticket.com>

This patch automatically configures reindexing of the search table when the
table is dropped and recreated.

variable: The HTML balancing system urlencodes @Hamsteren 

Reviewed-By: Peter Rotich <peter@osticket.com>

The DomDocument::saveHtml() method will properly urlencode() values in the
a[@href] attributes when saving. This patch allows for the sanitization
while also allowing the variable replacement system to work properly with
the sanitized values.

oops: Fix missing data from new form entries

Reviewed-By: Peter Rotich <peter@osticket.com>

cli: Fix incorrect option parsing

Peter Rotich <peter@osticket.com>