- Mar 02, 2015
-
-
Jared Hancock authored
If the system receives an email by a collaborator which has not yet been added to the ticket (a friend of a friend — that is, a collaborator forwards an email to a third-party), a header is added to the thread body something like: Received From: afriendofafriend@mycompany.tld However, if the thread body is text and the HTML ticket thread is enabled, then the text formatting hint will be lost and the body will be assumed as HTML deeper inside the thread entry creation process. Therefore, the whitespace inside the resulting thread entry will be collapsed. This patch addresses the issue by maintaining the original format hint with the thread body.
-
- Jan 30, 2015
-
-
Jared Hancock authored
-
- Jan 09, 2015
-
-
Jared Hancock authored
-
- Jan 06, 2015
-
-
Jared Hancock authored
-
- Dec 31, 2014
-
-
Jared Hancock authored
This script adds a single download script, 'file.php', which provides access to files of all types to all users. It uses a HMAC signature system with an expires time, which allows signed URLs to be sent to external users. This also fixes an issue with the Http::cacheable() method, where the last-modified and Etag headers were not properly compared, which resulted in permanent cache misses by the client.
-
- Dec 28, 2014
-
-
Peter Rotich authored
Stop trampolining links via l.php. It was necessary before in order to avoid the potential of leaking ticket number & email. The authentication mechanism in place now redirects on successful login.
-
- Dec 26, 2014
-
-
Jared Hancock authored
This patch changes the default formatting for text bodies used in emails, ticket thread, and canned response quoting so that white-space in text bodies is properly preserved. Previously, the text was treated as raw HTML and was not properly escaped, nor was the original whitespace preserved.
-
- Nov 13, 2014
-
-
Jared Hancock authored
The ticket number regex was changed with the advent of custom ticket numbers, and it matches the closing punctuation in [#12345], that is, the closing bracket would be included in the ticket number sought in the database. Therefore, it would never match the ticket number properly. The new regex attempts to match punctuation and non-punctuation groups so that punctuation in the middle of the ticket number is matched; however, punctuation at the end is not. So #12345+DEPT will match properly and will ignore any trailing whitespace and punctuation.
-
- Oct 20, 2014
-
-
Jared Hancock authored
-
- Oct 06, 2014
-
-
Jared Hancock authored
-
- Sep 10, 2014
-
-
Jared Hancock authored
Previously, the code would scan the email headers until it found a positive match from any of the email headers scanned. Additionally, it would attempt to find the user from the tagged email references header. However, this algorithm assumed that the references header was constant and predictable in its ordering. Recent tests with Gmail prove otherwise in some tests. This patch changes the system so that only the tagged reference header is included in the References header, and it will scan all items in a header (namely the References header) until both the thread and a user are identified. If a user can be identified, the thread and user are returned. Otherwise, the first thread hit is returned.
-
- Sep 09, 2014
-
-
Jared Hancock authored
-
- Sep 04, 2014
-
-
Jared Hancock authored
Also, fix duplicate emails where a user as a collaborator would be sent a confirmation for their own respective email.
-
- Aug 29, 2014
-
-
Jared Hancock authored
Attachment settings are now exclusively handled by the settings on the ThreadEntry field on the ticket details form. Enabling attachments as well as tuning attachment validation settings are all handled from the one place now.
-
- Aug 14, 2014
-
-
Jared Hancock authored
-
- Aug 07, 2014
-
-
Jared Hancock authored
-
- Jul 29, 2014
-
-
Jared Hancock authored
Ticket numbers are now configurable as a system-default and by help topic. Previously, an administrator could select between six-digit random and sequential numbers. Now, the sequence is selectable so multiple sequences as needed, and a format can be specified to define how the ticket numbers look. Formats can also be defined for each help topic.
-
- Jun 27, 2014
-
-
Jared Hancock authored
-
- Jun 25, 2014
-
-
Thane de Loth authored
Multilanguage Support via gettext - added gettext encapsulations to all texts i thought necessary - added fallback function for the case that the gettext extension isn't loaded - added browser language detection - added gettext to the list of optional extensions in setup - rewritten some of the texts to use sprintf instead of appending strings - added german translation file - removed mark_overdue-confirm from cannedresponses.inc.php extend multi language support and a fex fixes - Better detection of translation files - Added functionality to redirect language codes (see redirecting language codes) - Ticket Status can be translated - The Datepicker can be translated - Extended functionality of 'testlang.php' to show what language code is used to translate Forgotten to apply a patch from RC5 to RC6 - Forgotten to change $var to $vars in line 380 of class.mailfetch.php - Removed unneeded comment Added php_gettext as primary translation engine - Added php_gettext support (thanks to Danilo Segan and Steven Armstrong) - php_gettext is now the primary translation engine - Extended language detection functionality Add error/misconfiguration checks and fix undefined variables
-
- Jun 05, 2014
-
-
Jared Hancock authored
-
- May 30, 2014
-
-
Jared Hancock authored
This will be useful for plugins which might need to scan the message body regardless of its encoding. This will also be required for full-text indexes which will not need to index HTML tags, for instance.
-
- May 22, 2014
-
-
Jared Hancock authored
-
- May 20, 2014
-
-
Jared Hancock authored
This patch adds an 'email' format to ThreadBody::display() which allows formatting the html/text bodies specifically for email. Previously, there was ambiguity between the html view (which included inline image support and clickable links) and the email view, which requires neither.
-
- May 13, 2014
-
-
Jared Hancock authored
If an email contains both inline and separate attachments, the previous logic would detect all the attachments as inline. Separate attachments have the `cid` set to `false`. This will pass the `isset` test, which would cause the logic to search through the body for a string of `cid:`, which would very likely be found if there was another inline image somewhere in the body of the email.
-
- May 12, 2014
-
-
Jared Hancock authored
With the advent of 1.9, the original, plain text email is saved in the thread table. If a system has the HTML ticket thread enabled (which is the default), if the plain text message is placed in the email template (which is always HTML), it will not be formatted as correct HTML and the whitespace will be collapsed. This patch addresses the issue by always returning HTML from the asVar() method, which is used to embed the thread post into a email template.
-
- May 09, 2014
-
-
Jared Hancock authored
-
- May 08, 2014
-
-
Jared Hancock authored
-
- Apr 16, 2014
-
-
Jared Hancock authored
This occurs for attachments added via the staff or client web interfaces
-
Jared Hancock authored
-
- Apr 15, 2014
-
-
Jared Hancock authored
-
- Apr 14, 2014
-
-
Jared Hancock authored
It is perfectectly fine to have an image cited in an HTML body similar to: <img width=909 height=302 src=cid:image002.jpg@01CF5426.BF5A72A0 alt=image> Which may or may not have quoted @src attribute, and may very well have an at sign (@) somewhere in the attribute text. The previous regular expression would not match such a @src attribute.
-
Jared Hancock authored
It is the defacto standard to reference an inline image in an email by referencing the Content-ID header of the referenced attachment in the @src attribute of the image. For instance, `<imc src="cid:image001.png">` where the `cid:` scheme of the attribute indicates that the referenced image URL is a separate content of the email. The image attached to the email would have an accompanying header like: `Content-Id: <image001.png>`. However, some mail systems, including a certain fax to email service, do not correctly indicate the location of the image with the content-id URL. Instead, the referenced image tag would be `<img src="image001.png">` This patch addresses the issue by searching the message body for all references to attached content-id's in all @src attributes with or without the content-id URL scheme indicator. Previously, such images would not be displayed inline in the ticket thread. References: https://tools.ietf.org/html/rfc2392
-
- Apr 11, 2014
-
-
Jared Hancock authored
-
- Apr 10, 2014
-
-
Jared Hancock authored
It is perfectectly fine to have an image cited in an HTML body similar to: <img width=909 height=302 src=cid:image002.jpg@01CF5426.BF5A72A0 alt=image> Which may or may not have quoted @src attribute, and may very well have an at sign (@) somewhere in the attribute text. The previous regular expression would not match such a @src attribute.
-
- Apr 09, 2014
-
-
Jared Hancock authored
-
Jared Hancock authored
-
Jared Hancock authored
-
Jared Hancock authored
Thread entries now have a flexible `format` specification, which allows the system to save the format alongside the original text. This allows the system not to have to convert everything to HTML when storing in the database
-
- Apr 07, 2014
-
-
Jared Hancock authored
-
- Apr 04, 2014
-
-
Jared Hancock authored
-