Under certain intermittent circumstances (usually a significant number of
ORM queries), the ORM will trigger a MySQL error:

Commands out of sync; you can't run this command now

Usually this MySQL error is related to buffered versus unbuffered queries.
However, the ORM already uses buffered queries (MySQL calls it
"store_result"). In this case, it appears there is some sort of race between
fetching the result metadata before configuring the statement for buffering.
(By "race" I mean that the error is not reliably triggered).

This patch seems to fix the issue by configuring buffering before fetching
result metadata — necessary to configure the fetching (output) phase of the
statement.

forms: Support non-US locale on client portal

Reviewed-By: Peter Rotich <peter@osticket.com>

The staff portal has a feature where the date fields are converted to
YYYY-MM-DD prior to form submission. However, this code was not ported to
the client portal. Therefore, for non-US date formats (d/m/Y for instance)
would not be processed properly by the server and would be nulled prior to
validation.

Fix #1302.

Reviewed-By: Peter Rotich <peter@osticket.com>

pages: Fix incorrect lookup of inline images

Reviewed-By: Peter Rotich <peter@osticket.com>

Fix issue that fails for get names on incorrect formats. Ex: J.Everybody

In some cases, a POST might be sent to the server and there be no draft. In
such a case, neither the draft nor the body of the page can be inspected for
images. Even worse, in some cases the previous images might be unlinked from
the article without being relinked. Therefore, the images will no longer be
linked to the page and will likely be purged from the system.

email: Improve user identification from headers

Reviewed-By: Peter Rotich <peter@osticket.com>

This is the correct logic - we'll address issue #1259 separately

Reviewed-By: Peter Rotich <peter@osticket.com>

Previously, the code would scan the email headers until it found a positive
match from any of the email headers scanned. Additionally, it would attempt
to find the user from the tagged email references header. However, this
algorithm assumed that the references header was constant and predictable in
its ordering. Recent tests with Gmail prove otherwise in some tests.

This patch changes the system so that only the tagged reference header is
included in the References header, and it will scan all items in a header
(namely the References header) until both the thread and a user are
identified. If a user can be identified, the thread and user are returned.
Otherwise, the first thread hit is returned.

pjax: Navigate away on attachment and download links

Reviewed-By: Peter Rotich <peter@osticket.com>

email: Add MAIL_EOL setting to ost-config.php file

Reviewed-By: Peter Rotich <peter@osticket.com>

This setting allows administrators to add (uncomment) a MAIL_EOL setting in
the ost-config.php config file to define the line ending used for mail
headers and encoded bodies in outbound mail (SMTP, for instance).

By default, CRLF is used by the SMTP email generator as per the RFC 822
standard. However, many administrators can benefit by setting LF (\n) as the
line ending.

forms: Fix html rendering of checkbox description

Reviewed-By: Peter Rotich <peter@osticket.com>

forms: Always attempt to look up selection value by name

Reviewed-By: Peter Rotich <peter@osticket.com>

api: Handle ArrayObject like an array for request validation

Reviewed-By: Peter Rotich <peter@osticket.com>

Fix incorrect collaborator and owner email links

Reviewed-By: Peter Rotich <peter@osticket.com>

Also, fix duplicate emails where a user as a collaborator would be sent a
confirmation for their own respective email.

forms: Add all forms to the filter subsystem

Reviewed-By: Peter Rotich <peter@osticket.com>

html: Fix dropped text after inserted image

Reviewed-By: Peter Rotich <peter@osticket.com>

email: Always include a message-id token

Reviewed-By: Peter Rotich <peter@osticket.com>

auth: Always show agent login link

Reviewed-By: Peter Rotich <peter@osticket.com>

oops: Swapped last-message and original message

Reviewed-By: Peter Rotich <peter@osticket.com>

Double scp in link: scp/scp/slas.php

Reviewed-By: Jared Hancock <jared@osticket.com>

Make sure ticket create date is used on export

Reviewed-By: Jared Hancock <jared@osticket.com>

On some setups, IE v10 on Windows 7 at least, text added to the Redactor
editor after an image is inserted (via the image popup dialog for instance),
will not be retrieved via the ::get() method and so will not be submitted
with the form submit button.

This patch introduces a workaround by manually calling ::sync() for the
Redactor when the submit button is pressed — just before the form is
submitted.

Turns out the canned response selections for the original message and the
last message were swapped.

Previously, if the quoted response mechanism was disabled, then outgoing
mail would also not include the message-id token. This breaks the
correlation of email to ticket-thread. Now, the message-id token is always
embedded in HTML emails even if the quoted-response removal system is
disabled.

(Turns out that the message-id token was always included in text bodies.)

Previously, if the enduser registration mode were set to something other
than `public`, the agent sign-in link would not be shown. Now, the agent
sign-in link is always shown on the enduser sign-in page.

Thanks for the hint Peter.
Changed it (again) and also tested at our system. /scp/slas.php works as intended - so only the slash "/" before "scp/slas.php" was missing.