We introduced a glitch in 29b37144, which was the patch that introduced
matching on email headers other than the Subject.

I misinterpreted the original `preg_match()` regex, thinking that it was
requiring brackets. Looking at it again today, I see that it didn't. The
current one does, however, require surrounding brackets.

This patch also allows for extra letters or dashes between the `#` and the
ticket number. Eventually we should allow the ticket number itself to have
extra characters -- be formattable.

Fixes osTicket/osTicket-1.8#342

mysqli: Allow specification of a unix socket

Reviewed-By: Peter Rotich <peter@osticket.com>

This patch allows for the specification of a socket in the database hostname
field, such as localhost:/path/to/mysql.sock

bug fix for custom upgrade streams

Reviewed-By: Jared Hancock <jared@osticket.com>

perf: Significant improvement fetching statistics

Reviewed-By: Peter Rotich <peter@osticket.com>

auth: Handle REQUEST_URI not being authoritative

Reviewed-By: Peter Rotich <peter@osticket.com>

'where 1' and 'where 1=1' gives me hives...

If _SERVER{REQUEST_URI} does not start with a leading slash, add one. This
will ensure that the redirect URL offered after a successful login will
be to an absolute url rather than an implied relative one.

Fixes osTicket/osTicket-1.7#858

line 199: in case of custom upgrade streams, variable $signature contains the last value from the foreach cycle at line 130, not the core schema signature!

line 209: if we do not insert schema signatures for each custom stream, after install osTicket thinks it needs an upgrade and gets stuck (see function isUpgradePending() in class.ticket)

email: Accept inline body with disposition params

Reviewed-By: Peter Rotich <peter@osticket.com>

A mail client may indicate a header parameter (such as Novell Groupwise,
which may add something like

Content-Disposition: inline; modification-time: "Thu ..."

) Previously, the system would not consider the content to be a candidate
for the email body, because it has parameters to the content-disposition
header.

This patch will still consider the part to be a candidate for the body if
the mime types match and no filename is found in the content-disposition
parameters.

api: Add example script to create tickets

Reviewed-By: Peter Rotich <peter@osticket.com>

Properly handle htmlchars in web-based posts

Reviewed-By: Peter Rotich <peter@osticket.com>

email: Handle poorly encoded email headers

Reviewed-By: Peter Rotich <peter@osticket.com>

Handle cases where email headers contain unicode or high-ascii characters
and are not encoded according to RFC-2047. This patch handles a special case
where a detectable unicode character set is used, such as UTF-8. For
high-ascii characters in a character set other than iso-8859-1, the result
of this patch is undefined.

Fixes #826

Fix filter issue where negative logic prevents matches

Reviewed-By: Peter Rotich <peter@osticket.com>

The quickList() method will attempt to ask the database to find filters that
might match the incoming ticket information. The idea is that MySQL is
likely faster than PHP. The problem is that it assumes positive logic is
being utilized.

This patch adds all filters with at least one rule with dn_contain
(does-not-contain) or not_equal (not-equal)

Fixes #834 (again)

Fix parsing issue in strtotime()

Reviewed-By: Peter Rotich <peter@osticket.com>

PHP can't discern the difference between d/m/Y and m/d/Y when just the date
is submitted to strtotime(). Unfortunately, strptime() is not available
until PHP 5.1.0. This patch forces datepickers to change their values to
YYYY-MM-DD upon submission to disambiguate parsing issues.

Fixes #832

And freshen up the upgrading guide

Add long lost kb category listing background

Reviewed-By: Peter Rotich <peter@osticket.com>

Use system date format for date picker

Reviewed-By: Peter Rotich <peter@osticket.com>

Previously the American date format (m/d/Y) was used exclusively for
formatting dates in the datepicker widget. This patch enables the widget to
be formatted based on the format set in the admin panel.

Fixes #829

Content disposition parameters are optional

Reviewed-By: Peter Rotich <peter@osticket.com>

If a Content-Disposition header exists for an attachments, it isn't required
to have any parameters (like a file name)

Better email headers for In-Reply-To and References

Reviewed-by: Peter Rotich <peter@osticket.com>

Make captcha text case-insensitive

Reviewed-By: Jared Hancock <jared@osticket.com>

Previous the options defined for the Mailer::send() function were confusing
when sending an In-Reply-To header

Previously, the References header emitted by the system for new thread
entry auto-responses and alerts included the message-id for which the email
was a reply in the `References` header. This patch corrects the issue by
placing the reply message-id in the In-Reply-To header, and constructs a
correct References header.

That is, if available, the References header received in the email that was
used to create the thread entry is appended to the message-id the email is
actually in reply to. This is the expected usage of the References header.

Support ticket thread items in email templates

Reviewed-By: Peter Rotich <peter@osticket.com>

Strip quoted reply revisited

Reviewed-By: Jared Hancock <jared@osticket.com>