Skip to content
Snippets Groups Projects
  1. Jun 28, 2019
    • Peter Rotich's avatar
      Merge pull request #4931 from JediKev/issue/iframe-single-quotes-devnext · 98860344
      Peter Rotich authored
      issue: iFrame Single Quotes
      98860344
    • JediKev's avatar
      issue: iFrame Single Quotes · 4b59b4f0
      JediKev authored
      It's all about the single quotes baby! Apparently I can't read; the single
      quotes are only meant for word options such as `'self'` and `'none'`. When
      adding single quotes to the `<host-source>` options it takes them
      literally…too literally. For example, if your options are `'localhost:80
      localhost:8080 localhost:8000'` then `'localhost:80` and `localhost:8000'` will
      be seen as "invalid" due to the single quotes. This removes the single
      quotes from every line that sets the CSP so all options are valid. This also
      adds single quotes around the `self` option so it stays valid as well.
      4b59b4f0
  2. Jun 13, 2019
  3. Jun 11, 2019
    • aydreeihn's avatar
      Issue: Ticket Alerts vs Dept Recipients · 581f1f9c
      aydreeihn authored
      If an alert is enabled for only the Department Manager and the Department Recipients field is set to No one, the Department Manager still receives a notification.
      
      If the recipients field is set to no one, nobody should receive an alert regardless of what is checked on the New Ticket Alert selections.
      
      To fix this, we can do a count of what the getMembersForAlerts function returns. This function compares what is set for a Department's group_membership in the database to the ALERTS_DISABLED constant to return a query set of members that should receive an alert. If the count is 0, we know that alerts should be disabled.
      581f1f9c
  4. Jun 03, 2019
    • Jared Hancock's avatar
      task: Implement edit of task thread · 394ddee8
      Jared Hancock authored
      This fixes an issue where, for task threads, if an agent has the thread edit
      permission, the agent was neither able to edit his or her own entries, nor the
      entries of other agents.
      394ddee8
  5. May 15, 2019
  6. May 10, 2019
  7. May 09, 2019
  8. Apr 29, 2019
    • JediKev's avatar
      issue: Queue Sort Title No Validation Error · 029b0f28
      JediKev authored
      This addresses an issue reported on the Forum where adding a new Sort Option
      for Queues without a title fails without error. This is due to the
      queue-sorting template that uses a new instance of the
      `QueueSortDataConfigForm` form from a new instance of `QueueSort` rather
      than the existing form with existing POST data/errors when a POST is
      submitted. This updates the queue-sorting template to use the already
      available `$data_form` form instance. This also adds an if statement to set
      the `$data_form` if one doesn’t exist (this only applies to new modals
      without a POST).
      029b0f28
    • JediKev's avatar
      oops: .eml/.msg Missing Not Operator · ce8aadf8
      JediKev authored
      This addresses a typo where we are missing a not operator in class
      MailFetcher when checking for no `$body` in the fetched attachments. This
      adds the not operator so that the `if()` statement is properly executed and
      we correctly set a fake body when there is none.
      ce8aadf8
  9. Apr 25, 2019
    • JediKev's avatar
      cli: Package No File Permissions · 25e6c6e9
      JediKev authored
      This addresses an issue where the `package` cli module is leaving out the
      permissions on files. This causes the final ZIP archive to contain files
      without permissions meaning the files are un-usable until you restore
      permissions. This can make life difficult on people trying to install
      osTicket with minimal knowledge as they wouldn’t know what is wrong.
      
      This is due to the `setExternalAttributesName` method not shifting 16 bits
      on the file "mode" which will not translate to binary. The file "mode" is
      the inode protection mode for a file returned by the `stat()` method. It is
      essentially a decimal representation of a file's permissions. Since "mode"
      is in decimal format we need to shift by 16 bits to translate it to binary
      so the archiver understands. Once the mode is translated to binary the
      permissions are preserved.
      25e6c6e9
    • aydreeihn's avatar
      Lint Fixes · 8c878db6
      aydreeihn authored
      This commit gets rid of PHP warnings. Additionally, it updates the lint tests to be more accurate.
      8c878db6
  10. Apr 24, 2019
  11. Apr 23, 2019
  12. Apr 22, 2019
Loading