Skip to content
Snippets Groups Projects
  1. Apr 13, 2016
    • Jared Hancock's avatar
      orm: Don't null out value on assignment · 93a34c43
      Jared Hancock authored
      This fixes an issue where the PK of ThreadEntry will be NULLed in the
      following code
      
      ```php
      $entry = ThreadEntry::create(array(...));
      $entry->save();
      $entry->email_info = new ThreadEntryEmailInfo(array(
          'mid' => 'xyzAbc',
      ));
      ```
      
      In the above code, the $entry->__set('email_info', <ThreadEntryEmailInfo>)
      would be invoked. The ThreadEntryEmailInfo object is new, and so will cause
      the local part of the relationship (`id` in this case) to
      become null further down in the `__set` method.
      
      This issue is fixed in this commit by removing the NULL assignment to the
      new object. This was added in 11322766,
      however, it is unclear why the null assignment is performed.
      93a34c43
    • Jared Hancock's avatar
      files: Attempt to standardize thread entry attaching · 00a1371d
      Jared Hancock authored
      This commit attempts to remove some of the confusing and redundant code to
      attach files to thread entries and replace it with a single code base. It
      also attempts to remove and error where a single attachment might be
      attached to a new thread entry multiple times.
      
      Lastly, it removes the insert followed by an update for emails with inline
      images. This should improve performance processing emails as only one trip
      to the database is now necessary for thread entries with inline images.
      00a1371d
  2. Apr 04, 2016
  3. Mar 30, 2016
  4. Mar 29, 2016
  5. Mar 28, 2016
  6. Mar 27, 2016
  7. Mar 26, 2016
  8. Mar 25, 2016
  9. Mar 24, 2016
  10. Mar 20, 2016
    • Jared Hancock's avatar
      login: Make the backdrop customizable · 463de2e9
      Jared Hancock authored
      This duplicates the custom logo code to allow for custom login backdrops. A
      new page is added to the "Company" settings page which allows for management
      of the uploaded custom backdrops.
      463de2e9
  11. Mar 19, 2016
Loading