Skip to content
Snippets Groups Projects
  1. Jan 18, 2014
  2. Jan 14, 2014
  3. Jan 13, 2014
    • Jared Hancock's avatar
      Use case-insensitive matching on email address · 08398509
      Jared Hancock authored
      This patch addresses an issue where a client may have upper-case letters in
      their email address. When visiting the client portal to check the ticket
      status, previously, the exact same case would be required in the 'Email
      Address' box.
      
      This patch remove the case sensitivity for email logins.
      08398509
  4. Jan 11, 2014
  5. Jan 03, 2014
    • Jared Hancock's avatar
      http: Legacy versions of IIS redirect incorrectly · 176af908
      Jared Hancock authored
      (And newer versions don't seem to like the legacy code). This patch uses a
      `Refresh` header for IIS versions prior to 7.0 (included with Windows Vista
      / Server 2008). Starting with IIS 7.0, the Location header should be
      properly handled by IIS.
      176af908
  6. Dec 31, 2013
    • Jared Hancock's avatar
      Honor ticket number in subject line without brackets · a74d9a5c
      Jared Hancock authored
      We introduced a glitch in 29b37144, which was the patch that introduced
      matching on email headers other than the Subject.
      
      I misinterpreted the original `preg_match()` regex, thinking that it was
      requiring brackets. Looking at it again today, I see that it didn't. The
      current one does, however, require surrounding brackets.
      
      This patch also allows for extra letters or dashes between the `#` and the
      ticket number. Eventually we should allow the ticket number itself to have
      extra characters -- be formattable.
      
      Fixes osTicket/osTicket-1.8#342
      a74d9a5c
  7. Dec 17, 2013
  8. Dec 09, 2013
  9. Nov 30, 2013
  10. Nov 20, 2013
    • Jared Hancock's avatar
      email: Accept inline body with disposition params · 2b13adc5
      Jared Hancock authored
      A mail client may indicate a header parameter (such as Novell Groupwise,
      which may add something like
      
      Content-Disposition: inline; modification-time: "Thu ..."
      
      ) Previously, the system would not consider the content to be a candidate
      for the email body, because it has parameters to the content-disposition
      header.
      
      This patch will still consider the part to be a candidate for the body if
      the mime types match and no filename is found in the content-disposition
      parameters.
      2b13adc5
  11. Nov 19, 2013
  12. Nov 05, 2013
    • Jared Hancock's avatar
      Fix filter issue where negative logic prevents matches · 1f5694c1
      Jared Hancock authored
      The quickList() method will attempt to ask the database to find filters that
      might match the incoming ticket information. The idea is that MySQL is
      likely faster than PHP. The problem is that it assumes positive logic is
      being utilized.
      
      This patch adds all filters with at least one rule with dn_contain
      (does-not-contain) or not_equal (not-equal)
      1f5694c1
  13. Oct 31, 2013
    • Jared Hancock's avatar
      Fix parsing issue in strtotime() · b9ab14c1
      Jared Hancock authored
      PHP can't discern the difference between d/m/Y and m/d/Y when just the date
      is submitted to strtotime(). Unfortunately, strptime() is not available
      until PHP 5.1.0. This patch forces datepickers to change their values to
      YYYY-MM-DD upon submission to disambiguate parsing issues.
      
      Fixes #832
      b9ab14c1
  14. Oct 30, 2013
    • Jared Hancock's avatar
      Use system date format for datepicker · ad9935b1
      Jared Hancock authored
      Previously the American date format (m/d/Y) was used exclusively for
      formatting dates in the datepicker widget. This patch enables the widget to
      be formatted based on the format set in the admin panel.
      
      Fixes #829
      ad9935b1
  15. Oct 29, 2013
  16. Oct 28, 2013
    • Jared Hancock's avatar
      Disambiguate Reply-To from In-Reply-To mailer opts · d36fea7b
      Jared Hancock authored
      Previous the options defined for the Mailer::send() function were confusing
      when sending an In-Reply-To header
      d36fea7b
    • Jared Hancock's avatar
      Better email headers for In-Reply-To and References · ca26a1a6
      Jared Hancock authored
      Previously, the References header emitted by the system for new thread
      entry auto-responses and alerts included the message-id for which the email
      was a reply in the `References` header. This patch corrects the issue by
      placing the reply message-id in the In-Reply-To header, and constructs a
      correct References header.
      
      That is, if available, the References header received in the email that was
      used to create the thread entry is appended to the message-id the email is
      actually in reply to. This is the expected usage of the References header.
      ca26a1a6
  17. Oct 24, 2013
  18. Oct 23, 2013
  19. Oct 22, 2013
  20. Oct 17, 2013
  21. Oct 11, 2013
  22. Oct 09, 2013
    • Jared Hancock's avatar
      Mark tickets overdue which have no SLA · e5682351
      Jared Hancock authored
      If a ticket has a due date and does not have an SLA set, the ticket would
      never transition to overdue. This patch addresses an SQL flaw preventing the
      ticket from being transitioned.
      
      Fixes #757
      e5682351
  23. Oct 07, 2013
  24. Oct 06, 2013
    • Jared Hancock's avatar
      Crazy performance penalty scanning blob tables · 60fcf00c
      Jared Hancock authored
      When scanning the file_chunk table for orphaned file chunks that can be
      deleted, apparently, MySQL will read (at least part of) the blob data from
      the disk. For databases with lots of large attachments, this can take
      considerable time. Considering that it is triggered from the autocron and
      will run everytime the cron is run, the database will spend considerable
      time scanning for rows to be cleaned.
      
      This patch changes the orphan cleanup into two phases. The first will search
      just for the pk's of file chunks to be deleted. If any are found, then the
      chunks are deleted by the file_id and chunk_id, which is the primary key of
      the table.
      
      The SELECT query seems to run at least 20 times faster than the delete
      statement, and DELETEing against the primary key of the blob table should
      be the fastest possible operation. Somehow, both queries required a full
      table scan; however, because the SELECT statement is explictly only
      interested in two fields, it is more clear to the query optimizer that the
      blob data should not be scanned.
      
      References:
      http://stackoverflow.com/q/9511476
      60fcf00c
  25. Oct 04, 2013
  26. Sep 30, 2013
Loading