- Jan 18, 2014
-
-
Jared Hancock authored
Required for PHP 5.5 compatibility
-
- Jan 14, 2014
-
-
Jared Hancock authored
-
- Jan 13, 2014
-
-
Jared Hancock authored
This patch addresses an issue where a client may have upper-case letters in their email address. When visiting the client portal to check the ticket status, previously, the exact same case would be required in the 'Email Address' box. This patch remove the case sensitivity for email logins.
-
- Jan 11, 2014
-
-
Jared Hancock authored
-
- Jan 03, 2014
-
-
Jared Hancock authored
(And newer versions don't seem to like the legacy code). This patch uses a `Refresh` header for IIS versions prior to 7.0 (included with Windows Vista / Server 2008). Starting with IIS 7.0, the Location header should be properly handled by IIS.
-
- Dec 31, 2013
-
-
Jared Hancock authored
We introduced a glitch in 29b37144, which was the patch that introduced matching on email headers other than the Subject. I misinterpreted the original `preg_match()` regex, thinking that it was requiring brackets. Looking at it again today, I see that it didn't. The current one does, however, require surrounding brackets. This patch also allows for extra letters or dashes between the `#` and the ticket number. Eventually we should allow the ticket number itself to have extra characters -- be formattable. Fixes osTicket/osTicket-1.8#342
-
- Dec 17, 2013
-
-
Jared Hancock authored
-
- Dec 09, 2013
-
-
Jared Hancock authored
This patch allows for the specification of a socket in the database hostname field, such as localhost:/path/to/mysql.sock
-
- Nov 30, 2013
-
-
Jared Hancock authored
'where 1' and 'where 1=1' gives me hives...
-
Eivind Ravndal authored
-
- Nov 20, 2013
-
-
Jared Hancock authored
A mail client may indicate a header parameter (such as Novell Groupwise, which may add something like Content-Disposition: inline; modification-time: "Thu ..." ) Previously, the system would not consider the content to be a candidate for the email body, because it has parameters to the content-disposition header. This patch will still consider the part to be a candidate for the body if the mime types match and no filename is found in the content-disposition parameters.
-
- Nov 19, 2013
-
-
Jared Hancock authored
-
Jared Hancock authored
Handle cases where email headers contain unicode or high-ascii characters and are not encoded according to RFC-2047. This patch handles a special case where a detectable unicode character set is used, such as UTF-8. For high-ascii characters in a character set other than iso-8859-1, the result of this patch is undefined. Fixes #826
-
- Nov 05, 2013
-
-
Jared Hancock authored
The quickList() method will attempt to ask the database to find filters that might match the incoming ticket information. The idea is that MySQL is likely faster than PHP. The problem is that it assumes positive logic is being utilized. This patch adds all filters with at least one rule with dn_contain (does-not-contain) or not_equal (not-equal)
-
- Oct 31, 2013
-
-
Jared Hancock authored
PHP can't discern the difference between d/m/Y and m/d/Y when just the date is submitted to strtotime(). Unfortunately, strptime() is not available until PHP 5.1.0. This patch forces datepickers to change their values to YYYY-MM-DD upon submission to disambiguate parsing issues. Fixes #832
-
- Oct 30, 2013
-
-
Jared Hancock authored
Previously the American date format (m/d/Y) was used exclusively for formatting dates in the datepicker widget. This patch enables the widget to be formatted based on the format set in the admin panel. Fixes #829
-
- Oct 29, 2013
-
-
Jared Hancock authored
If a Content-Disposition header exists for an attachments, it isn't required to have any parameters (like a file name)
-
- Oct 28, 2013
-
-
Jared Hancock authored
Previous the options defined for the Mailer::send() function were confusing when sending an In-Reply-To header
-
Jared Hancock authored
Previously, the References header emitted by the system for new thread entry auto-responses and alerts included the message-id for which the email was a reply in the `References` header. This patch corrects the issue by placing the reply message-id in the In-Reply-To header, and constructs a correct References header. That is, if available, the References header received in the email that was used to create the thread entry is appended to the message-id the email is actually in reply to. This is the expected usage of the References header.
-
- Oct 24, 2013
-
-
Peter Rotich authored
-
- Oct 23, 2013
-
-
Peter Rotich authored
-
Peter Rotich authored
-
Jared Hancock authored
* %{ticket.thread.original} represents the original message submitted when creating the ticket * %{ticket.thread.lastmessage} represents the most recent message submitted by the end user
-
- Oct 22, 2013
-
-
Jared Hancock authored
The XKCD index page was accidentally added when testing a new feature for osTicket-1.8
-
- Oct 17, 2013
-
-
Peter Rotich authored
-
Jared Hancock authored
-
Jared Hancock authored
Validate port during installation Add help information about the non-standard port number to the popup tips in the install screen. Support MySQL 'localhost' connections using a non-standard port number. Ordinarily, MySQL will ignore the port setting on *nix systems if the host is specified as 'localhost' Implements/Fixes #769
-
Jared Hancock authored
This patch makes openssl the preferred source of random data on Windows and will only use mcrypt_create_iv on PHP 5.3.7 and newer. Fixes #771
-
Jared Hancock authored
Fixes #772
-
Jared Hancock authored
Previous explain included a nested sub-select, which exponentially increased the count of the rows to be examined. This patch eliminates one layer of nesting on the sub-select and dramatically increases the performance finding orphaned files. Fixes #773 References: http://www.osticket.com/forums/forum/osticket-1-7-latest-release/troubleshooting-and-problems-aa/9446-version-1-7-much-slower-than-1-6
-
- Oct 11, 2013
-
-
Jared Hancock authored
Some email clients (names omitted to protect the innocent) advertise the encoding as us-ascii when iso-8859-1 was really implied. This patch allows the two charsets to be interchangable.
-
- Oct 09, 2013
-
-
Jared Hancock authored
If a ticket has a due date and does not have an SLA set, the ticket would never transition to overdue. This patch addresses an SQL flaw preventing the ticket from being transitioned. Fixes #757
-
- Oct 07, 2013
-
-
Jared Hancock authored
-
Jared Hancock authored
If the GD extension is not available for the PHP installation, then use a copy of the default client-site logo with the alpha channel removed.
-
Jared Hancock authored
Assume that text in the database is encoded in UTF-8 and assume that it is HTML text and the entities should be decoded prior to display in the PDF. Fixes #756
-
- Oct 06, 2013
-
-
Jared Hancock authored
When scanning the file_chunk table for orphaned file chunks that can be deleted, apparently, MySQL will read (at least part of) the blob data from the disk. For databases with lots of large attachments, this can take considerable time. Considering that it is triggered from the autocron and will run everytime the cron is run, the database will spend considerable time scanning for rows to be cleaned. This patch changes the orphan cleanup into two phases. The first will search just for the pk's of file chunks to be deleted. If any are found, then the chunks are deleted by the file_id and chunk_id, which is the primary key of the table. The SELECT query seems to run at least 20 times faster than the delete statement, and DELETEing against the primary key of the blob table should be the fastest possible operation. Somehow, both queries required a full table scan; however, because the SELECT statement is explictly only interested in two fields, it is more clear to the query optimizer that the blob data should not be scanned. References: http://stackoverflow.com/q/9511476
-
- Oct 04, 2013
-
-
Jared Hancock authored
Some mail clients and mail brokers do not properly handle quoted-printable encoding, used in osTicket outgoing emails. Oddly, the end mail clients render the email with trailing equal signs (=) at the end of every line, where it was added due to QP encoding. References: http://www.osticket.com/forums/forum/osticket-1-7-latest-release/troubleshooting-and-problems-aa/10708-solved-microsoft-exchange-internet-mail-lines-end-with RFC 2045 section 6.7, http://www.ietf.org/rfc/rfc2045.txt
-
Jared Hancock authored
If the body is declared with inline disposition and no filename, the parser engine would create an incorrect attachments list.
-
- Sep 30, 2013
-
-
Peter Rotich authored
-
Jared Hancock authored
If it only contains whitespace, it is also invalid
-