- Oct 09, 2013
-
-
Jared Hancock authored
Include changes from 1.7.2 Conflicts: main.inc.php
-
- Oct 07, 2013
-
-
Jared Hancock authored
-
Peter Rotich authored
Change PDF print to show custom logo Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
If the GD extension is not available for the PHP installation, then use a copy of the default client-site logo with the alpha channel removed.
-
Peter Rotich authored
Crazy performance penalty scanning blob tables Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
Better converting from ticket thread to PDF Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
Die with internal server error on misconfiguration Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
Fix parsing of attachments Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
Use base64 encoding for text version of emails Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
Assume that text in the database is encoded in UTF-8 and assume that it is HTML text and the entities should be decoded prior to display in the PDF. Fixes #756
-
- Oct 06, 2013
-
-
Jared Hancock authored
When scanning the file_chunk table for orphaned file chunks that can be deleted, apparently, MySQL will read (at least part of) the blob data from the disk. For databases with lots of large attachments, this can take considerable time. Considering that it is triggered from the autocron and will run everytime the cron is run, the database will spend considerable time scanning for rows to be cleaned. This patch changes the orphan cleanup into two phases. The first will search just for the pk's of file chunks to be deleted. If any are found, then the chunks are deleted by the file_id and chunk_id, which is the primary key of the table. The SELECT query seems to run at least 20 times faster than the delete statement, and DELETEing against the primary key of the blob table should be the fastest possible operation. Somehow, both queries required a full table scan; however, because the SELECT statement is explictly only interested in two fields, it is more clear to the query optimizer that the blob data should not be scanned. References: http://stackoverflow.com/q/9511476
-
- Oct 04, 2013
-
-
Jared Hancock authored
Or internal server (database) outage
-
Jared Hancock authored
Some mail clients and mail brokers do not properly handle quoted-printable encoding, used in osTicket outgoing emails. Oddly, the end mail clients render the email with trailing equal signs (=) at the end of every line, where it was added due to QP encoding. References: http://www.osticket.com/forums/forum/osticket-1-7-latest-release/troubleshooting-and-problems-aa/10708-solved-microsoft-exchange-internet-mail-lines-end-with RFC 2045 section 6.7, http://www.ietf.org/rfc/rfc2045.txt
-
Jared Hancock authored
If the body is declared with inline disposition and no filename, the parser engine would create an incorrect attachments list.
-
- Sep 30, 2013
-
-
Peter Rotich authored
Record message-id's for rejected emails Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
Limit admin alerts to logged messages. Reviewed-By:
Jared Hancock <jared@osticket.com>
-
Peter Rotich authored
Forbid empty reply separators Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
Expose fail count to shell environment Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
Also, run the tests in the packager. The packager will automatically run the regression test suite prior to packaging a release. The package will not build if there is at least one fail from the regression tests.
-
Peter Rotich authored
Allow deployment of setup/ Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
Useful for initial installs, where deployment of the `setup/` folder is required for the initial install. Thereafter, deployment can be run without the setup option so that the rest of the codebase can be maintained (already supported)
-
Peter Rotich authored
Disambiguate version string when running off of git Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
Message id tracking revisited Reviewed-By:
Jared Hancock <jared@osticket.com>
-
Peter Rotich authored
Disable Kerberos and NTLM auth for mail fetch Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
Implement RFC5987 for fetched attachments Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
-
Jared Hancock authored
If it only contains whitespace, it is also invalid
-
Jared Hancock authored
If a user is running off of the develop branch, disambiguate what the version they are running.
-
- Sep 29, 2013
-
-
Peter Rotich authored
-
Peter Rotich authored
line is used.
-
Peter Rotich authored
id/number. * Ticket number will be customization in the future * Ticket thread only link to Ticket should be internal ticket id.
-
- Sep 27, 2013
-
-
Peter Rotich authored
Accept attachments from email messages Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
Actually show correct template description Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
if the References or In-Reply-To header matches in a way that continues a ticket's thread, include the attachments in the thread if allowed by the system settings.
-
Jared Hancock authored
In the event that the system is set to do-nothing for POP fetched emails, and eventually, one of the emails is rejected, ensure that the message-id is logged so that the message will not be re-fetched, even if it is undeleted.
-
Jared Hancock authored
Fixes #742
-
- Sep 26, 2013
-
-
Jared Hancock authored
On some configurations of PHP and remote mail servers, Kerberos and NTLM challenge response authentication could be possibly attempted. This is essentially futile and potentially fatal for osTicket mail fetching, as the system is currently designed for username and password authentication only. This patch disables challenge and response authentication for PHP versions 5.3.2 and newer, which support the fix. This patch also consistently encodes mailbox names according to the rfc 2060 for IMAP.
-
- Sep 24, 2013
-
-
Jared Hancock authored
Previously, filenames specified in email headers fetched using the PHP imap extension were not decoded properly. Specifically, if RFC5987 was used to encode the filenames, no decoding was performed at all. This patch properly detects the filename attribute, using a decoding scheme for RFC5987 if the attribute was encoded properly. References: http://osticket.com/forums/showthread.php?t=6129
-
- Sep 23, 2013
-
-
Peter Rotich authored
Detect attachments with Content-Type: ...; name= Reviewed-With: Jared Hancock <jared@osticket.com>
-
Jared Hancock authored
RFC2045, section 5.1 seems to indicate that arbitrary parameters can be appended to a Content-Type header specification. Some email clients seem to use the Content-Type header to specify an attachment without giving a separate Content-Disposition header normally used to signify attachments. This patch corrects attachment detection for piped emails to detect such emails. The patch also correctly decodes filenames specified either in the Content-Disposition or Content-Type headers using RFC5987, where the filename can be encoded using an arbitrary character set (ie, not us-ascii).
-