Skip to content
Snippets Groups Projects
  1. Oct 09, 2013
  2. Oct 07, 2013
  3. Oct 06, 2013
    • Jared Hancock's avatar
      Crazy performance penalty scanning blob tables · 60fcf00c
      Jared Hancock authored
      When scanning the file_chunk table for orphaned file chunks that can be
      deleted, apparently, MySQL will read (at least part of) the blob data from
      the disk. For databases with lots of large attachments, this can take
      considerable time. Considering that it is triggered from the autocron and
      will run everytime the cron is run, the database will spend considerable
      time scanning for rows to be cleaned.
      
      This patch changes the orphan cleanup into two phases. The first will search
      just for the pk's of file chunks to be deleted. If any are found, then the
      chunks are deleted by the file_id and chunk_id, which is the primary key of
      the table.
      
      The SELECT query seems to run at least 20 times faster than the delete
      statement, and DELETEing against the primary key of the blob table should
      be the fastest possible operation. Somehow, both queries required a full
      table scan; however, because the SELECT statement is explictly only
      interested in two fields, it is more clear to the query optimizer that the
      blob data should not be scanned.
      
      References:
      http://stackoverflow.com/q/9511476
      60fcf00c
  4. Oct 04, 2013
  5. Sep 30, 2013
  6. Sep 29, 2013
  7. Sep 27, 2013
  8. Sep 26, 2013
    • Jared Hancock's avatar
      Disable Kerberos and NTLM auth for mail fetch · 8b0085dd
      Jared Hancock authored
      On some configurations of PHP and remote mail servers, Kerberos and NTLM
      challenge response authentication could be possibly attempted. This is
      essentially futile and potentially fatal for osTicket mail fetching, as the
      system is currently designed for username and password authentication only.
      
      This patch disables challenge and response authentication for PHP versions
      5.3.2 and newer, which support the fix.
      
      This patch also consistently encodes mailbox names according to the rfc 2060
      for IMAP.
      8b0085dd
  9. Sep 24, 2013
  10. Sep 23, 2013
    • Peter Rotich's avatar
      Merge pull request #737 from greezybacon/issue/mailparse-attachments · 1cbc6f69
      Peter Rotich authored
      Detect attachments with Content-Type: ...; name=
      
      Reviewed-With: Jared Hancock <jared@osticket.com>
      1cbc6f69
    • Jared Hancock's avatar
      Detect attachments with Content-Type: ...; name= · be02c8d4
      Jared Hancock authored
      RFC2045, section 5.1 seems to indicate that arbitrary parameters can be
      appended to a Content-Type header specification. Some email clients seem to
      use the Content-Type header to specify an attachment without giving a
      separate Content-Disposition header normally used to signify attachments.
      
      This patch corrects attachment detection for piped emails to detect such
      emails. The patch also correctly decodes filenames specified either in the
      Content-Disposition or Content-Type headers using RFC5987, where the
      filename can be encoded using an arbitrary character set (ie, not us-ascii).
      be02c8d4
Loading