Skip to content
Snippets Groups Projects
  1. Nov 19, 2019
    • Peter Rotich's avatar
      Arbitrary Method Invocation · 4dfb77ca
      Peter Rotich authored
      This commit addresses possible Arbitrary Method Invocation via AJAX file upload.
      
      To save some memory osTicket uses callback method to fetch the content of a
      file on mail fetch. $file['data'] was overloaded as a callback by simply
      checking if the content is callable, resulting in method invocation when
      content of the uploaded file is a callable.
      
      The address the issue we're not using locally set callback parameter / method.
      4dfb77ca
    • Peter Rotich's avatar
      Auth: Authentication Token Bypass · a9834d88
      Peter Rotich authored
      This commit addresses a vulnerability on how osTicket authenticates
      auth-tokens used for auto-login to view ticket status.
      
      The validation process failed to handle unexpected type handling issue
      making it possible for users to exploit type juggling and authenticate using
      only email and ticket number.
      a9834d88
    • Peter Rotich's avatar
      mPDF: Remote Code Execution Vulnerability · 6e039ab7
      Peter Rotich authored
      This commit mitigates insufficient validation in mPDF library that enables a
      malicious intruder to inject arbitrary PHP objects via css @import utility
      that may result in Remote Code Execution.
      6e039ab7
    • Peter Rotich's avatar
      Merge pull request #5192 from protich/issue/dialog-jserror · 9951125e
      Peter Rotich authored
      Dialog: Highlight tab with error(s)
    • Peter Rotich's avatar
      Highlight tab with error(s) · b81b7039
      Peter Rotich authored
      This commit addresses javascript error - on error - on a dialog modal with tab content.
      b81b7039
  2. Nov 18, 2019
  3. Nov 14, 2019
  4. Nov 13, 2019
  5. Nov 12, 2019
  6. Nov 11, 2019
  7. Nov 08, 2019
  8. Nov 06, 2019
    • Peter Rotich's avatar
      Merge pull request #5149 from JediKev/issue/db-error-1062 · cca97eda
      Peter Rotich authored
      issue: DB Error #1062
    • JediKev's avatar
      issue: Format File Name · bd427cdf
      JediKev authored
      This formats the filename before using it in an error to avoid chance of
      XSS.
      bd427cdf
    • JediKev's avatar
      issue: DB Error #1062 · 27c925cc
      JediKev authored
      This addresses a long-time issue of the famous `DB Error #1062` when
      uploading an Inline File to a Draft. The issue is that the system does not
      check if an Attachment record exists before creating a new one. We create a
      new Attachment record, we go to save it, and the system errors out because
      that record already exists. This adds a check to see if the Attachment
      record already exists and if so we use that instead of creating a new one.
      27c925cc
  9. Nov 05, 2019
  10. Nov 04, 2019
    • aydreeihn's avatar
      Issue: Edit Task Fields · 05cbb758
      aydreeihn authored
      This commit fixes an issue where you were unable to edit custom fields if they were added to a task form after a task had been created.
      05cbb758
  11. Nov 01, 2019
  12. Oct 31, 2019
  13. Oct 30, 2019
    • JediKev's avatar
      orm: Refetch Failure · eb4bda84
      JediKev authored
      This addresses an ORM failure where upon refetching an object from the
      database that no longer exists the system crashes hard. We use the `one()`
      method which expects one result, if there is no result it throws a
      `DoesNotExist` exception. We are not catching the exception properly which
      crashes osTicket and forces you to clear the session via browser or
      database.
      eb4bda84
    • JediKev's avatar
      issue: Delete Org Session Failure · bbd0c255
      JediKev authored
      This addresses an issue on the Forum where deleting an Organization causes
      the session to fail. This is due to the Organization QuerySet being stored
      in the session and not being cleared out when deleted from the system. This
      causes the system to try to refetch the object from the database which it's
      not there as it's been deleted and therefore causes the session to crash.
      bbd0c255
    • Rikki Masters's avatar
      Mark as Answered permission correction · 52aaa0bb
      Rikki Masters authored
  14. Oct 29, 2019
    • JediKev's avatar
      issue: Attachment Filter · 9f4fbc27
      JediKev authored
      This addresses issue 5123 where fetched Emails do not reject attachments
      that are not allowed. This is due to setting a File ID inside of an array
      called `$file[]` but not unsetting it when the attachment hits an
      FileUploadError. This updates class MailFetch to set the file array back to
      empty so that the ID is cleared and the error is added correctly which
      rejects the attachment.
      9f4fbc27
    • Rikki Masters's avatar
      Feature: Mark as Answered permission option · 2fcc664e
      Rikki Masters authored
      Some roles need the ability to mark a ticket as Answered/Unanswered but must not be able to reply directly to the customer. Both are controlled by the Post Reply permission. This seperates the two functions so they can be managed independently.
      2fcc664e
Loading