Skip to content
Snippets Groups Projects
  1. May 10, 2019
  2. May 09, 2019
  3. Apr 29, 2019
    • JediKev's avatar
      oops: .eml/.msg Missing Not Operator · ce8aadf8
      JediKev authored
      This addresses a typo where we are missing a not operator in class
      MailFetcher when checking for no `$body` in the fetched attachments. This
      adds the not operator so that the `if()` statement is properly executed and
      we correctly set a fake body when there is none.
      ce8aadf8
  4. Apr 25, 2019
    • JediKev's avatar
      cli: Package No File Permissions · 25e6c6e9
      JediKev authored
      This addresses an issue where the `package` cli module is leaving out the
      permissions on files. This causes the final ZIP archive to contain files
      without permissions meaning the files are un-usable until you restore
      permissions. This can make life difficult on people trying to install
      osTicket with minimal knowledge as they wouldn’t know what is wrong.
      
      This is due to the `setExternalAttributesName` method not shifting 16 bits
      on the file "mode" which will not translate to binary. The file "mode" is
      the inode protection mode for a file returned by the `stat()` method. It is
      essentially a decimal representation of a file's permissions. Since "mode"
      is in decimal format we need to shift by 16 bits to translate it to binary
      so the archiver understands. Once the mode is translated to binary the
      permissions are preserved.
      25e6c6e9
    • aydreeihn's avatar
      Lint Fixes · 8c878db6
      aydreeihn authored
      This commit gets rid of PHP warnings. Additionally, it updates the lint tests to be more accurate.
      8c878db6
  5. Apr 24, 2019
  6. Apr 23, 2019
  7. Apr 22, 2019
  8. Apr 18, 2019
  9. Apr 17, 2019
Loading