This feature allows (by option) an organization to allow its members to see
tickets from other members. It can be used beside or instead of the
automated collaboration feature. Now, collaborators retain access to tickets
on which they participate; however, sharing can be used to enable access to
other tickets owned by their organization.

Conflicts:
	WHATSNEW.md
	include/class.ticket.php
	include/class.topic.php
	include/staff/faq-view.inc.php
	include/staff/helptopics.inc.php

Fix for issue #2557 

Reviewed-By: Peter Rotich <peter@osticket.com>

Fix issues deploying with PHP 5.6

Reviewed-By: Peter Rotich <peter@osticket.com>

db: Forbid static zones like 'CDT'

Reviewed-By: Peter Rotich <peter@osticket.com>

Send header information before output. Fixes #2554

Reviewed-By: Peter Rotich <peter@osticket.com>

lock: Fix lock timing if php and db use different time zones

Reviewed-By: Peter Rotich <peter@osticket.com>

Blank page from 'register' link in notification email to guest user.

Reviewed-By: Jared Hancock <jared@osticket.com>

Fix posting-user determination in Thread::postEmail

Reviewed-By: Peter Rotich <peter@osticket.com>

reduce memory usage when storing file in DB

Reviewed-By: Jared Hancock <jared@osticket.com>

include @greezybacon suggestion on fix

Fixes #2350 in `develop`

forms: Forbid adding deleted forms to topics, form management

Reviewed-By: Peter Rotich <peter@osticket.com>

search: Improve typeahead results and performance

Reviewed-By: Peter Rotich <peter@osticket.com>

Input type= adjustment

Reviewed-By: Jared Hancock <jared@osticket.com>

Firefox form style fix

Reviewed-By: Jared Hancock <jared@osticket.com>

tickets: Fix subject display for non text fields

Reviewed-By: Peter Rotich <peter@osticket.com>

UI fix for delete button highlight - 2456

Reviewed-By: Jared Hancock <jared@osticket.com>

tasks: Assignment on task create

Reviewed-By: Jared Hancock <jared@osticket.com>

search: Add search for closed date

Reviewed-By: Peter Rotich <peter@osticket.com>

Changed logo displays on save

Reviewed-By: Jared Hancock <jared@osticket.com>

#2557 Avatar height issue in Safari.

Fix blank page from 'register' link in email

We have existing clients who do not have an account (yet) on osTicket.  We create a ticket for them from the admin interface (creating a new guest user account) and this results in an email being sent to them with details of a job carried out.  This user can then click on the link in the notification email and view the ticket as guest - and hopefully opt to register an account.

The problem seems to be this - the user clicks on the ticket number in their notification email which lets them view the ticket as a guest - there is then a link to 'register for an account' linked to http://www.example.com/account.php?do=create - but clicking this link results in a blank page.  The PHP error is:

PHP Fatal error:  Call to a member function getField() on a non-object in /home/osticket/public_html/account.php on line 35, referer: http://www.example.com/tickets.php?id=105

This seems to be related to a bug in account.php around line 34.

    // Guest registering for an account                                                                                                      
    if ($thisclient->isGuest()) {
        foreach ($thisclient->getForms() as $f)
            if ($f->get('type') == 'U')
                $user_form = $f;
        $user_form->getField('email')->configure('disabled', true);
    }

If    $f->get('type')   is not equal to 'U' then $user_form does not get set - and therefore:
    $user_form->getField('email')->configure('disabled', true);

results in the 'call member function on a non-object error'.

I think the block should be:

    // Guest registering for an account                                                                                                      
    if ($thisclient->isGuest()) {
        foreach ($thisclient->getForms() as $f)
            if ($f->get('type') == 'U') {
                $user_form = $f;
                $user_form->getField('email')->configure('disabled', true);
            }
    }

Further - to be implicit the foreach statement should have curly braces.

    // Guest registering for an account                                                                                                      
    if ($thisclient->isGuest()) {
        foreach ($thisclient->getForms() as $f) {
            if ($f->get('type') == 'U') {
                $user_form = $f;
                $user_form->getField('email')->configure('disabled', true);
            }
        }
    }

Fix case where collaborators were not being alerted
Alert admin last on new ticket - just in case admin email is used by an agent.

This patch changes the way the thread entry type and other properties are
determined by using the userClass determined in the Mailer::decodeMessageId
method which is preferred over the older heuristic methodology using the
`From` email address alone.

When saving an attached file in the database, Passing the whole content of the file to bin2hex leads to allocating the memory for the whole hex encoded file while the binary content of the file is still in memory. This leads easily to Out of memory error on limited resources servers. Calling bin2hex on each chunk of the file greatly limits the memory usage.