- Apr 24, 2016
-
-
Peter Rotich authored
Use file id instead of attachment id to unset new Get new files objects as array
-
Peter Rotich authored
orm: Partially revert 8ab4432f Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
orm: Remove references to the retired slot feature Reviewed-By:
Jared Hancock <jared@osticket.com>
-
Jared Hancock authored
org: Remove users from deleted org. Reviewed-By:
Jared Hancock <jared@osticket.com>
-
Peter Rotich authored
files: Attempt to standardize thread entry attaching Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
oops: Fix manual sort on help topic admin listing page Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
org: Propagate LEFT joins in join paths Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
Credit @Jared
-
Peter Rotich authored
Use org_id to filter users to update on organization delete
-
Peter Rotich authored
-
- Apr 20, 2016
-
-
Peter Rotich authored
forms: Fix lag updating the CDATA table Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
Config items cache
-
- Apr 19, 2016
-
-
Jared Hancock authored
-
Jared Hancock authored
If something like members__staff is considered leaving the Team model, and the `members` relationship is nullable, and the `staff` relationship is not, in the context of the compiled SQL statement, the second join should also be considered nullable (LEFT join), because otherwise inconsistent results would be returned from the query. In other words, if a count is considered as an annotation to the Team model instances, Teams with zero members should still be considered as valid teams and should be selected with such an annotation. Before this patch, however, the join between TeamMember and Staff would have been an inner join instead of a LEFT join, which could skew the database results.
-
Jared Hancock authored
-
Jared Hancock authored
This fixes an issue where the CDATA table is updated with the OLD version of an answer after it is updated. That is, after an answer is updated, the CDATA table is also updated to reflect the change; however, the old content of the answer value is used when updating the CDATA value.
-
- Apr 14, 2016
-
-
Jared Hancock authored
-
- Apr 13, 2016
-
-
Jared Hancock authored
This fixes an issue where the PK of ThreadEntry will be NULLed in the following code ```php $entry = ThreadEntry::create(array(...)); $entry->save(); $entry->email_info = new ThreadEntryEmailInfo(array( 'mid' => 'xyzAbc', )); ``` In the above code, the $entry->__set('email_info', <ThreadEntryEmailInfo>) would be invoked. The ThreadEntryEmailInfo object is new, and so will cause the local part of the relationship (`id` in this case) to become null further down in the `__set` method. This issue is fixed in this commit by removing the NULL assignment to the new object. This was added in 11322766, however, it is unclear why the null assignment is performed.
-
Jared Hancock authored
This commit attempts to remove some of the confusing and redundant code to attach files to thread entries and replace it with a single code base. It also attempts to remove and error where a single attachment might be attached to a new thread entry multiple times. Lastly, it removes the insert followed by an update for emails with inline images. This should improve performance processing emails as only one trip to the database is now necessary for thread entries with inline images.
-
- Apr 08, 2016
-
-
Peter Rotich authored
Make config items caching class instance based.
-
- Apr 04, 2016
-
-
Peter Rotich authored
forms: Fix attachment security merge conflict
-
- Mar 30, 2016
-
-
Jared Hancock authored
-
- Mar 29, 2016
-
-
Jared Hancock authored
-
Jared Hancock authored
This partially reverts a change in the ORM changing the QuerySet::all() method to return an Iterator rather than an array. I spent a while proposing a patch to replace usage of all() with iterations; however, I cannot propose a valid reason to abandon the previous methodology. This reintroduces the previous behavior: calling all() will yield an array of results from the QuerySet's iteration system.
-
Jared Hancock authored
Somehow the attachment security checks got duplicated and messed up. Perhaps it was a bad merge?
-
Peter Rotich authored
orm: Properly quote objects in queries
-
Jared Hancock authored
-
- Mar 28, 2016
-
-
Jared Hancock authored
Date Time Conversion Mojo Reviewed-By:
Jared Hancock <jared@osticket.com>
-
Jared Hancock authored
-
Jared Hancock authored
This fixes a regression in 4f8f236d, where the parameters are sent in the SQL statement to the database. Objects which are converted to a string must be propertly quoted when placed in the query.
-
Jared Hancock authored
-
Peter Rotich authored
-
- Mar 27, 2016
-
-
Peter Rotich authored
ORM queries avoiding caching Reviewed-By:
Peter Rotich <peter@osticket.com>
-
- Mar 26, 2016
-
-
Jared Hancock authored
-
Jared Hancock authored
-
Jared Hancock authored
-
Jared Hancock authored
-
- Mar 25, 2016
-
-
Peter Rotich authored
Add year to php to Date Picker (js) translation table
-
Peter Rotich authored
Make sure due date time dropdown display matches the option value.
-
Peter Rotich authored
Stop doing double timezone offset
-