Skip to content
Snippets Groups Projects
  1. May 05, 2015
  2. May 04, 2015
  3. May 03, 2015
  4. Apr 30, 2015
  5. Apr 15, 2015
    • Jared Hancock's avatar
      custom-data: Address major confusion · 4efef017
      Jared Hancock authored
      This feature addresses a major issue with the initial implementation of the
      custom data system. The original system confused the usage of
      database-backed field (dynamic-fields) and their corresponding
      implementation. This created the need to crate awkward caching pieces to
      ensure that validation errors and data was maintained. Furthermore, the
      system confused the linking between form instances (dynamic-entry) and the
      form used to represent that entry.
      
      This patch addresses the confusion in two ways:
      
      Dynamic form entries do not link directly to the dynamic form. Instead, the
      ::getForm() method returns something from the forms API directly.
      Furthermore, the ::getFields() method does not return dynamic field
      instances (database backed / designed fields). Instead, the actual
      implementation of the fields from the forms API is retrieved. This allows
      the fields to *always* be cached, which helps preserve data and validation
      state.
      
      Secondly, the dynamic form uses the same system, so that requests to turn a
      dynamic form into a form (via ::getForm) will also result in the same
      behavior, again, where the fields are represented as forms API fields rather
      than the dynamic fields.
      
      So going forward, the dynamic fields are *only* used to create corresponding
      forms API field implementations. The are associated with the dynamic
      counterparts as sparingly as possible.
      4efef017
  6. Apr 10, 2015
  7. Apr 09, 2015
  8. Mar 30, 2015
  9. Mar 18, 2015
  10. Mar 13, 2015
  11. Mar 09, 2015
  12. Mar 02, 2015
  13. Feb 25, 2015
    • Peter Rotich's avatar
      forms: Add Textbox Selection Widget · dd0da7a5
      Peter Rotich authored
      Add a text box widget to selection field. It functions like typeahead and
      drop down widgets with the exception that the user doesn't get the hint. This will
      be useful when a list needs to be used to validate user's input.
      dd0da7a5
  14. Feb 17, 2015
  15. Feb 13, 2015
    • Jared Hancock's avatar
      priority: Admin can elect the priority of each prio field · 30f56195
      Jared Hancock authored
      This allows for multiple priority fields to specify differing defaults, and
      it also allows for a selection of 'System Default' in the config, which
      renders as 'Default' when rendered.
      
      It also fixes up a couple PHP warnings about include/class.forms.php
      30f56195
    • Jared Hancock's avatar
      oops: Fix empty export in some cases · 979e4884
      Jared Hancock authored
      If the ticket details form has an extra field of type "Priority Level"
      (beyond the one built in), exports of tickets will be empty.
      
      This patch addresses the issue in the exporter which uses an older version
      of the custom data materialized view (__cdata table), which created separate
      columns for selection and ID values. The current cdata system only creates a
      single column and stores the ID value. It also addresses an issue where the
      ID column was passed to the PriorityField::to_php() as the first argument.
      979e4884
  16. Feb 10, 2015
  17. Jan 13, 2015
  18. Jan 09, 2015
  19. Dec 31, 2014
    • Jared Hancock's avatar
      files: Provide unified download script · d9cf38bc
      Jared Hancock authored
      This script adds a single download script, 'file.php', which provides access
      to files of all types to all users. It uses a HMAC signature system with an
      expires time, which allows signed URLs to be sent to external users.
      
      This also fixes an issue with the Http::cacheable() method, where the
      last-modified and Etag headers were not properly compared, which resulted in
      permanent cache misses by the client.
      d9cf38bc
  20. Dec 15, 2014
    • Jared Hancock's avatar
      Ensure case-insensitive file extension comparison · edcb6960
      Jared Hancock authored
      Ensure that when generating the list of acceptable file extensions, that the list is lower cased, because the extension from the filename will be lower-cased before attempting to find the extension in the list of acceptable extensions.
      edcb6960
  21. Dec 11, 2014
  22. Dec 10, 2014
  23. Dec 08, 2014
Loading