Skip to content
Snippets Groups Projects
  1. Oct 02, 2018
    • aydreeihn's avatar
      Attachment Names Issue · 86946d58
      aydreeihn authored
      This commit ensures that we will always get the correct attachment name regardless of if the file content is the same. Additionally, it ensures that the file_ids for attachments are compared in the correct order (elseifs)
      86946d58
  2. Sep 27, 2018
    • aydreeihn's avatar
      Form Attachment Issues · 31591904
      aydreeihn authored
      - Make sure we keep attachments in the session even if the page refreshes to display an error message
      - Reverse the array of files to be id => name instead of name => id
      - Make sure we retain the old ticket or task id if we encounter an error while trying to create a ticket or task from a thread entry
      - Make sure we have a valid fileId before returning file info
      - Make sure we can still add files for Canned Responses (id and name flip issue)
      - Make sure we can still add attachments to Internal Notes for Tickets and Tasks
      31591904
  3. Jul 05, 2018
  4. May 25, 2018
  5. May 17, 2018
    • aydreeihn's avatar
      Create Task/Ticket From Thread Entry Fixes: · 1b5cf050
      aydreeihn authored
      - unset the sessions form data only in necessary places
      - refer to a tasks number instead of id in internal notes
      - use indexOf instead of includes in js for IE compatibility
      1b5cf050
  6. May 16, 2018
    • aydreeihn's avatar
      Creating Tasks/Tickets From Thread Entry Fixes: · b7db24aa
      aydreeihn authored
      - say created from thread entry instead of created from thread
      - make sure that links to thread entry do not open in new window
      - make sure if default help topic is selected, message data carries over
        - make sure if issue details are not included for a help topic form, we
          make sure there is a message before trying to get attachments for one
      - do not pass in an object to session array. use id and do lookup after instead
      b7db24aa
  7. May 15, 2018
    • aydreeihn's avatar
      Creating Tasks/Tickets from Thread: · 01323881
      aydreeihn authored
      When a Task or Ticket is created from a Thread, this code
      adds the functionality to create an Internal Note in the
      new Ticket or Task as well as the original Ticker or
      Task to show the activity that happened.
      01323881
  8. Mar 17, 2017
  9. Jun 14, 2016
  10. May 09, 2016
  11. Apr 27, 2016
    • Michael's avatar
      Update ajax.tasks.php · 99354f87
      Michael authored
      Change to make one translation less since `%s is currently assigned to <b>%s</b>` is already used in ajax.tasks.php and ajax.tickets.php
      99354f87
  12. Apr 21, 2016
    • Michael's avatar
      Update ajax.tasks.php and ajax.tickets.php · f3205662
      Michael authored
      Note: Since I'm not sure if that's all (replacing %s %s with %1$s %2$s) which is necessary to make this work, I'm sorry in advance for a potential "bad commit".
      
      As already written on Crowdin, in German the order is wrong, so my suggestion is to make it possible to change the order by transforming "%s %s" to "%1$s and %2$s".
      Format in English: Successfully assigned 4 selected tasks
      Needed German: Successfully 4 selected tasks assigned
      f3205662
  13. Apr 19, 2016
    • Michael's avatar
      Update ajax.tasks.php · 6e0ddf2e
      Michael authored
      Too much splitting here... just realized it when I looked at Crowdin that the German translations sounds like a Google Translation - so basically ok, but obviously wrong.
      Reason is that you often don't know what %s stands for and here %s was splitted up into another string with antoher %s which is definitely too much for good :/
      6e0ddf2e
  14. Apr 12, 2016
    • Michael's avatar
      i18n v1.10 translation issues · 1ac8525d
      Michael authored
      Hi Jared @greezybacon,
      
      while translating the new version we from the core of the german translation team (@mfelber and I) ran across several issues with some strings and we opened a lot of issues over at Crowdin, but I think the better way is to propose several PRs here at Github for all the issues (or a large PR with all the issues and a commit for each issue, so you can cherrypick commits).
      
      Before opening all those PRs / one large PR, I just like to know what's the best way to do so (which branch to be used - develop? develop-next?, what type of PR - large PR with several commits? several PRs for each issue? and so on) or if you prefer to look at the issues over at Crowdin and we shall continue opening them there?
      
      The changes within this PR are suggesting to remove the extra "REOPEN %s" and "CLOSE %s" translations since it's really hard to understand what you really translate / in which context you translate here - especially when NOT looking at the source code. Since most translators in my opinion will translate the 3 current strings:
       - Are you sure you want to %s
      - CLOSE %s
      - selected task / selected tasks
      in another way as they would translate the suggestion within this PR:
      - Are you sure you want to CLOSE %s
      - selected task / selected tasks
      I think it'd make sense to change it.
      
      Would be great if you could advise on how to proceed with this and all the other issues we already opened at Crowdin.
      
      Thanks in advance!
      
      Cheers
      Michael
      1ac8525d
  15. Mar 25, 2016
  16. Mar 24, 2016
  17. Mar 01, 2016
  18. Dec 31, 2015
    • Peter Rotich's avatar
      Tasks Actions · 582468a0
      Peter Rotich authored
      Make tasks actions icon based buttons
      Fix task assignment issue
      582468a0
  19. Aug 06, 2015
    • Peter Rotich's avatar
      Mass Ticket Actions · 19f42ca4
      Peter Rotich authored
      - Adds mass assign, transfer to ticket queues
      - Retire inline forms for ticket assignment and transfer
      19f42ca4
  20. Jul 13, 2015
  21. May 13, 2015
  22. May 05, 2015
  23. Dec 20, 2014
  24. Dec 11, 2014
Loading