Skip to content
Snippets Groups Projects
  1. Jul 30, 2018
    • JediKev's avatar
      issue: CLI Deploy Missing Bootstrap Fix · 2dc08a9e
      JediKev authored
      This addresses an issue introduced with 4332 where the deploy CLI breaks
      upon deploying to an existing location. This checks to see if there is a
      bootstrap file in the destination first and if so it uses that one if not
      uses the source.
      2dc08a9e
    • JediKev's avatar
      issue: ChoiceField Template Variable · 759b004c
      JediKev authored
      This addresses an issue on the forums where osTicket does not add the proper
      values to any custom choices field template variable. This adds an `asVar()`
      function to `class ChoiceField` so we can return the proper values for the
      template variables.
      759b004c
    • JediKev's avatar
      issue: Client Side Column Sorting · 9c7a8386
      JediKev authored
      This addresses an issue where client side column sorting does not work at
      all. This is due to the if/else statement that checks for a REQUEST sort
      order and if the REQUEST sort order matches an `$orderWays` array value. The
      if statement returns TRUE for DESC and sets the sort order to DESC as it
      equals '-' (a dash) but ASC equals '' (an empty string) so it returns FALSE
      which fails-over to the else statement setting the sort order to DESC. In
      addition, this adds sorting icons the the column headers to make it more
      obvious they are sortable.
      9c7a8386
    • JediKev's avatar
      issue: Installer Footer Copyright · 7e2729cd
      JediKev authored
      This addresses issue 4339 where the installer footer references the wrong
      copyright date.
      7e2729cd
    • JediKev's avatar
      issue: TextThreadEntryBody Sanitize · cec8be8e
      JediKev authored
      This addresses an issue introduced with a3d896c8 where TextThreadEntryBodies
      are not keeping their new line characters causing the email format to appear
      wonky. This balances the entry and then htmlchars it to ensure no XSS.
      cec8be8e
  2. Jul 25, 2018
  3. Jul 24, 2018
  4. Jul 23, 2018
    • aydreeihn's avatar
      Collaborator Fixes: · a4de3514
      aydreeihn authored
      - Fix for ‘creating default object from empty value’ message
      - Add collaborators in the Ticket::create function instead of Ticket::open so that we can getRecipients in postMessage function
      - Add relevant thread_entry_recipients in postMessage function for front end tickets (scp or Web Portal)
      
      Note: This in turn fixes Issue #4354
      a4de3514
    • aydreeihn's avatar
      Recipients Icon + View Email Recipients for Users · 8c707b5d
      aydreeihn authored
      This commit puts the recipient icon (for one recipient or multiple) on Thread Entries created by Users. It also stores email recipients so you can view them in the Thread Entry Actions.
      
      For Emails:
      All recipients in the email are tracked
      
      For front end entries:
      All recipients who received an alert are tracked
      8c707b5d
  5. Jul 22, 2018
  6. Jul 20, 2018
  7. Jul 19, 2018
  8. Jul 18, 2018
    • aydreeihn's avatar
      Collaborator Tickets Visibility Fix: · 98dc5d9b
      aydreeihn authored
      This commit fixes the counts in the Web Portal based on which Tickets the User has access to.
      98dc5d9b
    • aydreeihn's avatar
      Collaborator Tickets Visibility: · e9db21a5
      aydreeihn authored
      This feature gives Agents the capability deciding whether or not Users should be able to see Tickets to which they are Collaborators for in their Ticket queues.
      
      By default, Users are able to see all Tickets they take part in whether they are the User for the Ticket or a Collaborator.
      
      If the Agent would like to disable Users seeing their Collaborator Tickets, they can configure the setting here:
      Admin Panel | Tickets | Settings | Collaborator Tickets Visibility
      e9db21a5
    • aydreeihn's avatar
      Email Recipients Revisited Corrections · 731c9fe9
      aydreeihn authored
      - Clean up/correct notifyCollaborators function
      - Make sure function calls are passing in all needed variables
      - getContact function added to EmailRecipient class to properly set up email notifications
      - Corrections on encoding recipients for thread entries
      731c9fe9
    • Peter Rotich's avatar
      Merge pull request #26 from aydreeihn/issue/collaborator-font · 2325760f
      Peter Rotich authored
      Ticket-View Collaborator Collapsible Fix:
      2325760f
    • aydreeihn's avatar
      Ticket-View Collaborator Collapsible Fix: · 7be98ee7
      aydreeihn authored
      This commit fixes an issue where the font for the word 'Collaborators' was being overwritten by the font associated with the icon-caret-right class.
      7be98ee7
  9. Jul 17, 2018
    • Peter Rotich's avatar
      Merge pull request #4151 from nicoletta-maia/develop-fix_orderby_relevance · 0b88a37d
      Peter Rotich authored
      Issue: SQL Error Unknown column '__relevance__' in 'order clause'
      0b88a37d
    • Peter Rotich's avatar
      Merge pull request #4281 from PeopleInside/patch-1 · 65de3273
      Peter Rotich authored
      Update class.forms.php
      65de3273
    • Peter Rotich's avatar
      Merge pull request #4280 from PeopleInside/patch-2 · 3853e081
      Peter Rotich authored
      Update class.list.php
      3853e081
    • Peter Rotich's avatar
      Merge pull request #4311 from nicoletta-maia/develop-frequest_canned_resp_select2 · 2d0218d7
      Peter Rotich authored
      Feature: canned response rendered using select2
      2d0218d7
    • Peter Rotich's avatar
      Merge branch '1.10.x' into develop-next · e3219829
      Peter Rotich authored
      Conflicts:
      	WHATSNEW.md
      	include/class.dept.php
      	include/staff/department.inc.php
      	include/staff/tickets.inc.php
      v1.11.0-rc1
      e3219829
    • Peter Rotich's avatar
      Add Release Notes for v1.10.4 · 035fd0af
      Peter Rotich authored
      v1.10.4
      035fd0af
    • JediKev's avatar
      issue: Orphaned File Query Rewrite · e5dd24e0
      JediKev authored
      This addresses an issue that was introduced by a previous attempt to
      address the orphaned file query. The previous attempt addressed the
      original issue but slowed database performance so this addresses the
      performance issue.
      e5dd24e0
    • JediKev's avatar
      department: Error Feedback · 9f3b6b27
      JediKev authored
      This addresses an issue where osTicket did not ensure associated items exist
      before saving to the database. This also addresses an issue where the Parent
      Topic error was not displayed on page.
      9f3b6b27
    • JediKev's avatar
      security: Fix Multiple XSS Vulnerabilies · 4b8ee133
      JediKev authored
      It may be possible to steal or manipulate customer session and cookies,
      which might be used to impersonate a legitimate user, allowing the hacker to
      view or alter user records, and to perform transactions as that user.
      Sanitation of hazardous characters was not performed correctly on user
      input.
      
      osTicket did not properly sanitize array values in `Format::htmlchars()`.
      Some values in the Admin Interface were not properly sanitized and returned
      to the response.
      4b8ee133
    • JediKev's avatar
      issue: Auto-Assignment Log · d4262cef
      JediKev authored
      This addresses an issue on the Forums where the Auto-Assignment Thread
      Event (configurable via Help Topic) uses the Email of the User rather than
      the User’s Name. This adds the correct function to retrieve the User’s
      Name if the User has an Account.
      d4262cef
    • JediKev's avatar
      issue: Ticket Lock On Disable · 606f45ba
      JediKev authored
      This addresses an issue where disabling Ticket Locks but setting a time
      for the Lock Timeout will always throw a "lock required" error. This adds
      a check to see if locks are enabled AND there is a time set. If locks are
      disabled it will not throw the error.
      606f45ba
    • JediKev's avatar
      issue: User Import No Email · b65185ba
      JediKev authored
      This addresses issue 4329 where you can import a User with no email
      address via CSV file. Once the User is added and you try to update them
      with an email address it fails due to no default email. This updates the
      check for email address from `!isset()` to `empty()` which will correctly
      check for empty string.
      b65185ba
    • JediKev's avatar
      issue: CLI Deploy Missing Bootstrap · ee208fca
      JediKev authored
      This addresses issue 4322 where deploying via CLI is missing
      `bootstrap.php`. This is due to the `get_include_dir()` function that
      tries to include a file from the destination which doesn’t exist yet,
      causing a fatal error. This updates the function to use `$this->source`
      instead of `$this->destination` to correctly find and include
      `bootstrap.php`.
      ee208fca
    • JediKev's avatar
      issue: Language Pack Locale Mismatch · 132d838f
      JediKev authored
      This addresses issue 4325 where the Language Pack Locales are mismatched.
      The Locale for the first language is displayed on the second language,
      etc. This updates the `$manifest` variable to be set before we display
      data so the correct `MANIFEST` file is included and all language data is
      displayed correctly.
      132d838f
Loading