Message id tracking revisited

Reviewed-By: Jared Hancock <jared@osticket.com>

Disable Kerberos and NTLM auth for mail fetch

Reviewed-By: Peter Rotich <peter@osticket.com>

Implement RFC5987 for fetched attachments

Reviewed-By: Peter Rotich <peter@osticket.com>

line is used.

id/number.

* Ticket number will be customization in the future
* Ticket thread only link to Ticket should be internal ticket id.

Accept attachments from email messages

Reviewed-By: Peter Rotich <peter@osticket.com>

Actually show correct template description

Reviewed-By: Peter Rotich <peter@osticket.com>

if the References or In-Reply-To header matches in a way that continues a
ticket's thread, include the attachments in the thread if allowed by the
system settings.

Fixes #742

On some configurations of PHP and remote mail servers, Kerberos and NTLM
challenge response authentication could be possibly attempted. This is
essentially futile and potentially fatal for osTicket mail fetching, as the
system is currently designed for username and password authentication only.

This patch disables challenge and response authentication for PHP versions
5.3.2 and newer, which support the fix.

This patch also consistently encodes mailbox names according to the rfc 2060
for IMAP.

Previously, filenames specified in email headers fetched using the PHP imap
extension were not decoded properly. Specifically, if RFC5987 was used to
encode the filenames, no decoding was performed at all.

This patch properly detects the filename attribute, using a decoding scheme
for RFC5987 if the attribute was encoded properly.

References:
http://osticket.com/forums/showthread.php?t=6129

Detect attachments with Content-Type: ...; name=

Reviewed-With: Jared Hancock <jared@osticket.com>

RFC2045, section 5.1 seems to indicate that arbitrary parameters can be
appended to a Content-Type header specification. Some email clients seem to
use the Content-Type header to specify an attachment without giving a
separate Content-Disposition header normally used to signify attachments.

This patch corrects attachment detection for piped emails to detect such
emails. The patch also correctly decodes filenames specified either in the
Content-Disposition or Content-Type headers using RFC5987, where the
filename can be encoded using an arbitrary character set (ie, not us-ascii).

Fix 1.6-* upgrade to 1.7.1

Reviewed-By: Peter Rotich <peter@osticket.com>

8e72e521 (v1.7.1.2+) introduced a bug where
osTicket version 1.6 would not send a cookie (by calling PHP
session_start()) for the login page. Therefore, after unpacking the 1.7.1
source code, an upgrade would not be possible, because a login would never
be processed correctly.

Last mile for test failures

Reviewed-By: Peter Rotich <peter@osticket.com>

Add stubs.php to include stub classes for built-in PHP classes used
throughout the code. This will allow the testing suite to verify that a
method exists, albeit not in our codebase

Fix email address comparison issue

Reviewed-By: Peter Rotich <peter@osticket.com>

When comparing the From address of incoming email. If the ticket owner sent
an email back into the system and the email address did not match exactly,
case-wise, the email would not be considered from the ticket owner.

Fix bug detecting emails from system email addresses

Reviewed-With: Peter Rotich <peter@osticket.com>

Show correct description for template edits

Reviewed-By: Peter Rotich <peter@osticket.com>

Fix ROOT_PATH detection on Windows

Reviewed-By: Peter Rotich <peter@osticket.com>

Avoid double-encoding thread titles

Reviewed-By: Peter Rotich <peter@osticket.com>

Fixes cookie domain specification

Reviewed-By: Peter Rotich <peter@osticket.com>

Also converts ROOT_DIR detection to always use forward slashes. And it fixes
the removal of the leading double-backslash on Windows UNC names (fixes #649)

This is safe now, because the title is appropriately encoded in
class.thread.php/ThreadEntry::create()

Fixes #567, #718

if the domain given in HTTP_HOST variable happens to have a port
specification. Technically, the port specification should not be included in
the domain spec given in the cookie.

(And for the record, that makes no sense to me, seeing as a cookie would
otherwise be valid for all servers on any ports at a particular domain).

The previous implementation did not work correctly for symlinked folders.
The new approach uses debug_backtrace() and ROOT_DIR to determine the
difference between ROOT_DIR and the osTicket installation path.

This thing is like a turd that won't flush

Forbid message loops for alert messages

Reviewed-By: Peter Rotich <peter@osticket.com>

Turn off display_errors for releases

Reviewed-By: Peter Rotich <peter@osticket.com>

Add random string generator to Crypto

Reviewed-By: Jared Hancock <jared@osticket.com>

and restarts PHP SESSION

Remove "Howdy" as the salutation - no sense of humor in this world!

Reviewed-By: Jared Hancock <jared@osticket.com>

Feature/root path revisited -- hopefully this issue will die here

Reviewed-By: Jared Hancock <jared@osticket.com>