Skip to content
Snippets Groups Projects
  1. Jul 20, 2018
  2. Jul 19, 2018
  3. Jul 17, 2018
    • Peter Rotich's avatar
      Merge pull request #4151 from nicoletta-maia/develop-fix_orderby_relevance · 0b88a37d
      Peter Rotich authored
      Issue: SQL Error Unknown column '__relevance__' in 'order clause'
    • Peter Rotich's avatar
      Merge pull request #4281 from PeopleInside/patch-1 · 65de3273
      Peter Rotich authored
      Update class.forms.php
    • Peter Rotich's avatar
      Merge pull request #4280 from PeopleInside/patch-2 · 3853e081
      Peter Rotich authored
      Update class.list.php
    • Peter Rotich's avatar
      Merge pull request #4311 from nicoletta-maia/develop-frequest_canned_resp_select2 · 2d0218d7
      Peter Rotich authored
      Feature: canned response rendered using select2
    • Peter Rotich's avatar
      Add Release Notes for v1.10.4 · 035fd0af
      Peter Rotich authored
      v1.10.4
      035fd0af
    • JediKev's avatar
      issue: Orphaned File Query Rewrite · e5dd24e0
      JediKev authored
      This addresses an issue that was introduced by a previous attempt to
      address the orphaned file query. The previous attempt addressed the
      original issue but slowed database performance so this addresses the
      performance issue.
      e5dd24e0
    • JediKev's avatar
      department: Error Feedback · 9f3b6b27
      JediKev authored
      This addresses an issue where osTicket did not ensure associated items exist
      before saving to the database. This also addresses an issue where the Parent
      Topic error was not displayed on page.
      9f3b6b27
    • JediKev's avatar
      security: Fix Multiple XSS Vulnerabilies · 4b8ee133
      JediKev authored
      It may be possible to steal or manipulate customer session and cookies,
      which might be used to impersonate a legitimate user, allowing the hacker to
      view or alter user records, and to perform transactions as that user.
      Sanitation of hazardous characters was not performed correctly on user
      input.
      
      osTicket did not properly sanitize array values in `Format::htmlchars()`.
      Some values in the Admin Interface were not properly sanitized and returned
      to the response.
      4b8ee133
    • JediKev's avatar
      issue: Auto-Assignment Log · d4262cef
      JediKev authored
      This addresses an issue on the Forums where the Auto-Assignment Thread
      Event (configurable via Help Topic) uses the Email of the User rather than
      the User’s Name. This adds the correct function to retrieve the User’s
      Name if the User has an Account.
      d4262cef
    • JediKev's avatar
      issue: Ticket Lock On Disable · 606f45ba
      JediKev authored
      This addresses an issue where disabling Ticket Locks but setting a time
      for the Lock Timeout will always throw a "lock required" error. This adds
      a check to see if locks are enabled AND there is a time set. If locks are
      disabled it will not throw the error.
      606f45ba
    • JediKev's avatar
      issue: User Import No Email · b65185ba
      JediKev authored
      This addresses issue 4329 where you can import a User with no email
      address via CSV file. Once the User is added and you try to update them
      with an email address it fails due to no default email. This updates the
      check for email address from `!isset()` to `empty()` which will correctly
      check for empty string.
      b65185ba
    • JediKev's avatar
      issue: CLI Deploy Missing Bootstrap · ee208fca
      JediKev authored
      This addresses issue 4322 where deploying via CLI is missing
      `bootstrap.php`. This is due to the `get_include_dir()` function that
      tries to include a file from the destination which doesn’t exist yet,
      causing a fatal error. This updates the function to use `$this->source`
      instead of `$this->destination` to correctly find and include
      `bootstrap.php`.
      ee208fca
    • JediKev's avatar
      issue: Language Pack Locale Mismatch · 132d838f
      JediKev authored
      This addresses issue 4325 where the Language Pack Locales are mismatched.
      The Locale for the first language is displayed on the second language,
      etc. This updates the `$manifest` variable to be set before we display
      data so the correct `MANIFEST` file is included and all language data is
      displayed correctly.
      132d838f
    • Peter Rotich's avatar
      Add Release Notes for v1.10.4 · 8ac8a30a
      Peter Rotich authored
      8ac8a30a
  4. Jul 16, 2018
  5. Jul 13, 2018
  6. Jul 09, 2018
    • JediKev's avatar
      issue: CLI Deploy Missing Bootstrap · fd75eddf
      JediKev authored
      This addresses issue 4322 where deploying via CLI is missing
      `bootstrap.php`. This is due to the `get_include_dir()` function that
      tries to include a file from the destination which doesn’t exist yet,
      causing a fatal error. This updates the function to use `$this->source`
      instead of `$this->destination` to correctly find and include
      `bootstrap.php`.
      fd75eddf
  7. Jul 03, 2018
    • JediKev's avatar
      issue: Language Pack Locale Mismatch · a87f19d3
      JediKev authored
      This addresses issue 4325 where the Language Pack Locales are mismatched.
      The Locale for the first language is displayed on the second language,
      etc. This updates the `$manifest` variable to be set before we display
      data so the correct `MANIFEST` file is included and all language data is
      displayed correctly.
      a87f19d3
  8. Jun 11, 2018
  9. Jun 07, 2018
    • JediKev's avatar
      issue: Auto-Assignment Log · e4329513
      JediKev authored
      This addresses an issue on the Forums where the Auto-Assignment Thread
      Event (configurable via Help Topic) uses the Email of the User rather than
      the User’s Name. This adds the correct function to retrieve the User’s
      Name if the User has an Account.
      e4329513
  10. Jun 05, 2018
  11. May 15, 2018
    • Peter Rotich's avatar
      Add release notes for v1.10.3 · b7ef532d
      Peter Rotich authored
      v1.10.3
      b7ef532d
    • Peter Rotich's avatar
      Lint: Lint fixes · 914b6e64
      Peter Rotich authored
      914b6e64
    • JediKev's avatar
      issue: Section Break Hint · d60779e8
      JediKev authored
      This addresses an issue where the Help Text for Section Break fields does
      not display custom Redactor styling correctly. Instead of displaying the
      properly formatted Redactor content with it's styling it displays the
      entire html for the Redactor content. This was due to the format method
      used for the Section Break Field's Help Text. This updates the method from
      `Format::htmlchars()` to `Format::display()` which displays the properly
      formatted content. The content is also sanitized by `Format::sanitize()`
      before saving to the database to avoid any chance of XSS.
      d60779e8
    • Jared Hancock's avatar
      queryset: Fix circular reference error · e657a33e
      Jared Hancock authored
      This fixes an error where the ModelInstanceManager maintained a reference to
      the QuerySet instance, and the QuerySet instance managed a reference to the
      ModelInstanceManager instance (if it's the iterator for the query). Because
      of the circular reference, if the iterator is not exhausted, then the
      resource is not closed and the query remains open. This wastes memory and
      prevents some other queries from running after such a situation happens.
      
      This addresses the issue by removing the circular reference between the
      QuerySet and the ModelInstanceManager.
      e657a33e
    • Mat Whitney's avatar
      Check permissions before displaying Close Task · f62e9669
      Mat Whitney authored
      Don't display the Close Task option if the current user can't close it...
      f62e9669
    • JediKev's avatar
      format: Fix Vimeo iFrames · ae9a9cc9
      JediKev authored
      This addresses an issue where some Vimeo videos are not being sent in
      Agent’s responses. This adds `player.vimeo` to the sanitize method’s
      iframe section so that the iframe tag is not stripped.
      ae9a9cc9
    • JediKev's avatar
      issue: Fix imap_open Disable Authenticator · 1d1df935
      JediKev authored
      This addresses an issue where the 'DISABLE_AUTHENTICATOR' args were not
      properly added to the `imap_open` params. This changes the `+=` operator
      to `array_merge()` to successufully add the params.
      1d1df935
    • JediKev's avatar
      issue: Prevent Click Jacking · 8c3f7a5f
      JediKev authored
      This addresses a vulnerability where there was no `X-Frame-Options` header
      which could potentially allow click jacking. This adds the
      `X-Frame-Options: SAMEORIGIN` header so it will remove any chance of click
      jacking. According to Mozilla Developer Docs:
      ```
      SAMEORIGIN
      The page can only be displayed in a frame on the same origin as the page
      itself.
      ```
      8c3f7a5f
Loading