lint: Fixup lint-reported errors

include/ajax.tickets.php

@@ -187,8 +187,6 @@ class TicketsAjaxAPI extends AjaxController {
             return 1;
         }
         return $lock->release() ? 1 : 0;
-
-        return Lock::removeStaffLocks($thisstaff->getId(), $ticket) ? 1 : 0;
     }
 
     function previewTicket ($tid) {

include/class.avatar.php

@@ -110,9 +110,6 @@ extends Avatar {
     }
 
     function getUrl($size) {
-        if (false && ($file = $this->user->getAvatarFile()))
-            return $file->getDownloadUrl();
-
         $code = $this->code;
         if (!$code && method_exists($this->user, 'getExtraAttr'))
             $code = $this->user->getExtraAttr('avatar');

include/class.list.php

@@ -324,6 +324,7 @@ class DynamicList extends VerySimpleModel implements CustomList {
 
     // Fields shown on the list items page
     function getSummaryFields() {
+        $prop_fields = array();
         foreach ($this->getConfigurationForm()->getFields() as $f) {
             if (in_array($f->get('type'), array('text', 'datetime', 'phone')))
                 $prop_fields[] = $f;
@@ -1121,6 +1122,7 @@ class TicketStatusList extends CustomListHandler {
     function getSummaryFields() {
         // Like the main one, except the description and state fields are
         // welcome on the screen
+        $prop_fields = array();
         foreach ($this->getConfigurationForm()->getFields() as $f) {
             if (in_array($f->get('type'), array('state', 'text', 'datetime', 'phone')))
                 $prop_fields[] = $f;

setup/test/tests/stubs.php

@@ -164,6 +164,10 @@ class NumberFormatter {
     function getSymbol() {}
 }
 
+class Collator {
+    function setStrength() {}
+}
+
 class Aws_Route53_Client {
     function changeResourceRecordSets() {}
 }