From cb54e189fcd1546b041029341a1e46a4571e35ce Mon Sep 17 00:00:00 2001
From: Jared Hancock <jared@osticket.com>
Date: Tue, 4 Aug 2015 14:11:02 -0500
Subject: [PATCH] lint: Fixup lint-reported errors
---
include/ajax.tickets.php | 2 --
include/class.avatar.php | 3 ---
include/class.list.php | 2 ++
setup/test/tests/stubs.php | 4 ++++
4 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/ajax.tickets.php b/include/ajax.tickets.php
index 2a644269f..403b92244 100644
--- a/include/ajax.tickets.php
+++ b/include/ajax.tickets.php
@@ -187,8 +187,6 @@ class TicketsAjaxAPI extends AjaxController {
return 1;
}
return $lock->release() ? 1 : 0;
-
- return Lock::removeStaffLocks($thisstaff->getId(), $ticket) ? 1 : 0;
}
function previewTicket ($tid) {
diff --git a/include/class.avatar.php b/include/class.avatar.php
index c328855a1..93024d02c 100644
--- a/include/class.avatar.php
+++ b/include/class.avatar.php
@@ -110,9 +110,6 @@ extends Avatar {
}
function getUrl($size) {
- if (false && ($file = $this->user->getAvatarFile()))
- return $file->getDownloadUrl();
-
$code = $this->code;
if (!$code && method_exists($this->user, 'getExtraAttr'))
$code = $this->user->getExtraAttr('avatar');
diff --git a/include/class.list.php b/include/class.list.php
index c512e796d..93f666c50 100644
--- a/include/class.list.php
+++ b/include/class.list.php
@@ -324,6 +324,7 @@ class DynamicList extends VerySimpleModel implements CustomList {
// Fields shown on the list items page
function getSummaryFields() {
+ $prop_fields = array();
foreach ($this->getConfigurationForm()->getFields() as $f) {
if (in_array($f->get('type'), array('text', 'datetime', 'phone')))
$prop_fields[] = $f;
@@ -1121,6 +1122,7 @@ class TicketStatusList extends CustomListHandler {
function getSummaryFields() {
// Like the main one, except the description and state fields are
// welcome on the screen
+ $prop_fields = array();
foreach ($this->getConfigurationForm()->getFields() as $f) {
if (in_array($f->get('type'), array('state', 'text', 'datetime', 'phone')))
$prop_fields[] = $f;
diff --git a/setup/test/tests/stubs.php b/setup/test/tests/stubs.php
index b40053bd2..67539baa8 100644
--- a/setup/test/tests/stubs.php
+++ b/setup/test/tests/stubs.php
@@ -164,6 +164,10 @@ class NumberFormatter {
function getSymbol() {}
}
+class Collator {
+ function setStrength() {}
+}
+
class Aws_Route53_Client {
function changeResourceRecordSets() {}
}
--
GitLab