lint: oopses

include/class.collaborator.php

@@ -98,6 +98,7 @@ implements EmailContact, ITicketUser {
 
         switch (strtolower($what)) {
         case 'ticket_link':
+            $qstr = array();
             if ($this->getTicket()->getAuthToken($this)
                 && ($ticket=$this->getTicket())
                 && !$ticket->getThread()->getNumCollaborators()) {

include/class.ticket.php

@@ -949,7 +949,6 @@ implements RestrictedAccess, Threadable, Searchable {
             ))->update(array(
                 'updated' => SqlFunction::NOW(),
             ));
-            $collab->save();
         }
 
         if ($cids) {
@@ -2349,6 +2348,7 @@ implements RestrictedAccess, Threadable, Searchable {
 
           $c = $this->getThread()->addCollaborator($user,array(), $errors);
 
+          $addresses = array();
           foreach (array('To', 'TO', 'Cc', 'CC') as $k) {
             if ($user && isset($hdr[$k]) && $hdr[$k])
               $addresses[] = Mail_Parse::parseAddressList($hdr[$k]);

scp/tickets.php

@@ -473,6 +473,7 @@ $queues = CustomQueue::queues()
 foreach ($queues->findAll(array('parent_id' => 0))
 as $q) {
     $nav->addSubMenu(function() use ($q, $queue) {
+        $selected = false;
         // A queue is selected if it is the one being displayed. It is
         // "child" selected if its ID is in the path of the one selected
         $child_selected = $queue
@@ -487,6 +488,7 @@ as $q) {
 // Add my advanced searches
 $nav->addSubMenu(function() use ($queue) {
     global $thisstaff;
+    $selected = false;
     // A queue is selected if it is the one being displayed. It is
     // "child" selected if its ID is in the path of the one selected
     $child_selected = $queue instanceof SavedSearch;