Skip to content
Snippets Groups Projects
Commit 2c9dbeb9 authored by Peter Rotich's avatar Peter Rotich
Browse files

lint: oopses

parent 7987eb3b
Branches
Tags
No related merge requests found
...@@ -98,6 +98,7 @@ implements EmailContact, ITicketUser { ...@@ -98,6 +98,7 @@ implements EmailContact, ITicketUser {
switch (strtolower($what)) { switch (strtolower($what)) {
case 'ticket_link': case 'ticket_link':
$qstr = array();
if ($this->getTicket()->getAuthToken($this) if ($this->getTicket()->getAuthToken($this)
&& ($ticket=$this->getTicket()) && ($ticket=$this->getTicket())
&& !$ticket->getThread()->getNumCollaborators()) { && !$ticket->getThread()->getNumCollaborators()) {
......
...@@ -949,7 +949,6 @@ implements RestrictedAccess, Threadable, Searchable { ...@@ -949,7 +949,6 @@ implements RestrictedAccess, Threadable, Searchable {
))->update(array( ))->update(array(
'updated' => SqlFunction::NOW(), 'updated' => SqlFunction::NOW(),
)); ));
$collab->save();
} }
if ($cids) { if ($cids) {
...@@ -2349,6 +2348,7 @@ implements RestrictedAccess, Threadable, Searchable { ...@@ -2349,6 +2348,7 @@ implements RestrictedAccess, Threadable, Searchable {
$c = $this->getThread()->addCollaborator($user,array(), $errors); $c = $this->getThread()->addCollaborator($user,array(), $errors);
$addresses = array();
foreach (array('To', 'TO', 'Cc', 'CC') as $k) { foreach (array('To', 'TO', 'Cc', 'CC') as $k) {
if ($user && isset($hdr[$k]) && $hdr[$k]) if ($user && isset($hdr[$k]) && $hdr[$k])
$addresses[] = Mail_Parse::parseAddressList($hdr[$k]); $addresses[] = Mail_Parse::parseAddressList($hdr[$k]);
......
...@@ -473,6 +473,7 @@ $queues = CustomQueue::queues() ...@@ -473,6 +473,7 @@ $queues = CustomQueue::queues()
foreach ($queues->findAll(array('parent_id' => 0)) foreach ($queues->findAll(array('parent_id' => 0))
as $q) { as $q) {
$nav->addSubMenu(function() use ($q, $queue) { $nav->addSubMenu(function() use ($q, $queue) {
$selected = false;
// A queue is selected if it is the one being displayed. It is // A queue is selected if it is the one being displayed. It is
// "child" selected if its ID is in the path of the one selected // "child" selected if its ID is in the path of the one selected
$child_selected = $queue $child_selected = $queue
...@@ -487,6 +488,7 @@ as $q) { ...@@ -487,6 +488,7 @@ as $q) {
// Add my advanced searches // Add my advanced searches
$nav->addSubMenu(function() use ($queue) { $nav->addSubMenu(function() use ($queue) {
global $thisstaff; global $thisstaff;
$selected = false;
// A queue is selected if it is the one being displayed. It is // A queue is selected if it is the one being displayed. It is
// "child" selected if its ID is in the path of the one selected // "child" selected if its ID is in the path of the one selected
$child_selected = $queue instanceof SavedSearch; $child_selected = $queue instanceof SavedSearch;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment