From 2c9dbeb932d78ef995edfd8e386d0429bea8cd8a Mon Sep 17 00:00:00 2001
From: Peter Rotich <peter@enhancesoft.com>
Date: Mon, 30 Oct 2017 05:54:11 +0000
Subject: [PATCH] lint: oopses
---
include/class.collaborator.php | 1 +
include/class.ticket.php | 2 +-
scp/tickets.php | 2 ++
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/class.collaborator.php b/include/class.collaborator.php
index 508167221..d6fdbbfc5 100644
--- a/include/class.collaborator.php
+++ b/include/class.collaborator.php
@@ -98,6 +98,7 @@ implements EmailContact, ITicketUser {
switch (strtolower($what)) {
case 'ticket_link':
+ $qstr = array();
if ($this->getTicket()->getAuthToken($this)
&& ($ticket=$this->getTicket())
&& !$ticket->getThread()->getNumCollaborators()) {
diff --git a/include/class.ticket.php b/include/class.ticket.php
index 4cdb6db1c..332f10c12 100644
--- a/include/class.ticket.php
+++ b/include/class.ticket.php
@@ -949,7 +949,6 @@ implements RestrictedAccess, Threadable, Searchable {
))->update(array(
'updated' => SqlFunction::NOW(),
));
- $collab->save();
}
if ($cids) {
@@ -2349,6 +2348,7 @@ implements RestrictedAccess, Threadable, Searchable {
$c = $this->getThread()->addCollaborator($user,array(), $errors);
+ $addresses = array();
foreach (array('To', 'TO', 'Cc', 'CC') as $k) {
if ($user && isset($hdr[$k]) && $hdr[$k])
$addresses[] = Mail_Parse::parseAddressList($hdr[$k]);
diff --git a/scp/tickets.php b/scp/tickets.php
index fc4eb4b66..5f7002bfc 100644
--- a/scp/tickets.php
+++ b/scp/tickets.php
@@ -473,6 +473,7 @@ $queues = CustomQueue::queues()
foreach ($queues->findAll(array('parent_id' => 0))
as $q) {
$nav->addSubMenu(function() use ($q, $queue) {
+ $selected = false;
// A queue is selected if it is the one being displayed. It is
// "child" selected if its ID is in the path of the one selected
$child_selected = $queue
@@ -487,6 +488,7 @@ as $q) {
// Add my advanced searches
$nav->addSubMenu(function() use ($queue) {
global $thisstaff;
+ $selected = false;
// A queue is selected if it is the one being displayed. It is
// "child" selected if its ID is in the path of the one selected
$child_selected = $queue instanceof SavedSearch;
--
GitLab