fix: make dto properties consistent OP#246

Description

https://plan.vereign.com/projects/vbd/work_packages/246 Current: DTO state is kinda ok, but Matthias had some comments, that when he create a swagger file from our swagger json it does have inconsistencies, like not returning mandatory fields.

Desired: We should check what are the exact problems and fix them.

Related issues

https://plan.vereign.com/projects/vbd/work_packages/246

Testing

The issue was only with field:

in the result type of issue_credential (and fetch_credentials) the attribute credentialRecordType is mandatory but always UNSET

I removed this property

As soon as I touched almost all DTOs, just to check that App works in general

Checklist

• I have updated the documentation (if necessary)
• I have added unit tests for new functionality (if applicable)
• My code follows the style guidelines of this project
• I have tested this code on my local machine before submitting this MR

Reviewers

@zdravko.iliev @boyan.tsolov

marked this merge request as draft

added 4 commits

• c1d3db63 - OP#242 separate service into smaller services
• 433865e9 - op#242 apply prettier
• 7737dcb7 - OP#242 Group all askar services under one folder
• b2a8933a - OP#246 refactor DTOs so they are created by static method which force...

Compare with previous version

changed target branch from main to 99-refactor-op-242-separate-service-into-smaller-services

marked the checklist item I have updated the documentation (if necessary) as completed

marked the checklist item I have added unit tests for new functionality (if applicable) as completed

marked the checklist item My code follows the style guidelines of this project as completed

marked the checklist item I have tested this code on my local machine before submitting this MR as completed

requested review from @zdravko.iliev

changed the description

added Need review label

marked this merge request as ready

fromJson is a good idea, but it's implemented in every dto. Usually this is done by using [class transformer](https://github.com/typestack/class-transformer. Then this conversion data to dto will happen with a simple line plainToInstance(dto, data).

I'm ok with the current solution. If you want (and we have the time) try the class transformer, if not push it for testing.

approved this merge request

removed Need review label

added Reviewed label

deleted the 99-refactor-op-242-separate-service-into-smaller-services branch. This merge request now targets the main branch

added 7 commits

• b2a8933a...90c62832 - 3 commits from branch main
• bc46ccec - OP#242 separate service into smaller services
• 601d9f4b - op#242 apply prettier
• 50a713a3 - OP#242 Group all askar services under one folder
• 6d031d77 - OP#246 refactor DTOs so they are created by static method which force...

Compare with previous version

changed the description

added ReadyForQA label

changed the description