Skip to content
Snippets Groups Projects

Fix bugs with invalid credential ID and missing proof section when verifying credentials

Merged Fix bugs with invalid credential ID and missing proof section when verifying credentials
18-vc-validate-id into main
Merged Lyuben Penkovski requested to merge 18-vc-validate-id into main

For some reason the JSONLD processor library used by the Aries packages cannot properly create/verify signatures if the subject id is a simple string (e.g. not a DID/HTTP/Other address). It must either be an address with scheme:address or it must be missing (it's an optional field as defined by the VC spec).

Closes #18 (closed)

Closes #19 (closed)

Edited by Lyuben Penkovski

Merge request reports

Pipeline #53123 passed

Stage:
    Stage:
      Stage:

        Pipeline passed for c29dc74a on 18-vc-validate-id

        Test coverage 59.70% (-7.90%) from 1 job

        Merged by Lyuben PenkovskiLyuben Penkovski 2 years ago (Aug 2, 2022 11:19am UTC)

        Merge details

        Pipeline #53127 passed

        Stage:
          Stage:
            Stage:

              Pipeline passed for 232da818 on main

              Test coverage 59.70% (-7.90%) from 1 job

              Activity

              Filter activity
              • Approvals
              • Assignees & reviewers
              • Comments (from bots)
              • Comments (from users)
              • Commits & branches
              • Edits
              • Labels
              • Lock status
              • Mentions
              • Merge request status
              • Tracking
              Please register or sign in to reply